Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give a meaningful name to the GlobalEndpointManager thread #33507

Merged

Conversation

daphillips-ms
Copy link
Contributor

@daphillips-ms daphillips-ms commented Feb 14, 2023

Description

Several executor threads are called pool-1-thread-12 or such. This PR gives a meaningful name to the thread.

Before:
image

After:
image

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added Cosmos customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Feb 14, 2023
@ghost
Copy link

ghost commented Feb 14, 2023

Thank you for your contribution daphillips-ms! We will review the pull request and get back to you soon.

@daphillips-ms daphillips-ms force-pushed the daphillips/nameThreadsInThreadPools branch 2 times, most recently from 7644002 to 234f315 Compare February 14, 2023 23:17
@daphillips-ms daphillips-ms changed the title Ensure the names of threads are meaningful Give meaningful names to GlobalEndpointManager and ClientTelemetry threads Feb 14, 2023
@daphillips-ms
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@daphillips-ms daphillips-ms force-pushed the daphillips/nameThreadsInThreadPools branch 3 times, most recently from cd21689 to 969be79 Compare February 14, 2023 23:53
@daphillips-ms daphillips-ms changed the title Give meaningful names to GlobalEndpointManager and ClientTelemetry threads Give a meaningful name to the GlobalEndpointManager thread Feb 14, 2023
@daphillips-ms daphillips-ms force-pushed the daphillips/nameThreadsInThreadPools branch from 969be79 to e0f24b5 Compare February 14, 2023 23:54
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cosmos customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants