Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support JsonSerializable and XmlSerializable in JacksonAdapter #33685

Merged
merged 3 commits into from
Feb 23, 2023
Merged

Support JsonSerializable and XmlSerializable in JacksonAdapter #33685

merged 3 commits into from
Feb 23, 2023

Conversation

alzimmermsft
Copy link
Member

Description

Adds support for JsonSerializable and XmlSerializable in JacksonAdapter.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • [] CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@alzimmermsft alzimmermsft self-assigned this Feb 23, 2023
@ghost ghost added the Azure.Core azure-core label Feb 23, 2023
@alzimmermsft alzimmermsft changed the title Az core jackson adapter check for serializable types Support JsonSerializable and XmlSerializable in JacksonAdapter Feb 23, 2023
lmolkova
lmolkova approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! even though it'll be tested by client libs, would be great to add a few tests

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@alzimmermsft alzimmermsft marked this pull request as ready for review February 23, 2023 19:16
@alzimmermsft alzimmermsft merged commit 06afb7c into Azure:main Feb 23, 2023
@alzimmermsft alzimmermsft deleted the AzCore_JacksonAdapterCheckForSerializableTypes branch February 23, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmolkova lmolkova lmolkova approved these changes

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

@anuchandy anuchandy Awaiting requested review from anuchandy anuchandy is a code owner

@vcolin7 vcolin7 Awaiting requested review from vcolin7 vcolin7 is a code owner

@mssfang mssfang Awaiting requested review from mssfang mssfang is a code owner

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles is a code owner

@billwert billwert Awaiting requested review from billwert billwert is a code owner

Assignees

@alzimmermsft alzimmermsft

Labels
Azure.Core azure-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alzimmermsft @azure-sdk @lmolkova