Add http clients to test proxy #33939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billwert
requested review from
alzimmermsft,
srnagar,
anuchandy,
lmolkova,
vcolin7,
mssfang and
JonathanGiles
as code owners
ghost
added
the
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
alzimmermsft
approved these changes
Mar 9, 2023
sdk/core/azure-core-test/src/main/java/com/azure/core/test/InterceptorManager.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core-test/src/main/java/com/azure/core/test/InterceptorManager.java
Outdated
Show resolved
Hide resolved
|
Hello @billwert! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
samvaity
approved these changes
Mar 9, 2023
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two bugs:
LIVEmode. At least some tests have been adding a record policy to anything that was notPLAYBACK. In the old record path this was a no-op. In the new path even if we made the recording step a no-op there would still be lots of work starting up the proxy, etc. Arguably tests that were doing this have a bug: there's no reason to have added a record policy toLIVE, so I'm preventing it.See the wiki for details about this and other potential issues.
This does not yet enable using more than one HTTP client for playback/record. That's a feature request we'll do in the future.