Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form recognizer] Fix Javadoc improvements JDK 20 #36700

Merged
merged 5 commits into from
Sep 13, 2023

Conversation

samvaity
Copy link
Member

No description provided.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Sep 11, 2023

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-ai-formrecognizer

@samvaity samvaity changed the title [Form recognizer] Fix Javadoc improvements JDK 18+ [Form recognizer] Fix Javadoc improvements JDK 20+ Sep 12, 2023
@samvaity samvaity changed the title [Form recognizer] Fix Javadoc improvements JDK 20+ [Form recognizer] Fix Javadoc improvements JDK 20 Sep 12, 2023
@samvaity samvaity marked this pull request as ready for review September 12, 2023 22:18
/**
* Creates or finds a ContentSourceKind from its string representation.
*/
public ContentSourceKind() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is an ExpandableStringEnum this will need to be marked as deprecated and tell users to use the factory method.

/**
* Creates a DocumentModelBuildMode object.
*/
public DocumentModelBuildMode() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is an ExpandableStringEnum this will need to be marked as deprecated and tell users to use the factory method.

/**
* Creates a OperationKind object.
*/
public OperationKind() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is an ExpandableStringEnum this will need to be marked as deprecated and tell users to use the factory method.

/**
* Creates a OperationStatus object.
*/
public OperationStatus() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is an ExpandableStringEnum this will need to be marked as deprecated and tell users to use the factory method.

/**
* Constructs a DocumentAnalysisAudience object.
*/
public DocumentAnalysisAudience() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is an ExpandableStringEnum this will need to be marked as deprecated and tell users to use the factory method.

/**
* Creates a FormRecognizerAudience object.
*/
public FormRecognizerAudience() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is an ExpandableStringEnum this will need to be marked as deprecated and tell users to use the factory method.

/**
* Creates a FormRecognizerLanguage object.
*/
public FormRecognizerLanguage() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is an ExpandableStringEnum this will need to be marked as deprecated and tell users to use the factory method.

/**
* Creates a FormRecognizerLocale object.
*/
public FormRecognizerLocale() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is an ExpandableStringEnum this will need to be marked as deprecated and tell users to use the factory method.

/**
* Constructs a SelectionMarkState object.
*/
public SelectionMarkState() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is an ExpandableStringEnum this will need to be marked as deprecated and tell users to use the factory method.

/**
* Constructs a TextStyleName object
*/
public TextStyleName() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is an ExpandableStringEnum this will need to be marked as deprecated and tell users to use the factory method.

@samvaity samvaity merged commit fa6f086 into Azure:main Sep 13, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants