Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to stabilize flaky tests #36719

Merged

Conversation

alzimmermsft
Copy link
Member

Description

Attempts to stabilize some flaky tests.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@alzimmermsft alzimmermsft self-assigned this Sep 12, 2023
@github-actions github-actions bot added the azure-spring All azure-spring related issues label Sep 12, 2023
@alzimmermsft alzimmermsft marked this pull request as ready for review September 13, 2023 12:24
Copy link
Member

@anuchandy anuchandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see a different concurrent Collection type solves the problem. I don’t understand what special about CopyOnWriteArrayList caused the failure, maybe test assertion is getting not up to date iterator to the list-snapshot. But regardless, for the UT, light weight ConcurrentQueue seems to be good enough.

@alzimmermsft alzimmermsft merged commit 1e09eab into Azure:main Sep 13, 2023
30 checks passed
@alzimmermsft alzimmermsft deleted the AzTest_AttemptToStabalizeFlakyTests branch September 13, 2023 15:32
@trask
Copy link
Member

trask commented Sep 13, 2023

thx @alzimmermsft!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants