Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cosmos pipeline #36758

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Fix cosmos pipeline #36758

merged 1 commit into from
Sep 14, 2023

Conversation

Netyyyy
Copy link
Member

@Netyyyy Netyyyy commented Sep 14, 2023

Description

Fix https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3077931&view=logs&jobId=8bef1c98-23e3-5d36-ff88-ed7605b6f394

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@Netyyyy Netyyyy mentioned this pull request Sep 14, 2023
Merged
6 tasks
@Netyyyy Netyyyy marked this pull request as ready for review September 14, 2023 08:53
@Netyyyy
Copy link
Member Author

Netyyyy commented Sep 14, 2023

@xinlian12 @kushagraThapar @saragluna please help review

kushagraThapar
kushagraThapar approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@kushagraThapar kushagraThapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot @Netyyyy and @saragluna

@kushagraThapar kushagraThapar enabled auto-merge (squash) September 14, 2023 16:04
@kushagraThapar
Copy link
Member

/check-enforcer override

@kushagraThapar kushagraThapar merged commit c2e318b into Azure:main Sep 14, 2023
73 of 82 checks passed
@Netyyyy Netyyyy deleted the myao/fix_cosmos_pl branch October 13, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushagraThapar kushagraThapar kushagraThapar approved these changes

@saragluna saragluna saragluna approved these changes

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli kirankumarkolli is a code owner

@xinlian12 xinlian12 Awaiting requested review from xinlian12

@milismsft milismsft Awaiting requested review from milismsft

@aayush3011 aayush3011 Awaiting requested review from aayush3011

@simorenoh simorenoh Awaiting requested review from simorenoh

@jeet1995 jeet1995 Awaiting requested review from jeet1995

@Pilchie Pilchie Awaiting requested review from Pilchie

Assignees
No one assigned
Labels
Cosmos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Netyyyy @kushagraThapar @saragluna