Stabilize most commonly failing tests #36956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check API changes are not detected in this pull request. |
alzimmermsft
requested review from
srnagar,
anuchandy,
lmolkova,
vcolin7,
mssfang,
JonathanGiles,
billwert,
anilba06,
gkostal and
LarryOsterman
as code owners
lmolkova
reviewed
Sep 27, 2023
| if (proxyRetry) { | ||
| // Exhausted retry attempt return an error. | ||
| return Mono.error(new HttpProxyHandler.HttpProxyConnectException( | ||
| "Failed to connect to proxy. Status: 407", responseAndHeaders.getT2())); |
There was a problem hiding this comment.
Curious why we can't use response.getHeaders() here?
There was a problem hiding this comment.
This takes the Netty HttpHeaders object, not the azure-core HttpHeaders.
lmolkova
reviewed
Sep 27, 2023
| try { | ||
| classPath = Class.forName(className).getCanonicalName(); | ||
| return Class.forName(className).getCanonicalName(); |
There was a problem hiding this comment.
nit: maybe call overload with initialize flag set to false to minimize side-effects?
There was a problem hiding this comment.
I'm a bit confused on this comment, this is a utility method to help the String-based constructor as this has to be the first statement in a constructor.
lmolkova
reviewed
Sep 27, 2023
| // 23 characters that will be ASCII | ||
| byte[] bytes = new byte[23]; | ||
|
|
||
| // yyyy- |
There was a problem hiding this comment.
year 10000 will be a tough one 🤣
There was a problem hiding this comment.
I'll be worried when I see that day 😄
lmolkova
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #36666
Attempts to stabilize the most commonly failing tests in the Core pipeline.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines