Fix possible NoSuchBeanDefinitionException in Spring Monitor #37870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
trask
reviewed
Nov 30, 2023
...main/java/com/azure/monitor/applicationinsights/spring/AzureJdbcDriverAutoConfiguration.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Nov 30, 2023
Comment on lines
+1
to
+2
| spring.datasource.url=jdbc:otel:h2:mem:db | ||
| spring.datasource.driver-class-name=io.opentelemetry.instrumentation.jdbc.OpenTelemetryDriver |
There was a problem hiding this comment.
I have a question unrelated to this PR, why is :otel: needed in the url if the driver-class-name is already specifically using OpenTelemetryDriver?
There was a problem hiding this comment.
I have a question unrelated to this PR, why is
:otel:needed in the url if the driver-class-name is already specifically usingOpenTelemetryDriver?
Need to check the implementation. Today the datasource url has to start with jdbc:otel:.
trask
approved these changes
Nov 30, 2023
jeanbisutti
deleted the
fix-possible-no-such-bean-exception-in-spring-monitor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround waiting for the release of this OTel fix.