Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release ACS Rooms PSTN to GA #39437

Merged
merged 11 commits into from
Apr 3, 2024
Merged

Release ACS Rooms PSTN to GA #39437

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
35e31ad
update to PSTN GA
allchiang-msft Mar 27, 2024
8236e7b
update assets.json
allchiang-msft Mar 27, 2024
f6a3887
revert pom file
allchiang-msft Mar 27, 2024
8464c50
update assets.json
allchiang-msft Mar 27, 2024
17d450d
update changelog
allchiang-msft Mar 27, 2024
a1bfb89
update assets.json
allchiang-msft Mar 27, 2024
8d87802
update changelog
allchiang-msft Mar 27, 2024
9e0680c
update versioning
allchiang-msft Mar 28, 2024
f46eaf3
update assets.json
allchiang-msft Mar 28, 2024
c62f4ad
changelog typo
allchiang-msft Apr 1, 2024
6f07a70
update readme to new version
allchiang-msft Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/versioning/version_client.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ com.azure:azure-communication-jobrouter;1.1.2;1.2.0-beta.1
com.azure:azure-communication-messages;1.0.1;1.1.0-beta.1
com.azure:azure-communication-networktraversal;1.1.0-beta.2;1.1.0-beta.3
com.azure:azure-communication-phonenumbers;1.1.11;1.2.0-beta.4
com.azure:azure-communication-rooms;1.0.9;1.1.0-beta.2
com.azure:azure-communication-rooms;1.0.9;1.1.0
com.azure:azure-communication-sms;1.1.22;1.2.0-beta.1
com.azure:azure-containers-containerregistry;1.2.6;1.3.0-beta.1
com.azure:azure-containers-containerregistry-perf;1.0.0-beta.1;1.0.0-beta.1
Expand Down
11 changes: 2 additions & 9 deletions sdk/communication/azure-communication-rooms/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,8 @@
# Release History

## 1.1.0-beta.2 (Unreleased)

### Features Added

### Breaking Changes

### Bugs Fixed

### Other Changes
## 1.1.0 (2024-04-15)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the version in README too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The readme does not feature the latest version, would you point me to the area that should be updated?

Copy link
Member

@srnagar srnagar Apr 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link above in my previous comment points to a section in README that has the version (it is outdated - 1.0.2). That should be updated to 1.1.0.

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated and pushed, thanks


- General Availability version of PSTN dial-out capability feature.

## 1.0.9 (2024-03-20)

Expand Down
2 changes: 1 addition & 1 deletion sdk/communication/azure-communication-rooms/assets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "java",
"TagPrefix": "java/communication/azure-communication-rooms",
"Tag": "java/communication/azure-communication-rooms_b6caf378c7"
"Tag": "java/communication/azure-communication-rooms_c1bfd681a1"
}
2 changes: 1 addition & 1 deletion sdk/communication/azure-communication-rooms/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<groupId>com.azure</groupId>
<artifactId>azure-communication-rooms</artifactId>
<packaging>jar</packaging>
<version>1.1.0-beta.2</version> <!-- {x-version-update;com.azure:azure-communication-rooms;current} -->
<version>1.1.0</version> <!-- {x-version-update;com.azure:azure-communication-rooms;current} -->
allchiang-msft marked this conversation as resolved.
Show resolved Hide resolved
<name>Microsoft Azure library for ACS Room Service</name>
<description>
This package contains clients and data structures used to create, update, get, delete the Azure Communication Room Service.
Expand Down
6 changes: 3 additions & 3 deletions ...-communication-rooms/src/main/java/com/azure/communication/rooms/RoomsServiceVersion.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ public enum RoomsServiceVersion implements ServiceVersion {
V2023_06_14("2023-06-14"),

/**
* Service version {@code 2023-10-30-preview}
* Service version {@code 2024-04-15}
*/
V2023_10_30_PREVIEW("2023-10-30-preview");
V2024_04_15("2024-04-15");

private final String version;

Expand All @@ -39,6 +39,6 @@ public String getVersion() {
* @return the latest {@link RoomsServiceVersion}
*/
public static RoomsServiceVersion getLatest() {
return V2023_10_30_PREVIEW;
return V2024_04_15;
}
}
2 changes: 1 addition & 1 deletion ...om/azure/communication/rooms/implementation/AzureCommunicationRoomServiceImplBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ public AzureCommunicationRoomServiceImplBuilder retryPolicy(RetryPolicy retryPol
@Generated
public AzureCommunicationRoomServiceImpl buildClient() {
HttpPipeline localPipeline = (pipeline != null) ? pipeline : createHttpPipeline();
String localApiVersion = (apiVersion != null) ? apiVersion : "2023-10-30-preview";
String localApiVersion = (apiVersion != null) ? apiVersion : "2024-04-15";
SerializerAdapter localSerializerAdapter =
(serializerAdapter != null) ? serializerAdapter : JacksonAdapter.createDefaultSerializerAdapter();
AzureCommunicationRoomServiceImpl client =
Expand Down
2 changes: 1 addition & 1 deletion ...ommunication-rooms/src/test/java/com/azure/communication/rooms/RoomsAsyncClientTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -997,7 +997,7 @@ private RoomsAsyncClient setupAsyncClient(HttpClient httpClient, String testName
RoomsClientBuilder builder = getRoomsClientWithConnectionString(
buildAsyncAssertingClient(httpClient == null ? interceptorManager.getPlaybackClient()
: httpClient),
RoomsServiceVersion.V2023_10_30_PREVIEW);
RoomsServiceVersion.V2024_04_15);
communicationClient = getCommunicationIdentityClientBuilder(httpClient).buildClient();
return addLoggingPolicy(builder, testName).buildAsyncClient();
}
Expand Down
2 changes: 1 addition & 1 deletion ...zure-communication-rooms/src/test/java/com/azure/communication/rooms/RoomsClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -970,7 +970,7 @@ private RoomsClient setupSyncClient(HttpClient httpClient, String testName) {
RoomsClientBuilder builder = getRoomsClientWithConnectionString(
buildSyncAssertingClient(httpClient == null ? interceptorManager.getPlaybackClient()
: httpClient),
RoomsServiceVersion.V2023_10_30_PREVIEW);
RoomsServiceVersion.V2024_04_15);

communicationClient = getCommunicationIdentityClientBuilder(httpClient).buildClient();

Expand Down
2 changes: 1 addition & 1 deletion sdk/communication/azure-communication-rooms/swagger/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ To update generated files for rooms service, run the following command
### Code generation settings
``` yaml
require:
- https://raw.githubusercontent.com/Azure/azure-rest-api-specs/16f827b7e3392f4f5bc407a626b292cab29abdf9/specification/communication/data-plane/Rooms/readme.md
- https://raw.githubusercontent.com/Azure/azure-rest-api-specs/91813ca7a287fe944262e992413ce4d51d987276/specification/communication/data-plane/Rooms/readme.md
use: '@autorest/java@4.1.17'
java: true
title: AzureCommunicationRoomService
Expand Down