mgmt, bump tsp version in emitter-package.json #40299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiaofeiCao
requested review from
hallipr,
weshaggard,
benbp and
JimSuplizio
as code owners
eng/emitter-package-lock.json
Outdated
| "lockfileVersion": 3, | ||
| "lockfileVersion": 2, |
There was a problem hiding this comment.
I am not sure why but there is lots of diff in lock file. Is it npm version causing it?
There was a problem hiding this comment.
I'm using tsp-client to generate lock file. Should we switch to use ps1 script?
There was a problem hiding this comment.
It should still follow your local nodejs/npm
Not sure but I guess you need to have 18/9
There was a problem hiding this comment.
I'm using 20/8. Let me update my npm to 9.
weidongxu-microsoft
approved these changes
May 22, 2024
|
/check-enforcer override |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mainly tsp-arm, for fixing
ManagedServiceIdentity.Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines