Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgmt, local generation for Container Service - 2024-05-01 #41118

Merged
merged 6 commits into from
Jul 17, 2024
Merged

mgmt, local generation for Container Service - 2024-05-01 #41118

merged 6 commits into from
Jul 17, 2024

Conversation

v-hongli1
Copy link
Member

@v-hongli1 v-hongli1 commented Jul 11, 2024 •
edited
Loading

relate to issue#5321

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Jul 11, 2024
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure.resourcemanager:azure-resourcemanager-containerservice

@v-hongli1 v-hongli1 marked this pull request as ready for review July 15, 2024 02:52
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure.resourcemanager:azure-resourcemanager-containerservice

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure.resourcemanager:azure-resourcemanager-containerservice

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure.resourcemanager:azure-resourcemanager-containerservice

@XiaofeiCao
Copy link
Contributor

Wait for Weidong's approval.

@weidongxu-microsoft
Copy link
Member

Azure/azure-rest-api-specs#29535 (comment)

AKS is crazy...

@v-hongli1 v-hongli1 merged commit 353eab8 into Azure:main Jul 17, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiaofeiCao XiaofeiCao XiaofeiCao approved these changes

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft approved these changes

@mssfang mssfang Awaiting requested review from mssfang mssfang is a code owner

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles is a code owner

@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft alzimmermsft is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

@haolingdong-msft haolingdong-msft Awaiting requested review from haolingdong-msft haolingdong-msft is a code owner

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner

Assignees
No one assigned
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v-hongli1 @azure-sdk @XiaofeiCao @weidongxu-microsoft