Migrate Identity to azure-json #41523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billwert
requested review from
g2vinay,
joshfree,
a team,
alzimmermsft and
srnagar
as code owners
billwert
requested review from
maorleger,
ahsonkhan,
KarishmaGhiya,
chlowell and
mpodwysocki
|
/check-enforcer evaluate |
|
/check-enforcer evaluate |
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
sdk/identity/azure-identity/src/main/java/com/azure/identity/AuthenticationRecord.java
Outdated
Show resolved
Hide resolved
sdk/identity/azure-identity/src/main/java/com/azure/identity/AuthenticationRecord.java
Show resolved
Hide resolved
...ty/azure-identity/src/main/java/com/azure/identity/implementation/IntelliJCacheAccessor.java
Show resolved
Hide resolved
...zure-identity/src/main/java/com/azure/identity/implementation/VisualStudioCacheAccessor.java
Outdated
Show resolved
Hide resolved
...zure-identity/src/main/java/com/azure/identity/implementation/VisualStudioCacheAccessor.java
Outdated
Show resolved
Hide resolved
...zure-identity/src/main/java/com/azure/identity/implementation/VisualStudioCacheAccessor.java
Outdated
Show resolved
Hide resolved
sdk/serialization/azure-json/src/main/java/com/azure/json/implementation/DefaultJsonReader.java
Outdated
Show resolved
Hide resolved
g2vinay
reviewed
Aug 19, 2024
sdk/identity/azure-identity/src/main/java/com/azure/identity/AuthenticationRecord.java
Outdated
Show resolved
Hide resolved
g2vinay
reviewed
Aug 20, 2024
sdk/identity/azure-identity/src/main/java/com/azure/identity/implementation/MSIToken.java
Outdated
Show resolved
Hide resolved
g2vinay
reviewed
Aug 20, 2024
sdk/identity/azure-identity/src/test/java/com/azure/identity/implementation/MSITokenTests.java
Outdated
Show resolved
Hide resolved
g2vinay
reviewed
Aug 20, 2024
...ity/src/test/java/com/azure/identity/implementation/intellij/IntelliJCacheAccessorTests.java
Show resolved
Hide resolved
billwert
force-pushed
the
identity-azure-json
branch
from
a5cd599
to
c8940b1
Compare
billwert
force-pushed
the
identity-azure-json
branch
from
a0a37bc
to
0d23713
Compare
billwert
force-pushed
the
identity-azure-json
branch
from
0d23713
to
b070835
Compare
|
/azp run azure - identity |
|
No pipelines are associated with this pull request. |
|
/azp run java - identity |
|
Azure Pipelines successfully started running 1 pipeline(s). |
g2vinay
approved these changes
Aug 27, 2024
|
/azp run java - identity |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - identity |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - identity |
|
Azure Pipelines successfully started running 1 pipeline(s). |
alzimmermsft
reviewed
Sep 4, 2024
...zure-identity/src/main/java/com/azure/identity/implementation/VisualStudioCacheAccessor.java
Outdated
Show resolved
Hide resolved
alzimmermsft
reviewed
Sep 4, 2024
sdk/serialization/azure-json/src/main/java/com/azure/json/implementation/DefaultJsonReader.java
Show resolved
Hide resolved
|
/azp run java - identity |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the migration there's a couple other changes in here (that were prompted by these things needing migration, and then me realizing we just don't need them anymore.)
IntelliJCredential. (all the kdbx stuff.)Also includes a fix to azure-json to allow parsing jsonc, which we need for VisualStudioCodeCredential.
Fixes #39799