Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playback and Record for Azure Storage Blob #4971

Merged
merged 42 commits into from
Aug 23, 2019
Merged

Playback and Record for Azure Storage Blob #4971

merged 42 commits into from
Aug 23, 2019

Conversation

alzimmermsft
Copy link
Member

@alzimmermsft alzimmermsft commented Aug 13, 2019 •
edited
Loading

Fixes part of #4713

Note: ~1000 of the files are for playback, those can be ignored

  • Creates a playback and record framework for Azure Storage Blobs (uses Groovy and Spock for unit testing).
  • Adds playback records (will be added after draft review).
  • Updates Azure Core Test to fix edge cases and extend functionality needed by storage tests.
  • Adds NetworkCallException to handle serialization and deserialization of exceptions thrown in the pipeline during playback and record.
  • Adds recording handling for pipeline exceptions.
  • Default serialization of the response body no longer assumes compression, fixes exception thrown by record policy.
  • Adds OffsetDateTime creation in TestResourceNamer.

@alzimmermsft alzimmermsft added Storage Storage Service (Queues, Blobs, Files) Client This issue points to a problem in the data-plane of the library. labels Aug 13, 2019
@alzimmermsft alzimmermsft self-assigned this Aug 13, 2019
JonathanGiles
JonathanGiles reviewed Aug 15, 2019
View reviewed changes
Copy link
Member

@JonathanGiles JonathanGiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a quick review of this PR, nothing stands out to me. I'd say you should continue to get this into final PR form.

@alzimmermsft alzimmermsft marked this pull request as ready for review August 16, 2019 19:52
@alzimmermsft
Copy link
Member Author

/azp run Azure.azure-sdk-for-java-mgmt

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

sima-zhu
sima-zhu reviewed Aug 22, 2019
View reviewed changes
sdk/storage/azure-storage-blob/src/test/java/com/azure/storage/blob/BlobAPITest.groovy Outdated Show resolved Hide resolved
sdk/storage/azure-storage-blob/src/test/java/com/azure/storage/blob/SASTest.groovy Show resolved Hide resolved
sdk/storage/azure-storage-blob/src/test/java/com/azure/storage/blob/BlockBlobAPITest.groovy Outdated Show resolved Hide resolved
sdk/storage/azure-storage-blob/src/test/java/com/azure/storage/blob/BlobOutputStreamTest.groovy Show resolved Hide resolved
sdk/storage/azure-storage-blob/src/test/java/com/azure/storage/blob/BlobAPITest.groovy Show resolved Hide resolved
sdk/storage/azure-storage-blob/src/test/java/com/azure/storage/blob/APISpec.groovy Show resolved Hide resolved
sdk/storage/azure-storage-blob/src/test/java/com/azure/storage/blob/APISpec.groovy Show resolved Hide resolved
sima-zhu
sima-zhu approved these changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@sima-zhu sima-zhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Some of the comments can be addressed later

@alzimmermsft
Copy link
Member Author

/azp run Azure.azure-sdk-for-java-mgmt

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@alzimmermsft alzimmermsft merged commit 437afae into Azure:master Aug 23, 2019
@alzimmermsft alzimmermsft deleted the AzStorage_Blob_PlaybackRecords branch August 23, 2019 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conniey conniey conniey left review comments

@sima-zhu sima-zhu sima-zhu approved these changes

@rickle-msft rickle-msft rickle-msft approved these changes

@jianghaolu jianghaolu Awaiting requested review from jianghaolu

@srnagar srnagar Awaiting requested review from srnagar

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles

@hemanttanwar hemanttanwar Awaiting requested review from hemanttanwar

@jaschrep-msft jaschrep-msft Awaiting requested review from jaschrep-msft

@gapra-msft gapra-msft Awaiting requested review from gapra-msft

@danieljurek danieljurek Awaiting requested review from danieljurek

Assignees

@alzimmermsft alzimmermsft

Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alzimmermsft @conniey @danieljurek @JonathanGiles @rickle-msft @sima-zhu