Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize checkout #4982

Merged
merged 2 commits into from
Aug 14, 2019
Merged

Optimize checkout #4982

merged 2 commits into from
Aug 14, 2019

Conversation

mitchdenny
Copy link
Contributor

This PR introduces explicit checkout steps to the pipeline to optimize the pipelines. Where possible we will eliminate checkout.

@mitchdenny
Copy link
Contributor Author

/azp run java - core

1 similar comment
@mitchdenny
Copy link
Contributor Author

/azp run java - core

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny
Copy link
Contributor Author

/azp run java - core

1 similar comment
@mitchdenny
Copy link
Contributor Author

/azp run java - core

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mitchdenny
Copy link
Contributor Author

/azp run java - core

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JonathanGiles
Copy link
Member

Checkout is much faster across the board now - looks good to me.

@mitchdenny mitchdenny self-assigned this Aug 14, 2019
@JonathanGiles
Copy link
Member

It does appear that all branches are being cloned - is it worth just configuring it to clone master only?

@mitchdenny
Copy link
Contributor Author

Yep - a fair chunk of time is spent on the server building a set of pack files to transfer to the client and I was wondering whether we could optimize by having a greater fetch depth to trick GitHub into reusing pack files but its probably diminishing returns - and the gh-pages thing will have a bigger impact anyway.

@mitchdenny mitchdenny marked this pull request as ready for review August 14, 2019 04:14
@mitchdenny mitchdenny merged commit df74afa into Azure:master Aug 14, 2019
@mitchdenny mitchdenny deleted the optimize-checkout branch August 14, 2019 04:15
@mitchdenny
Copy link
Contributor Author

It does appear that all branches are being cloned - is it worth just configuring it to clone master only?

If I can avoid falling out to a manual clone in a script command I would like to. I want to drop the gh-pages content because I think that will have a much larger impact in the volume of data being brought down. The extra refs for the various branches don't add much weight I don't think.

pull bot referenced this pull request in AzureSDKAutomation/azure-sdk-for-java Aug 14, 2019
* Explicit checkout on build step to test.

* Adding checkout steps to test and analyze.
pull bot pushed a commit to test-repo-billy/azure-sdk-for-java that referenced this pull request Aug 14, 2019
* Explicit checkout on build step to test.

* Adding checkout steps to test and analyze.
pull bot pushed a commit to test-repo-tih/azure-sdk-for-java that referenced this pull request Aug 14, 2019
* Explicit checkout on build step to test.

* Adding checkout steps to test and analyze.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants