Refresh with latest code gen and use spn in tests #559

jianghaolu · 2015-11-20T19:28:25Z

No description provided.

Refresh with latest code gen and use spn in tests

82bdc8b Merge pull request #8 from anuchandy/gradlefix d56d5e0 Merge commit 'ae4c3ba611076c6d1a2e6fedb6616d5c3b0fdb3d' into exp 2a37759 Merge pull request #7 from jianghaolu/restclient eee9f2a Merge commit '9513e6ec31afd0bc1418f07feb3ff8202041f608' into javavnext 73b3ae3 Merge pull request #984 from jianghaolu/builder 4cfb906 Merge pull request #958 from jianghaolu/javartremoval 168b99e Address checkstyle errors fa1ac24 Support base URL replace using Interceptor (Retrofit 2.0) b6592da Removing unused VersionInfo task from runtime gradle files e5cbc40 Fixing few compilation errors, removing gitrevision artifacts from the POM and Gradle files fcfb315 Add RestClient 75e08f0 Move .build() from collection calls to initialize() 0e5da7e Merge commit '7162a39ae50d95c1a20cbb521282752955ed722a' as 'ClientRuntimes/Java' 88f2de6 Remove submodule a6eef1f Merge pull request #5 from Azure/jianghaolu-patch-1 2c03d76 Update README 7c87e37 Use latest javavnext runtime 78359ef Merge pull request #4 from jianghaolu/javavnext 2ad3332 Use javavnext branch consistently f1d7b46 [Azure/autorest#957] Merge pull request #3 from jianghaolu/javavnext 8979cac Use relative path in .gitmodules 1c70756 Add Java runtimes as a submodule e8eb547 Remove Java/ in ClientRuntimes 0e14ae1 Merge pull request #955 from jianghaolu/javavnext 91d73c6 Python Streaming Test Fix (#953) f674f3c Add fluent to pageimpl 7082f8e Use String for OData 42a3277 Use String for OData 9a03f63 Fix paged list to use hasNextPage() for hasNext() 88c8aad Fix paged list to use hasNextPage() for hasNext() 77a7eb1 Extend functionality for paged lists 8b1aeed Extend functionality for paged lists 3d236fe Regenerate after merge 07bda32 Address code analysis errors 8bd5afd Rename method group impl to inner 6333912 Rename only top level parameters & responses to Inner 51f17c3 Move into implementation.api subpackage 175a66e Rename models to end with impl b877cbf Seperate type name generation and client name generation cd01cf8 Remove interfaces for method groups and service clients b81317e Remove get prefix on model property getters c0b92a9 Remove get prefix on model property getters 5573dc8 Move impl classes to implementation subpackage b2c127f Rename AutoRestException to RestException c009c93 Rename AutoRestException to RestException 4c181b2 Address code analysis 3a885ff Shorten operations names to simple plurals b7de51d Rename method groups without Operations suffix 29dc46d Python Bug Fixes (#928) 14b4e56 Merge pull request #951 from jianghaolu/master 0592481 Okio 1.7.0 cd746ab Okio 1.7.0 296bb25 Correct bug link re: multi (#939) 56a20fa Merge pull request #917 from AzCiS/master 0e2d13a Update swagger-extensions.md 016cef6 Enhancement to "x-ms-parameterized-host" extension (#929) b73c784 Fix: https://github.com/Azure/autorest/issues/923 ab93a4a Merge pull request #927 from jianghaolu/master 7c26136 Android license split into 2 3106fb8 Automatically detect MSBuild tools version in Windows platform 1f44695 msrestazure 0.2.1 12e9590 Python model kwargs removal 5915c65 removing logic to require('moment') from model classes 97545e3 fixes issue #890 965e722 Adding a method in the AzureClientExtensions to handle the PutOrPatch async calls with 202 responses which have no body and no specific headers 6142fb7 csv array in path #900 afd67f1 added test for flattening generic properties of a model to be flattened 70fe5ce Merge pull request #908 from jianghaolu/master bb0d05b Merge pull request #908 from jianghaolu/master 4c4604f Merge pull request #904 from amarzavery/enum 6158597 Merge pull request #891 from dtretyakov/master e97388a Merge pull request #891 from dtretyakov/master de0232b Azure/azure-sdk-for-java#622: Shutdown ADAL auth executors 73e516c Azure/azure-sdk-for-java#622: Shutdown ADAL auth executors 360619a Merge pull request #901 from jianghaolu/optional 12f4d00 base64Url support for node.js and inclusion of composed properties while flattening. e70afa7 Merge pull request #902 from begoldsm/master 1ec7248 Fix test breaks. ed2d74f Merge branch 'master' of https://github.com/Azure/autorest dd478b8 Add missing condition in Azure template 4ffe90d Re-gen and address code analysis errors 107c6c9 Add null checks to optional flattened wire parameters e941db6 bring variable declarations back 89a40ba Merge pull request #878 from tbombach/base64url 8ab297f Fixing merge conflict for renaming base64url type in Java 6daa5ef Remove useless nulls when input is optional 15b977f Merge remote-tracking branch 'Azure/master' into base64url 7ff9d25 Merge branch 'master' of github.com:Azure/AutoRest 36b2ce5 Merge pull request #898 from jianghaolu/nocodegenheader ab982ac Escape data strings for odata queries. c0d3614 Merge remote-tracking branch 'Azure/master' into base64url 4163396 Fix head response with headers 3b3c788 Fix head response with headers c174932 update paging extension documentation. b37fc5e Add option for license header w/o codgen info 3992b7e Merge pull request #893 from jianghaolu/defaultvalue 1aab052 Updating the client runtime package version 24a74a0 Fix type normalization [stackoverflow in network] 5732fa5 Update swagger-extensions.md d468bfc Fix parameter conversion bf5456a #889: Fix credentials setup in service client b5163a9 Adding test case for accepting a base64url encoded string in the path eb7cf92 Merge pull request #892 from annatisch/PythonPollingBuxFix f25e20c Merge pull request #894 from lmazuel/msrest020-msrestazure020 bef80e6 msrest-msrestazure 0.2.0 d0a6e6f Add default value support for optional parameters 725c1f6 Merge pull request #880 from jianghaolu/refactoring ecb8a4c Remove unnecessary serializations for some primary types 32a8ff1 Edited changes e8b8f7d LRO polling fix for status enums 6b0d795 Fix status code validation in java client 3b59c0f Fix status code validation in java client f4a4543 Merge pull request #887 from Azure/devigned-patch-1 78c499d Update swagger-extensions.json f32e739 fix test compilation errors b8cfd81 Add parameter conversion 9b1bb48 Fix parameter invocation 754785b Fix some imports de7c6e9 Add property model and fix type conversion 52beb9d Merge pull request #879 from lmazuel/enum_as_int c1bcfb9 Merge pull request #883 from amarzavery/enum 3b3b14e pusblished 1.12.0 version of ms-rest and ms-rest-azure d824238 Address code analysis errors 83c8291 Move all string templates to ResponseModel 05a7ebc Let Response model handle client type string 5dfaf9b Explicit comment as a temp workaround 1539446 Move OperationResponseType to ResponseModel f35d545 Move folder 3c7cc6c Fix type token type 406a741 Some renamings and cleanups 671703c Add JavaResponse ac318cf Allows to parse integer as enum valid values b48d906 Let JavaParameter handle invoke 3e4df71 Adding tests to ensure base64url format works in a dictionary and an array 8466b63 Generate import list from JavaParameter b9e1bbb Merge pull request #873 from annatisch/AzureOperationChanges b3fd265 Merge pull request #877 from matthchr/feature/optional-body-fixes 285b432 Adding the code coverage exception for base64url format for all languages until they implement the serialization for the type b74a654 Updating nodejs coverage test to exclude base64url tests that haven't yet been implemented in the language fe85341 Add JavaParameter 53693bc Move primary type normalization to JavaPrimaryType baefd44 Fix nodejs server to correctly check optional body f900898 Merge remote-tracking branch 'refs/remotes/Azure/master' into base64url 6ae67cc Adding a test for handling a null value when it is expected to be base64url encoded 9337878 Updating unit tests for swagger generation for base64url format d6f7539 Making the code namers for each language treat base64url encoding as string if they don't handle encoding/decoding daf75d9 Adding tests for C# for base64url 0faa880 Merge pull request #872 from jianghaolu/large f375b91 Merge pull request #872 from jianghaolu/large 53c6ca7 Merge pull request #874 from jianghaolu/typefix e39b8c0 Fix stream type in input mappings f92ffb3 Fix stream type in input mappings e108283 Fix DateTimeRfc in parameter mappings 74c3a75 Update travis node version to 4 a26728c Added accept header 1aeb717 Reformatted docstring 081e7f6 Merge pull request #866 from jianghaolu/rfc1123 f2319c8 Merge pull request #865 from lmazuel/msrest013-msrestazure012 a8419ee more regression fix in azure codegen 8381aa9 Fix regression in azure codegen 99e6538 #742 Hide RFC1123 on parameters 10ba216 #742 Hide RFC1123 on parameters 8a326f2 Clean up method model and add wrapping to models 812528f Address code analysis error 20649f3 #742: Hide DateTimeRfc1123 c5cb522 #742: Hide DateTimeRfc1123 ba3ca3d Remove entry from coverage reporter cd818c8 commons-io was for debugging 50561ec commons-io was for debugging 22d1d5a Add download streaming support 3522036 Add download streaming support b321647 Merge pull request #870 from jianghaolu/stream 93075ab Remove unused imports 67bb5a3 Stream support: change back to byte[] 48d268a Updating C# Client runtime to handle the base64url format and add the associated Json serializer for properties of that format 95dbe37 Merge pull request #869 from matthchr/feature/stream-fix 34f7a98 Fix out of memory exception streaming large streams 8250693 Merge pull request #868 from amarzavery/enum d67b08f Adding primary type for base64url format 7f3bb55 Updated tests and regenerated 9e8d436 Merge branch 'master' of github.com:Azure/autorest into enum 619ce59 Changed raw LROs in Python generator b6ef4b7 [node.js] Add responseBody as one of the parameters in the callback while processing stream response e8ad92f Removed raw from Azure LRO b85040d Merge pull request #851 from jianghaolu/lazy 6aed2ce Merge pull request #851 from jianghaolu/lazy f24b0b6 Merge pull request #864 from jianghaolu/stream 1898038 Reset server change 58648e9 msrest 0.1.3 - msrestazure 0.1.2 f72eb22 Fix NPE d47a7df Fix NPE 43ae403 Remove system.err e5cdce2 Remove system.err 1eca766 Change file upload type to java.io.File 8ef1fc6 Change file upload type to java.io.File 3301f3a Fix close() in retry handler cfd8472 Fix close() in retry handler 524b8c4 add close() to response bodies f4adb86 add close() to response bodies 815bd1e Manually change byte[] to File e21f437 Manually change byte[] to File 8238efd Merge branch 'master' of github.com:Azure/AutoRest into lazy cef40a4 Merge pull request #859 from jianghaolu/stream 0dfd694 Merge pull request #856 from lmazuel/master 8ae1e78 Merge pull request #861 from lmazuel/generic_deserialization ea0f751 Add missing javadoc 2b47ec9 Add missing javadoc ec5a338 Re-generate 510be3f Add more laziness to PagedList 3ab0c6a Add more laziness to PagedList 3b9f993 Fix PythonSDK bug 544 17485d7 Reset unnecessary changes bebc9e8 Fix incorrect content type fe83a2e Merge pull request #858 from NiklasGustafsson/master 7031098 Merge pull request #860 from amarzavery/enum f8a4da6 Merge branch 'enum' of github.com:amarzavery/AutoRest into enum 542d576 Merge branch 'master' of github.com:Azure/autorest into enum 71d5bd2 Fix python test c6153ea Add missing multipart declarations ca2ac16 Merge branch 'master' of github.com:Azure/autorest into enum 07a49c1 fixes #782 for node.js and JSON.stringify of null value during serialization 7b7b334 Remove invalid formdata parameter b457065 Add support for file uploading 77408ae 1) Implementing synchronous and HTTP-response-free operation methods for Ruby. This will lead to silent breaking changes in any generated libraries as the type returned will have changed for all non-LRO operations. 2) Modified tests to use the '_async' methods, except for LRO tests. 3) Added 'x-ms-client-name' to Swagger extensions schema. e2c8d09 Merge pull request #852 from NiklasGustafsson/master 45733bd Wait() must raises Exception if query failed 227bea7 Fix iterator and add tests for PagedList b439852 Fix iterator and add tests for PagedList 7932d97 published 1.11.0 version of nodejs runtime 1189e2d Merge pull request #853 from yaxia/master c78174c Merge branch 'master' of https://github.com/NiklasGustafsson/autorest 8254303 Merge pull request #11 from NiklasGustafsson/merged baa5088 Fixed tests that depended on constant parameters not being supported. 4cc03f7 Merge pull request #10 from NiklasGustafsson/master 2b9f18a Added synchronous method versions for each operation. 943e073 Fix error message in serializer c0c49bc Add lazy behavior in get() fb0db57 Add lazy behavior in get() 30d986f Add Javadoc and cleanup a48a647 Add Javadoc and cleanup 9d24b97 Merge pull request #9 from Azure/master 2fed13f Fixed byte-array-to-string conversion logic. 5fa2ff1 Merge pull request #850 from annatisch/optional_param 6aa18d7 Adjusted Ruby tests for the new constant parameter logic. 61447f3 A working solution for lazy initiliazed paging 724ea5a A working solution for lazy initiliazed paging c5ab686 Merge branch 'master' of https://github.com/NiklasGustafsson/autorest 3beff93 Ruby pays attention to constancy of parameters. cb48887 Merge pull request #8 from Azure/master abbaf81 Regenerated Python tests afd0528 Fixed optional body parameter bug 13323c2 Merge remote-tracking branch 'refs/remotes/Azure/master' 3a88ef7 Merge pull request #848 from amarzavery/enum bf70f23 exported USGov envt. 23ac4ba added support for default Errors for stream response in node.js b5fd67a updated nodejs enum check 749e8e7 Fixed issue #847 for C# and node.js 68ea21c Merge pull request #846 from annatisch/SwaggerModelerBugFix b96e980 Bug fix 2515e68 Merge remote-tracking branch 'refs/remotes/Azure/master' into docstring_formatting 3db1c62 Merge pull request #832 from devigned/fix/unit_const_rb 9c9e7f6 generate require module_definition when namespace is present e67a8f8 Merge pull request #841 from begoldsm/master a12d73e Merge pull request #844 from jianghaolu/const 5667e2d Add missing declarations in interfaces 86f25b8 Add overloads without optional parameters 3546e52 Remove composite lazy initialization for now 7e7a4fe Fix tests in Azure as well e425151 Support constant values 10c8f40 Merge pull request #842 from lmazuel/master 8c9c8d3 Release msrest 0.1.2 bbe5f85 Remove accidental empty line. 8d5a0fa Merge pull request #840 from annatisch/docstring_formatting 58292d8 Make code analysis happy. d4bccbd Safer parse. 3f07b14 Change to the Azure code generator to pass settings fd1492c More C# cleanups e60a95e Merge pull request #829 from jianghaolu/baseresource f865082 C# code analysis fixes af63d63 Merge remote-tracking branch 'refs/remotes/Azure/master' into docstring_formatting 151f80c formatting fix 40a6d12 Merge pull request #839 from Azure/devigned-patch-1 d577042 Docstring change cleanups bb35608 #838 add document relative $ref path 6a2033e Regenerated Python tests 687c451 Merge pull request #7 from Azure/master 99908b7 Merge pull request #830 from lmazuel/msrestdoc 8f3f697 Resources don't extend com.microsoft.azure.Resource afd7864 More docstring touchups cc87632 Address code analysis errors 7bc5b64 Model classes import the runtime Resource & SubResource 1eb3988 Use 1.0.0-SNAPSHOT for new dev phase a8dddd8 Use 1.0.0-SNAPSHOT for new dev phase f681c43 Unify resources in runtime 66e0bf7 Unify resources in runtime 14f9234 Merge remote-tracking branch 'refs/remotes/Azure/master' into docstring_formatting d66ba97 Improved sphinx references in docstrings dab0418 Do not flask8 the doc configuration 750abb8 add msrest to mrestazure requirements beecc7a Basic doc 645f383 Merge pull request #828 from amarzavery/enum bc5ef85 Adding test generation changes e3aa58f Merge branch 'master' of github.com:Azure/autorest into enum 9fb8544 optional single enum will not be treated as a constant 5d88aaf Merge pull request #827 from begoldsm/master ab14e38 Merge pull request #818 from devigned/fix/resource-serialization 5467ffb Adding examples of x-ms-parameterized-host to documentation 1d029fa add suppressions 89c3525 Merge pull request #6 from Azure/master 305c958 Merge pull request #817 from jhancock93/partialinit2 22f4c66 Merge pull request #810 from brodyberg/xunitversion 056297d Merge pull request #826 from annatisch/urllib_fix 9370ea5 Merge pull request #801 from NiklasGustafsson/master 2b6b6a2 Fixed missing test b9b93fc Fix for urllib bug d34ebf6 resource and sub-resource serialization fix for ruby 8b4c10a Update cli.md b8117a0 Merge pull request #5 from Azure/master 0e78508 Fix the client-name implementation. Added tests. 5a68c4d Merge pull request #821 from jianghaolu/moredev 523d79e Merge pull request #821 from jianghaolu/moredev edf5caf parameter.getClass() -> parameterType c6b8393 parameter.getClass() -> parameterType a2b7aa0 Fix recursive validation 59d204e Fix recursive validation 04c19cd Merge pull request #749 from jhancock93/nullresponse 8bca5cb Fixed reference in MD file. 2727c44 Merge pull request #4 from Azure/master a015249 CSharp: Add partial method CustomInitialize to client initialization f90395d Merge pull request #814 from devigned/fix/version-dependency 1149348 fix version dependency for ms_rest beb9f19 Merge pull request #813 from devigned/chore/bump-versions ee4633b bump rb gem versions to 0.2.1 c3c4501 Merge pull request #812 from devigned/bug/path-template d4eb3d4 check path templates and add user agent 46dc5c9 add Running to long running states 76aec4f Add Uuid to NodeJs dictionary to avoid analysis warning e96ada3 Fix warning about xunit build version 6e2c21c Merge remote-tracking branch 'upstream/master' d236a3f Change docs to be more clear about build flavor 492b2b8 Fixes problem with null response content in CSharp generator for non-documented codes 391a2e0 Added documentation for x-ms-client-name. 5de974d Merge pull request #807 from amarzavery/release-0.15.0 20b7f10 Merge pull request #808 from lmazuel/revert-799-malnick/fix_setup 0a66583 Revert "Setup.py references a file that does not exist" 2faa42e Restructured x-ms-client-name support 09365a1 Merge pull request #800 from lmazuel/master ac8a5a5 Merge pull request #799 from malnick/malnick/fix_setup f6c2f7c Merge pull request #803 from jianghaolu/moredev bbe6ec5 Merge pull request #803 from jianghaolu/moredev 9bc89f1 Update building-code.md 07c0a66 Update README.md da5e7ea bumped autorest version c46de70 Update ChangeLog.md 688c538 Merge pull request #804 from Azure/release-0.15.0 93862a8 Update building-code.md 8dcfa4b Update ChangeLog.md 4456e9f Update building-code.md 896d0d2 Update ChangeLog.md 5ea42fd Update ChangeLog.md 5b68453 ChangeLog 0.1.1 1e66161 Fix MANIFEST issue again 667ddc9 Merge pull request #798 from Azure/master 231e596 Correcting comments and description in Swagger test file. 75f320b Setup.py references a file that does not exist 86aefd6 Merge branch 'Azure-master' 7e59f37 Manual merge 939a90d Implemented ClientName on model properties, added more tests. eea487d Merge pull request #795 from devigned/chore/gem-version a857359 Merge pull request #797 from stankovski/escapedot 2232196 Merge pull request #796 from stankovski/master fdf5ea4 escape dots in serialized name if present in the property name a7fa96a Merge pull request #793 from annatisch/PythonLogging 3b7f02e Fixed fxcop issue 86daf21 provide the gem-version information when generating 73a65fa Merge pull request #784 from jhancock93/uuid2 26a89bd Add Assert.fail() in new java test f2988f4 Merge pull request #773 from jianghaolu/master bd1a7e4 Fix credentials test ac2175d Fix credentials test a02d30c Merge pull request #794 from stankovski/release-0.15.0 d85fe59 Merge pull request #1 from amarzavery/uuid 714be24 Merge branch 'master' of https://github.com/Azure/AutoRest into release-0.15.0 5db8a35 Merge pull request #791 from stankovski/master a376290 Added test fixes for logging changes cdd9616 Fixed Python constants tests b54f623 Merge remote-tracking branch 'refs/remotes/lmazuel/master' into PythonLogging 2b0fb7e Merge remote-tracking branch 'refs/remotes/Azure/master' 3f50788 Merge remote-tracking branch 'refs/remotes/Azure/master' efd505f New simple log system 309b3a2 Improved NodeJS support for uuid 115c762 Merge branch 'master' of https://github.com/Azure/AutoRest 98e13ff Merge pull request #790 from xingwu1/arg_defaults be03738 Added support for ClientName on properties. Added unit tests for client properties and parameters. bcab638 Regenerated code and fixed tests 4c97607 ServiceClient null check 29e57b8 Add more info to revision file d031031 Add more info to revision file 7b3a479 Added cultureinfo 3405154 Add gradle task to generate git revision 8d37635 Add gradle task to generate git revision f21af20 Updated readme 0910a29 Merge pull request #792 from devigned/bug/rb-lros 0735c94 fix long running operations in ruby ebda362 Change constant behavior to not initialize parent of child is a constant #782 c28a3cf Regenerated tests 04b87c6 Updated test cases c73b362 Added model **kwargs 0101efd Merge remote-tracking branch 'refs/remotes/Azure/master' into arg_defaults 8735578 Merge pull request #788 from devigned/feature/rb-cleaner-code 75a8271 Added validationerror to generated exceptions 607598b Replaced ValueError with ValidationError 52170aa Updated runtime version history 021f448 regen samples 9af9db9 Replaced Python None with constant 43caf6a move skipUrlEncoding to generic ruby f6edb1b Regenerated java fixtures to fix merge issue 045a370 cleaner ms-rest lib and code generation 466c7b7 Model uuid format with Guid in CSharp, UUID in Java 71deef2 Restructured body validation d24ff9a Restructured generated validation 25554ee Started reworking model validation 6f8539e Cleaned up ValidationError d761a79 Merge pull request #780 from annatisch/test-reformat ebed0bb Regenerated d3f3abd Merge pull request #779 from stankovski/release-0.15.0 15899df custom uri test reformat d307ddc Merge remote-tracking branch 'refs/remotes/Azure/master' 8ee8d12 Merge branch 'master' of https://github.com/Azure/AutoRest into release-0.15.0 46c5ba0 Merge pull request #778 from amarzavery/readonly a5f284e update f410906 Merge branch 'readonly' of github.com:amarzavery/AutoRest into readonly bcd6b2e updated readme for ms-rest-azure 2dc5805 updated readme for ms-rest-azure 8cbc5d3 updated README for ms-rest 1bb5892 Fix for #633 - C# generator emits some empty classes 81c1f31 append query parameetrs correctly for partial nextLink 5a2a726 Merge branch 'release-0.15.0' of github.com:Azure/autorest into readonly 567c771 nodejs release versioning 53ff42d Cleaned up param validation 6d6492f Merge branch 'master' of https://github.com/Azure/AutoRest into release-0.15.0 9a37902 Merge pull request #777 from amarzavery/readonly ff32fbf small fix 9171816 generated code a13e603 Merge branch 'master' of github.com:Azure/autorest into readonly 240bd7e check for '?' in the url and append query parameters accordingly a585257 Regenerated tests 854ea71 Review feedback f7f9103 review feedback 39bc0e8 Implemented request validation 9062b1f Support x-ms-client-name for parameters. 3734c93 Update building-code.md 03d3782 Update building-code.md 89fa58f Merge pull request #772 from stankovski/master 90e4160 Updated documentation 51ca2f0 Update README.md df2ddf1 Merge pull request #765 from stankovski/release-0.15.0 6b40d06 Merge pull request #771 from stankovski/master 541631d Updated swagger extensions schema 705495a Merge pull request #2 from Azure/master 81ccae9 Fix flattening and bump up to 1.0.0-beta1 ba87677 Fix flattening and bump up to 1.0.0-beta1 77613e4 Merge pull request #766 from stankovski/master 4fd8504 Fix for issue #762 - composite Swagger client compilation fails due to a lower case parameter name 2904f93 Fix for issue #762 - composite Swagger client compilation fails due to a lower case parameter name c166d99 Added release notes for 0.15.0 release d5f1998 Merge pull request #764 from devigned/chore/rb-versions d25e28a Merge pull request #763 from begoldsm/master 762e518 Merge pull request #720 from stankovski/flattening 6a1dd49 update the gem dependencies b350e49 bump versions for rb client libs 23bb817 Merge pull request #7 from jianghaolu/flattening 32af735 Fix interface import when there is parameter mapping 05227ba Enable the Azure version of the tests as well. 0f6d1a1 Merge pull request #6 from jianghaolu/flattening eebe17c Fix input mappings in Java d125d7a Moved ruby resource flattening tests under generic code gen 0fccf94 Merge branch 'flattening' of https://github.com/stankovski/AutoRest into flattening 9fa5f9f Merge pull request #5 from jianghaolu/flattening 0d1a5f5 Merge pull request #5 from jianghaolu/flattening bd8413e Merge pull request #761 from lmazuel/master 3001234 Merge branch 'master' of https://github.com/Azure/autorest ffb25e4 Add simple support for const properties in Java 10e61fd Updated Ruby based on the latest code gen changes b16c9c8 Minor change to the pyproj to include the customBaseUri tests 80e868b Merge branch 'master' of https://github.com/Azure/AutoRest into flattening 064dbb5 Merge pull request #758 from devigned/bug/ruby-val-deserial ab11f34 Regenerated tests 6133292 Add 2 more tests for Java aea3ce6 Add 2 more tests for Java 81b6118 Fixed potential arg ordering bug 3e3d9a2 Merge pull request #4 from annatisch/py-flattening 8bcb13e Added validation tests b404113 Extended defaults to required parameters b014bf3 Fixed missing Error import statement 3c0682e Merge pull request #1 from Azure/master dd35d89 Merge remote-tracking branch 'refs/remotes/stankovski/flattening' into py-flattening 2b74f27 Skipped tests pending constant support e6f78f0 Precompiled split regex 342b0c8 msrest 0.0.3 - msrestazure 0.0.2 160e1b7 Merge branch 'master' of https://github.com/Azure/AutoRest into flattening a3276af Merge pull request #760 from stankovski/docker fa97b10 add supressions 27cf3ec Added dockerfile for tool execution 484d00b Merge pull request #757 from jianghaolu/master f37d2bb fix code analysis issues 83dfb83 Fixed flattened serialization a231a2f Added flattening tests and regenerated 4a2492f Fixed bug in python generator 34fec02 Corrected and regenerated Azure Python 2167735 switch to ERB url_encoding rather than URI.escape c4c5b70 refacotr azure method template model for params, path and urls 03b8f29 the uri test for validity would fail on the URI.parse 3345133 odata is case sensitive -- correct $orderBy 021db0c refactor faraday usage for url and query params and url_prefix 763e83d improve variable naming and newline char 54f9391 better error messages and less reliance on full urls (backcompat) 945b4d7 brought back HttpOperationResponse as it is required in LRO 85d9361 removed unnecessary dependencies 2bcce1f Merge branch 'flattening' of github.com:stankovski/AutoRest into readonly ce89638 Added missing date serialization tests 40a4e5c Merge pull request #755 from stankovski/master 287cb90 Merge branch 'master' of https://github.com/Azure/AutoRest f49dde1 Merge pull request #756 from devigned/feature/packaging 1d9d0dd Fixed tests and fxcop issues 146ddf5 Add IllegalArgumentException throws on Async methods 0deeea8 Merge pull request #2 from amarzavery/readonly 6409d38 Remove constructors w/o credentials when required dffd229 add in version and package name to ruby generator a2c7240 Regenerate from master branch 35d7abe resolved conflicts and made test modifications 5abbdf5 Sorted parameters and generators in help 0ece56c Merge branch 'flattening' of https://github.com/stankovski/AutoRest into readonly 1cfd7b0 Merge branch 'flattening' of https://github.com/stankovski/AutoRest into readonly 82a8026 All Languages: provide a listing of code generators with their custom settings #753 21516d0 Merge branch 'master' of github.com:Azure/autorest into readonly a657654 fix jshint issues and a failing serialization scenario 13feba3 Merge pull request #3 from jianghaolu/flattening 8778c0e Support escaped dots in deserializer 3d3f0fe Support escaped dots in deserializer c06ced5 Unify initializations of JacksonMapperAdapter 0746708 Unify initializations of JacksonMapperAdapter a1ba79e Move flattening serializer to generic runtime 64012f1 Move flattening serializer to generic runtime ed2a757 Merge pull request #754 from stankovski/master 3df3eb5 Undo dotnet change e94fbd7 Added auto-generated samples 12acbbb readonly property supported in nodejs 558952a Merge pull request #750 from devigned/bug/ruby-enums b838ac0 updated msrest readme 58eab5f warn on enum deserialization in ruby 70e8f88 Updated readme a26bba1 Bumped versions ca85e0e Merge pull request #732 from lmazuel/master 105261e Merge pull request #748 from stankovski/master 4f66d24 Merge branch 'flattening' of https://github.com/stankovski/AutoRest into readonly 39469cf Merge branch 'master' of github.com:Azure/autorest into rf 41f9979 Merge pull request #737 from jianghaolu/lrobegin 5e5e74b Merge pull request #737 from jianghaolu/lrobegin 1705578 Temporarily removed Java test code - will add back once #720 PR is merged 0b753cb Merge pull request #724 from devigned/bug/portable-post303 d640fe5 Fixed duplicate local variables when flattening parameters #730 0430d22 Move flattening deserializer to generic runtime 49c4ca2 Move flattening deserializer to generic runtime c3892f3 Merge remote-tracking branch 'refs/remotes/Azure/master' into arg_defaults 16bfd31 Regenerated tests ddcce32 Added version generator to proj file a72a560 Merge pull request #740 from stankovski/master d7feabe Fixed serialization tests da706f1 Generate separate version file 07abc73 Paging inherits from iterable 1b3450e Command line help is not properly formatted when built in mono #738 fd7c08f Address code analysis errors b40b887 Unify method interface generation 9c58d07 Paging operations return updated ServiceCall 22535b3 Paging operations return updated ServiceCall 986ebd9 Moved Java tests 83a0fcf Added tests to C# for model flattening de8a280 fixed nodejs breaking tests 83782d2 nodejs model flattening works 5303175 Add Service call to allow LRO cancellation 7feab06 Add Service call to allow LRO cancellation 2743be2 Move Retrofit service to impls d0bca99 Treat odata filters as strings 49f6ba8 Add begin methods to LRO 381174b Merge pull request #725 from BurtBiel/AuthVerifySetting ca90bb9 Merge branch 'flattening' of https://github.com/stankovski/AutoRest into rf accf2bf Merge pull request #728 from haocs/master 102b8c8 model flattening for node.js partially done cbe9129 resolve merge conflict 629e0b2 resolve merge conflict d342d0c regenerated bc050cc Merge pull request #727 from jianghaolu/objectserialize 8fcb754 Merge pull request #727 from jianghaolu/objectserialize 26ede53 Issue #718 - Manifest must be in capital letters e073080 fix typo 468599c Validate all complex parameters 07a5780 regenerated after moving resource flattening tests to generic and renaming it to model flattening 48d6763 Added fxcop suppression for AddParameterGroups d3b4aab Fixed style check errors ddaa7e8 Implemented flattening in Java 09d4c88 Merge pull request #2 from annatisch/python_custom_base_uri e6020d5 Skip putComplexReadOnlyPropertyValid test for node b506747 Merge pull request #726 from amarzavery/rf 5f83d53 Adding 2 more calls to check verify setting 22870b2 Update unit test to check verify setting is propogated 9c47e05 Bumped msrestaszure version 41c60a6 Changed version updates f7694b4 Added readonly property tests for C# e90ed76 Updated nodejs and python to escape backslash and other special characters bcab81d Added documentation c824b81 Added 'putComplexReadOnlyPropertyValid' coverage 3cab694 Added support for method argument flattening cac2cca Added tests for ReadOnlyPropertyObject b67c097 Added annotation in model 7761aa7 Added test converage b00475e Added tests for ReadOnlyPropertyObject c5bade4 Bump up jackson to 2.7.1 e80ed8e Bump up jackson to 2.7.1 7d256fe Merge pull request #723 from stankovski/master dd835f9 Merge branch 'master' of github.com:Azure/autorest into rf fb0797e support for colliding x-ms-discriminator-value polymorphic discriminator in node.js b31a1f5 Pass through the connection verify setting for fetching the auth token 61d218b comment out the portable post 303 test as it causes express to hang 62397f3 Regenerated tests a4fddb1 Updated generator to use defaults and parent attr 2604337 Removed class hierarchy scanning for Model 3ba2739 Updated generator runtime reference 577c812 Cleaned up some tests db22ecb Removed superfluous changes e8db746 Merge remote-tracking branch 'refs/remotes/begoldsm/master' into python_custom_base_uri 4db1e0a bumped msrest version 025b69a Silly python 2.x url formatting 7d758c8 Fixed runtime backwards compatibility fd48d32 Merge branch 'master' of https://github.com/Azure/AutoRest into flattening daaf8b6 Added dependency on GetZip target dae0e3d Changed sequence of extension execution 4334618 Regenerated python tests 91876ba Updated generator to use new format_url 00f9f6b Exposed client.format_url in runtime 96fef13 Removed dead code 0e50ca9 Added build target to produce zip package f5649b4 Merge pull request #709 from begoldsm/master cb9f6f6 Removed 7zip folder from repo d1d4b4e Ensuring ProcessParameterizedHost only happens once. 712f962 Addressed fxcop complexity issue 357de2d Updated C# code gen to use TransformationJsonConverter 00ded52 Don't duplicate calls for Azure C# a91940c fix path. 3b8b92f Regenerate tests after sync. fa2f856 Update defining-clients-swagger.md d59ec59 Merge branch 'master' of https://github.com/Azure/autorest f66bfe9 Merge branch 'master' of https://github.com/Azure/autorest f6f22fd Added support for recursion in flattening bc72b0e remove bad file. 5f26f77 Remove some unused files and exceptions 17694e0 Remove some unused files and exceptions 309e46c Rename the location of the Azure tests 83e9a01 Merge pull request #716 from stankovski/master e5f32b3 Adding Python and Java code generators dca45a4 Added tests and code for flattening in generic extensions 98003a6 Initial fixes and tests for python c401e83 Merge pull request #715 from stankovski/master 6782515 Fixing DNX build script to honor configuration settings #714 ee6e052 Merge pull request #710 from xingwu1/generated_model_args 8c103fb Merge pull request #712 from amarzavery/rf 30b5cc7 fxcop warnings fixed b8f9e7e added this check in the normalizeclient model as that is the right place e04e7cb Fixed bug in error logging 45f352e wrap properties with single quotes if they have a dot in their name 5b3503a Merge pull request #708 from jianghaolu/packageinfofix 12cbd52 Merge pull request #711 from stankovski/flattening 090a69c Changed dot to bracket based select to support escaped dots in the path cb6bb43 Change the property name to make it more reasonable. 17e0ff5 Updated tests and fixed fxcop issues b57bed3 Fix code analyze warning. fb4b816 Runtime review cleanups 371c914 AAD updates for retrieving cached tokens 9f12754 Generator code review touch-ups e5fa164 Added AzureModelTemplate d566f50 Made flattened model serialization optional 5b7fd67 Updated runtime model deserialization fc2d764 Models take explicit args/kwargs df05744 Generate credentials.py/exceptions.py to reduce the importing to _init_.py 957f334 Fixed syncDependencies 537655f Updates based on design review 06cbccb Update swagger-extensions.md e527e0c Added generic JSON flattening converter 18d641b Switching to the right exception type after some sync changes. 5d1bb8e extra assignment, thanks travisCI! adb2951 missed json reference. 8fd69d5 try using generic parametersList c3efd7a missing slash! ahhh! b2641a0 testing to make sure the path in the id doesn't matter 7989dd5 updates for the x-ms-parameterized-host extension 0d1e6ab Merge pull request #1 from jianghaolu/bengmaster 46ed8e3 Support parameterized hosts in Java 14ecdd3 Support parameterized hosts in Java fde3889 Fix package names in package info files 387d099 Fix package names in package info files e6cfa1e regenerate all the expected test code. 5163dc0 bad merge, fixed the cshtml db8fa4d Merge branch 'master' of https://github.com/Azure/autorest 9cd892a Merge pull request #706 from jianghaolu/batchfix f1ed5a7 Fix method group naming for reserved names c583806 Remove imports for types serialized into String 6b5d032 Fix header responses & unmatched parameter mapping b6b91ff Merge pull request #704 from matthchr/master a54c688 Updates to include tests in Azure classes as well 045497b Merge pull request #705 from amarzavery/rf d9702fb Adding CompositeSwagger Modeler to CodeGenerator.sln eabc066 Merge branch 'master' of https://github.com/Azure/autorest b64fb51 Regenerate expected for tests c633856 Add missing comments to C# code 1f0167c Merge pull request #702 from jianghaolu/upgraderetrofit d370403 Merge pull request #702 from jianghaolu/upgraderetrofit 26a58b7 Merge pull request #701 from stankovski/nullable 8cf4124 Added compositeSwagger.dll to the nuspec d470dbc Removed dead code 9f2cc64 Merge pull request #703 from amarzavery/rf 58a2343 Adding CompositeSwagger Modeler definition to AutorestRelease.json b10d9b7 Fix interceptors to work with client builder 40d24bc Fix interceptors to work with client builder 0726b3f Merge branch 'master' of https://github.com/Azure/AutoRest into nullable d352f41 Added CanBeNull() method 425c93c Updates to include the general extensions for java. 29a2000 Merge pull request #696 from jhancock93/datetimeoffset bd838b1 missed commit. 3a0bde0 Change service client constructor to work with OkHttp3 43c0a52 Change service client constructor to work with OkHttp3 0ce5694 First full generation of all clients 372be73 Converted required primitive parameters and properties to be non-nullable 10c8a5a Merge branch 'master' of https://github.com/Azure/autorest a87ffb1 Fix tests to be unique. 407924a Updates for x-ms-skip-url-encoding b42083c Merge pull request #699 from stankovski/nullable 0cf748b Add test swagger and acceptance test for modeling with DateTimeOffset option 749b052 Removed unused ctors 117b682 Catching exceptions in custom Json serializers 31e1680 update to have a unique name 37da7ba Fixed Python paging 7f05a80 Fix java cshtml to have proper tabbing b66c9a5 updates to have properties behave correctly. 958da62 Update defining-clients-swagger.md e27e5c6 Merge pull request #700 from jianghaolu/androidfix aef4f93 Update defining-clients-swagger.md bc525cd Typos 6815e95 Typos 98780d4 Update retrofit & okhttp, src/ compiles 15d65d1 Update retrofit & okhttp, src/ compiles 3c5fc26 Fix LRO for post/delete 8815106 Fix LRO for post/delete 569b64a Fixed possible null ref issues 55bd112 Merged PrimaryType back into one type e39e5bd Ignore checks for Object type 8512079 Ignore checks for Object type 7c379e6 Regenerated tests ccb4ce5 Split PrimaryType into individual sub-types 3ec8648 Adding tests for C# 283ef63 erroneous paren! b542cd3 Merge branch 'master' of https://github.com/Azure/autorest 033e505 Merge pull request #695 from stankovski/composite d378bb3 Fixed Python test 43e1131 Fixed Java test 7516da7 Merge branch 'rf' of https://github.com/amarzavery/AutoRest into composite a2957e5 Addressed fxcop issue d2ac2d0 fix fxcop warnings f0ea8a0 Add UseDateTimeOffset option to CSharp generator bfd42bb cshtml fixes 612f22f added tests for nodejs and azurenodejs composite client generation 422e78d Fixed misc tests 38cbe2e Bad if logic is bad. df15e64 More cshtml fixes! 6e67073 Fixes for cshtml 928ab6f Fixes for $ref params ef30f5c Fixed C# tests 7176ad7 Addressed fxcop issues 4ecdcf6 Merge branch 'master' of https://github.com/Azure/autorest 09b789f Merge branch 'master' of https://github.com/Azure/AutoRest into composite 6ad055b Added Azure test for composite client f9c0a60 Merge pull request #694 from haocs/fix ab24af3 Implemented merging of subclients into composite client. 01fec3e Fixed code analysis error 854bc31 final cshtml fixes for spacing 039a705 Merge pull request #691 from xingwu1/master db9fda0 Added tests for composite swaggers 578b6b9 Order the function parameters: make sure the parameters without default value are in front of the parameters with default value. b6526ae Merge remote-tracking branch 'Azure/master' 2aed06f Fixes for storage c425147 Fixed a null nextpagelink bug for java 1c06964 Java Azure codegen fix 1de7cee Merge pull request #685 from haocs/list e9b51e7 Merge branch 'refs/heads/ordered_tests' 3665d3e Run tests alphabetically 14994df Merge pull request #692 from stankovski/const 4e98a41 Fixed payload flattening for constant properties 395861e Fix bug: the azure import didn't use the current enum file name. a2db78b Change the file name of service client class. 78baadc Merge branch 'master' of https://github.com/xingwu1/autorest 58bf104 Change the generated file name: api_client to (service_name)_client, and enums to (service_name)_enums. 8ffdd28 Add operation properties' comment, and change the way handle user-agent. 9df7f29 Merge branch 'refs/heads/user-agent' f812424 Add disclaimer for zzz_tests.py 2e4c8c9 tabbing and accessibility. 7a67181 two more cshtml updates. 2aa2886 Regenerate all clients dc2ca26 Fixed missing new line 69bb960 Fixed runtime proj files 13f1729 Fixes to json and cshtml 0504032 Changed user-agent setter to function a38ceaa Addressed merge conflicts 9162d20 Fixed style check error 17d731b Fixed style check error 19b5722 Fixed code analysis errors ff99171 Fixed C# import issue f17dc3b Added offset tests for ruby and python be4655e Added offset tests for nodejs 379d658 Fixed warnings e7fea55 Async, sync and tests added for Java. 52907f8 Bump up Junit version. 063c3a6 Updated tests d38c5ac hand write paging operation 272f833 Finished Async a1a888c Implementing async methods ee57f8e sync done 3097334 Paging sync method implemented. 46f3078 Interface changes bfedcca Bump up Junit version. c4ca690 hand write paging operation 0ba7883 Merge pull request #686 from amarzavery/rf 6b838bb Initial x-ms-parameterized-host changes. af2be96 Fixed fx cop and jshint warnings b0e034c Fixed fx cop warnings aeeed0c Merge branch 'master' of https://github.com/Azure/autorest 7510a6d fixed documentation for constant properties of a model 9342b45 Csharp test fixes 09cbdf0 Made user-agent header appendable d5ba96b nodejs constant fix a5387a0 Updating NodeJS to support constant composite props 6a70598 Merge branch 'master' of https://github.com/Azure/AutoRest into const 12adce5 Fixed test 8d767d0 Added support for constant composite parameters (when a model has all properties as constant) 01fc75e Improved Constants to be based on 1 enum value + required = true. Added initialization for models & method parameters with c/x types that contain constants. 5887898 Merge pull request #680 from stankovski/master 5471d11 Merge pull request #679 from xingwu1/master a41843a Added test for constants in child objects 58b75c8 Regenerated NodeJS tests 40e8e84 Generate the docstring correctly (always has ':' at end of parameter comment even there is no detail comment) 6a8c512 Merge branch 'master' of https://github.com/Azure/autorest 94693b7 Started work on custom baseUri 8c4d90c Reduce the generated python directory length. 22182dc Merge pull request #678 from amarzavery/rf 284d84e remove content-length from headers for non put/post requests 565948d Merge pull request #677 from stankovski/master dca401a Merge pull request #676 from amarzavery/rf da71664 Changing parameter validation from ERROR to WARNING 8e2bdd6 Updated package.json for runtime 97fae0c Merge pull request #675 from stankovski/master a845f34 Merge branch 'master' of github.com:Azure/autorest into rf a25dd98 strip auth headers 70871f3 Update ClientRuntime versions 01dda77 Merge pull request #674 from stankovski/const 24be98f Commented out constant tests in Python TODO: Implement constants in Python e1c9b02 Updated GlobalSuppressions.cs 11758d5 Removed content length from NodeJS code d63965c Merge branch 'master' of https://github.com/Azure/AutoRest into const 9fc270d Merge pull request #661 from xingwu1/master 0fa2f46 Suppressed fxcop errors c9a2645 Removed IsRequered=true from constants 42a82ce Added QuoteString to CodeNamer 7a3d4c4 Merge branch 'master' of https://github.com/Azure/AutoRest into const 752e735 Merge pull request #671 from matthchr/python 0247123 Re-enable python 3.5 testing cef4d4c Regenerate python comments. 7ccff7f Generate comments for all classes. 1d606b5 Merge pull request #670 from stankovski/clouderror b468f55 Addressed code review comments 0f9c4cd Implemented constants in C# code gen #281 and fixed #629 d7a583b Merge pull request #655 from stankovski/master a314ff3 Fixed casing issue causing CloudError in Azure clients to always be null #668 5e9e745 Updated tests to use MICROSOFT_MIT_NO_VERSION header 96f4288 Reverted .travis.yml 6812699 AutoRest should not include full version number in copyright notice #598 b0e9f58 Merge pull request #666 from jianghaolu/master db9e0de Fix deserialization of CloudError d095f31 Fix deserialization of CloudError 0b2b933 Merge pull request #664 from jianghaolu/jdkauth a77b083 Merge pull request #664 from jianghaolu/jdkauth 8982860 Fix check style errors 4dbc457 Fix check style errors c85d86a Add a test for user credentials d890da9 Add a test for user credentials e596418 Merge branch 'master' of https://github.com/Azure/AutoRest 21aa71d Merge pull request #658 from jianghaolu/master 4ec4160 Revert bad changes for Java build scripts cc76677 Revert bad changes for Java build scripts 4320fad Add expiration check to credentials 6cea69b Add expiration check to credentials 29af4c4 Merge pull request #637 from Azure/python 205bf79 Update clients-auth.md bbe74a3 Update defining-clients-swagger.md 252c425 Added DNX test run c0e0b4a Merge pull request #654 from stankovski/master f7f19d0 Removed ID from IResource - this change will break a number of clients that have custom CreateOrUpdateParameter objects 0342cdd Merge pull request #649 from stankovski/master 4dbb046 Bumped version to 0.15.0 3642c78 Merge pull request #648 from Azure/release0.14.0 0d50c7c Update ChangeLog.md 5bf1f27 Merge pull request #646 from stankovski/master 66f9098 Merge pull request #640 from xingwu1/python ccecaf6 Updated ChangeLog.md d920030 Merge pull request #644 from amarzavery/rf 0a7df6d Merge pull request #645 from stankovski/master 43636cd Change Microsoft.Rest.ClientRuntime.Azure.Authentication ADAL dependency to be exact 9868ff4 Update the python generated based on Denis's feedback. da7e489 Improve message 4efe1c3 Merge pull request #643 from stankovski/master 3475f6d Change summary on validate method #439 9722dc6 Merge branch 'refs/heads/generic_requests' into python f87e05c Removed redundant config fe235da Moved around some docstrings 6a5d599 Merge pull request #636 from jianghaolu/master 5b48512 Merge remote-tracking branch 'refs/remotes/origin/python' into generic_requests 679ff7b Cleanups to runtime setup, docstrings a6cc525 Remove the extra line at end of file. 816103a Update clients-auth.md 57df589 Move gradle properties into a centralized one 21c865f Move gradle properties into a centralized one d41447f Merge pull request #625 from stankovski/master ffd3426 Clean up gradle build scripts 451039a Clean up gradle build scripts d57b0a5 Merge pull request #635 from xingwu1/python 850aad4 Update python after merge with master: c861711 Rename operations to end in 'Operations' c915ebe Merge branch 'master' into python1 952c455 Removed HttpResponseMessageStream and fixed failing C# tests bf09f66 * Code review feedback * Added SerializationException - if JSON deserialization fails, the exception should capture the response body #527 0f75401 Merge pull request #630 from jianghaolu/renaming a178b9f Merge branch 'master' of https://github.com/Azure/AutoRest a8bb504 Added logic to dispose HttpRespose and HttpRequest when returning just the body de5c1bb Rename azure runtime's package to com.microsoft.azure bea518e Rename azure runtime's package to com.microsoft.azure 53efbd5 Use the client referenced mapper adapter 6080e9f Use the client referenced mapper adapter 9138a39 Rename JacksonUtils to JacksonMapperAdapter 25e31d5 Rename JacksonUtils to JacksonMapperAdapter 186ca10 Merge pull request #623 from xingwu1/python 2248541 Merge pull request #627 from amarzavery/optional a8d2ac0 published runtimes a417c3b missing semiclon 4f4b244 Merge branch 'optional' of github.com:amarzavery/AutoRest into optional 10eb794 jslint fix 5b6705f jslint fix 8e8426a regenerated code and clientruntime changes 3a78081 stripped versions of request and response as error object properties. 3927c49 Updated requests dependencies 4fd4081 Added disposal to RetryHandler for HttpResponseMessage b99ba7e Merge pull request #626 from jianghaolu/androidsample 621d28e Android authentication updates from sample 2e08ff5 Android authentication updates from sample e340de3 Wrapped C# request and response in a new object to avoid being disposed #624 [Delivers #110445462] 92f062d Node.js:updates to generic and azure clientruntime ced91b3 Added stream parameter to runtime 770ba7f headers default to None c984b32 Get rid of unnecessary stream parameter. 3be0deb Callback only use when upload/download stream f548b86 static token cache 111f14d static token cache 5ce40c1 Tox fixes 185ec6d Merge branch 'refs/heads/test-upload' into python ba43d8f Updated streaming callbacks d3339f7 Merge pull request #621 from stankovski/internal 3fcb214 Merge branch 'refs/heads/anna-local' into test-upload 2e18bac Merge remote-tracking branch 'refs/remotes/origin/python' into anna-local ba3dd94 Added license headers 7b41b4e Fix the model/method class comment dbb60aa Finished implementation of internal ctors in C# and adds tests #618 [Delivers #106698204] 11aa6c1 Merge branch 'master' of https://github.com/Azure/AutoRest into internal ae343a8 Add ability to specify code gen settings via swagger spec #619 [Fixes #111791860] Add setting for C# gen to specify constructor protection level #618 [Fixes #106698204] 5c618ea Merge branch 'refs/heads/anna-local' into test-upload ff1248d Merge remote-tracking branch 'refs/remotes/origin/python' into anna-local a1344ee Merge pull request #575 from xingwu1/python 3a8695d Update python code generator: ac0252e Merge pull request #620 from amarzavery/optional 35a6e81 Escape single quotes in the url for nodejs codegen 127610d Merge pull request #612 from iouri-s/patch-1 dd5f017 Merge branch 'refs/heads/anna-local' into python 01d3f53 Merge remote-tracking branch 'refs/remotes/origin/python' into anna-local b8660f7 Reformatted model equality for flake8 50105af Merge pull request #610 from stankovski/client-request-id 3606ea6 Merge branch 'refs/heads/anna-local' into test-upload 2f6d22d Update python coverage pass requirements 2bdf346 Update coverage ignore strings to ignore .tox 1344bcb Fix issue in linux where node server doesnt exit 6cb7f57 Fix python failures related to shell execution 02187d9 Reduce the required code coverage for msrestazure 8f8bb72 Temporarily remove python 3.5 from tox validation 9c80c21 Fix travis for python f0d9da2 Added default value for LongRunningOperationRetryTimeout and fixed NodeJS code gen bd9640c Merge branch 'refs/heads/anna-local' into python 66e350f Fixed dict default f56637c Merge pull request #616 from jianghaolu/master 3c4e5a2 Add Android build doc to README 941f40a Updated documentation 922a963 Renamed paged.items to current_page fb5d653 Removed unnecessary utils require f52c2df Suppressed fxcop errors e9c5651 Merge pull request #611 from jianghaolu/batchfixes 5c44f6c More review edits 4641d2d Change ClientRequestId to GenerateClientRequestId e231f2f Handle null content in async operations 7118bdc Add test on response typed headers 7de84cd Add custom serializer for okhttp Headers 6c382b1 Add custom serializer for okhttp Headers 4045723 Added tests for ClientRequestId in Client 8bcfa71 updating clientruntime version to 2.0 c257b3b Removed paging collection magic methods 32849aa Revert "Removed paging collection magic methods" 816d619 Removed paging collection magic methods 03b4c1a Merge pull request #608 from stankovski/client-runtime c06db7d Updated NodeJS code gen to use clientRequestId from client 863ace5 Moving ClientRequestId to client 1bed78c Added NodeJS test e600220 Suppressed fxcop error 5aa2897 Updated code generator to populate ClientRequestId on CloudException 0aea0db Merge branch 'master' of https://github.com/Azure/AutoRest into client-runtime 8d2f4dc Revved up ClientRuntime 198949e Added RequestId to CloudException ce26b35 Merge pull request #607 from jianghaolu/batchfixes 0ca1769 Support android flow a9aefc2 Support android flow c7b1e66 Removed ordered models 9146a6f Merge pull request #606 from amarzavery/optional 7e859f1 Updated formdata uploads d98e102 Merge branch 'master' of github.com:Azure/autorest into optional cc59645 Improved Error handling 05391f4 Merge pull request #605 from matthchr/feature/rfc1123-datetime-kind-fix fa0c70f Fix bug with Rfc1123 dates related to DateTimeKind 2e475df Merge pull request #604 from jianghaolu/batchfixes 2cd9325 Move credentials setup after custom headers 8f07c84 Fix user agent header 1991445 Fix user agent header 28b3e49 Add content-type headers to requests 014740c Merge pull request #603 from amarzavery/optional 4c4bde7 updated jshint rc and clientruntime version numbers 1d60861 Support for Stream and Object Primary Types 43c569f minor fix 5500551 minor changes to pagetemplate model 7d17602 Merge pull request #602 from amarzavery/optional 73d925d Updated message string constant to 1.5 version of ms-rest and ms-rest-azure 41b4384 regenerated after pulling from upstream 0b846f4 Merge branch 'master' of github.com:Azure/autorest into optional ade6297 simplified parsing of CloudError 13ce073 Merge pull request #591 from matthchr/feature/header-return-fix 10ec8ea testing file upload b2b2818 Merge branch 'master' into feature/header-return-fix 4988741 Merge pull request #590 from amarzavery/optional dc2ce3d Merge branch 'optional' of github.com:amarzavery/AutoRest into optional 44e7426 jshint fixes 913d3a4 jshint fixes 47cd2ca fix fxcop warnings 51f241a code generation changes e8a4aca clientruntime changes 9d4e732 Merge pull request #597 from stankovski/clientruntime-1.8.2 a828b05 Updated gulp-runtime-version-sync.js and re-ran against the latest code b45e6a5 Updated NugetPackageTest ClientRuntime version 031dfe5 Merge pull request #595 from stankovski/master e59b643 Fixed CustomSettings behavior when taken from autorest.json (issue #589) ff4e1c5 differentiate between parameter flattening and grouping d8a1a88 Merge pull request #594 from jianghaolu/master 1087a41 Merge pull request #592 from stankovski/master 4fee3d4 Fix issue with produces/consumes a183014 Fix URL handling in Retrofit 2.0 eb5235c Merge pull request #593 from jianghaolu/master 0c9f9d0 Fix java import and parameter grouping 77ac148 Fixed test a010746 Add HeadException tests 5c278a4 Merge branch 'master' of https://github.com/Azure/AutoRest 8560b60 Merge pull request #588 from jianghaolu/android fb42694 Fixed constructor when -AddCredentials is used and there are no other client properties (issue #570) a3e9c00 Regenerate test code d37a0ea Fix gulp build issues 5ecc6a1 specified moment as a dependency d3c7fe9 fxcop & clientruntime fixes. removed unrequired code. b46837e clientruntime changes 0f3da06 moved back to storage for azure nodejs tests 0af4ea3 all tests passing 89a0c08 code commit 1578def Add missing addons for android build cf11017 Merge remote-tracking branch 'refs/remotes/origin/python' into anna-local 7de1917 Fix bug with "Produces" not being honored 191e31b Update python generator based on feedback: d6327d1 Replaced integers with logging constants 031dbca Fix pagable method param group bug 6dfab6d Update handling of headers 7993bfd Merge remote-tracking branch 'Azure/python' into python1 35a71d2 Add authentication lib build to gulp 33e9edc Add android to travis build 5a21d07 Include Java auth libraries in gulp ad98381 Split JDK/Android authentication libraries from runtime 4c481c9 Split JDK/Android authentication libraries from runtime c75bcb0 Split authentication into JDK and Android 5669d0f Split authentication into JDK and Android e4bd945 Add android authentication library 5236ce7 Add android authentication library 8670ca4 Corrected model equality and sortability 8bf26c0 Merge pull request #586 from Azure/master a203a95 Merge branch 'master' of github.com:Azure/autorest into optional 85530fe Update swagger-extensions.md cb7df7c Update swagger-extensions.md 58086c1 Merge pull request #585 from jianghaolu/paginggrouping bff0b7a Merge pull request #587 from stankovski/master ae8657b Fixed body-formdata.json spec 1578b5f Fixed azure tests cf20ad3 Added docstrings, review fixes, bug fixes 5784b84 Fix suppresion file encoding 8912269 Support scenario for grouping partially header params 65ac200 polymorphicdiscriminator support for deserialization 1ad1b1c polymorphic serialization in clientruntime 91d6d0c [fixes #109931270] Support reusing grouping types for paging next operation 8dd33d7 [fixes #109931270] Support reusing grouping types for paging next operation e6e4cf9 Fix the suggestion in code review. f3f65c5 modified PageTemplateModel 5f80292 reconstructed model mapper for serialization and deserialization 2350e02 able to generate model mapper d89ecad Merge branch 'master' of github.com:Azure/autorest into optional fc7b513 added constraints validation in the serializer 7204e00 Implemented deserialization with ResourceFlattening and Paging support 3d5cfdf serialization looks decent 5e5c95a resource flattening a5bb44c Merge pull request #578 from stankovski/master 0a7c614 Updated documentation 591f68b Fixed parsing of x-ms-request-id and x-ms-client-request-id 70331db Merge branch 'master' of https://github.com/Azure/AutoRest 3e944f1 Updated schema and removed one layer from x-ms-request-id and x-ms-client-request-id extensions 9c3568c Fixed x-ms-paths d0521fc Merge pull request #577 from stankovski/master d2fae5c Fixed x-ms-external definition d65595f Merge branch 'optional' of github.com:amarzavery/AutoRest into optional 5b4e928 serialization in ms-rest 6a2e2c9 serialization in ms-rest f9cd626 Update swagger-extensions.json f9b49df Merge pull request #576 from stankovski/master 726d752 Added schema for AutoRest swagger extensions b17b0ee Update the code generator for cleanup. 130fb65 Add gulp step to install tox before python tests 67f7468 Updated user-agent config f90bfac Update client runtime for bug fixes. 3db1c7b Default item name should be "value" instead of "values". f3ce76e Fix flake8 issue and update test codes. cb0866c Fixed parameter encoding bac92b6 Azure Python will return bool for HEAD operation. 9f98cea Update python clientruntime. e8f366a Enable flatten resource on generated code. 3b8d654 Update Flake8 to have line length max = 100 b32a4c1 More LRO and paging tests 631fc71 Add gulp integration for Python tests f227624 Update azure python generator. f0ea311 Update the serialization code for path/query/header. Enable stream support. 70eb2ab Add test cases and fix bugs. 077c8fd Header parameter isn't set correctly. Don't generate listNext function since we already handle in Paged class. 86b24cc Updates to serialization for date, rfc and bytes b2e1d3f Init check in for azure python generator. 239753f Better handling for bool and bytes deserialization 7238298 Update model to import the base model class. 6c30cfd proposal for sequence serialization 6b0f104 Add setup.py for python generator, add Polymorphic support. 5d08875 Fix python enum generator e2b67b7 Add Tox support for Python af16f6c Update python code generator, remove useless methods. 3836c3d Improve python client runtime. c6418ce Fix generic generator bugs. 66049a1 Update client runtime. c725a8a Update python generator. 209358b Moved paging into generic runtime, added proper enum support f8b80da Python code generator first draft. 9aa1cbe Update msrestazure. 08470e3 Add python code generator place holder. 3aa5018 Init with new python client runtime. ffe48e7 Fixed schema table formatting e0966ef Update defining-clients-swagger.md e9b7c60 Merge pull request #574 from stankovski/master 6418c00 Addressed code review feedback eec67d5 Added remaining extensions cac9ae4 Added documentation on Swagger extensions beeeb54 Merge pull request #573 from amarzavery/optional 3e7e803 updated ms-rest-azure to 1.4.0 4f5f52d Merge pull request #572 from amarzavery/optional 721f560 regenerated nodejs code and fixed a test 32c516d Merge branch 'master' of github.com:Azure/autorest into optional ed6d514 Updated Error handling for NodeJS b6b54ed Downgraded client runtime to 1.8.2 29cba16 Merge pull request #571 from stankovski/master 3b392a2 Addressed code review feedback e8ffaa3 Fixed fxcop issues 0d8ec16 Regenerated tests 9a39186 Added OperationName property to x-ms-pageable cc3e772 Merge pull request #569 from stankovski/master 4587cfe FXCop suppressions 304be74 Added support for custom paths via x-ms-paths 60fbccf Merge pull request #566 from yugangw-msft/newton6 ecb8ce3 Merge pull request #567 from stankovski/master 3c8cf30 update e2e test to test 1.9.0 version of client runtime 1aebe63 Fixed OData expression builder with null 38a76f0 Merge pull request #565 from amarzavery/optional 3bd9491 Use 6.0.8 of newton.json when build for 4.5 29bd100 some more fixes a3369c2 Merge branch 'master' of github.com:Azure/autorest into optional 32cf05b base property check for sequence and dictionary types f548bb9 Merge pull request #563 from jianghaolu/jfixes f136e01 Update versions to 0.0.2-SNAPSHOT 9f98a09 Update versions to 0.0.2-SNAPSHOT 14a8872 Merge pull request #561 from amarzavery/optional 64dc2bb Merge pull request #564 from hovsepm/master 4e0bc0e Merge pull request #562 from stankovski/file ae76ab9 Fixed Odata filter bug with "startWith" null values d77e993 Address style checks 31d0b15 Address style checks c99e73f Support typed response headers in Java 6c185b4 Support typed response headers in Java dc6c512 C# IPage to be IEnumerable 2a5d264 Removed x-ms-file-name 9d277ee Static analysis fix 6ec6195 Implemented form-data support and file upload in NodeJS and C# ebe32bb generated code 0608859 Merge branch 'master' of github.com:Azure/autorest into optional f6beadb listNext() method should not be displayed if nextLinkName == null 2c287a5 Merge branch 'master' of https://github.com/Azure/AutoRest into file 92b75f1 Renamed ContentType to RequestContentType and fixed modeler to properly treat Consumes and Produces 6584c5b Merge pull request #559 from amarzavery/optional 2c940e1 Merge pull request #560 from stankovski/master 83ff37c Merge branch 'master' of https://github.com/stankovski/AutoRest into file 6439255 Regenerated with AutoRest 0.14.0 5548c8a Added support for upload streaming in NodeJS 6e5e0eb Implemented upload tests in C# ee27054 fix fx cop warnings c5d508e added unit test for complex model code generation in nodejs 50e2fe3 regenerated node and node azure code using the new version of code generator 3f2f689 Merge branch 'master' of github.com:Azure/autorest into optional f299ac0 Fixes issue #557 657e0b6 Merge pull request #558 from jianghaolu/jfixes e62dec2 Address code analysis errors 994c23f Address checkstyle errors dcac2c8 Address checkstyle errors b16dc7f Finish custom exception support 61a6fa3 Finish custom exception support 93462a6 Merge branch 'master' of https://github.com/Azure/AutoRest into file 73b40b2 Merge pull request #556 from stankovski/master 5b0de14 Bumped up version of AutoRest and ClientRuntime f75438d Work in progress on file upload bca1b5b Merge pull request #555 from jianghaolu/jfixes aec1d4a Support custom exception in Java 903fbb0 Support custom exception in Java 749e792 Update clients-error.md 2760381 Merge branch 'master' of https://github.com/Azure/AutoRest into file 55bf9f1 Merge pull request #554 from Azure/release-0.13.0 ed83a4f Merge pull request #553 from stankovski/release-0.13.0 ce41aa7 Incremented clientruntime versions for nodejs 5bac70c Updated changelog and converted it to .md format 9f06b44 Work in progress on file upload support 8d3e6b3 Add back polymorphism tests 8caaf34 Add back polymorphism tests 355e6d0 Merge pull request #552 from yugangw-msft/newauth 7c9cf82 Updating form-data example and server 6062d59 Merge pull request #551 from stankovski/dev e243fd6 Added test for the fix 6d081ed Fixed issue with PolymorphicJsonConverter when models include Page 514ed41 Added support for generic file stream in C# 05b6f08 Work in progress on NodeJS file support 1207546 Merge pull request #549 from stankovski/underscore 97eb273 Merge branch 'avilenskydev' into underscore e765e13 FXcop validation fix d5ff404 Fixed URL generation with segment and updated LRO code b87152c Updated changelog 2315f63 Merge branch 'dev' of https://github.com/Azure/AutoRest into underscore da2ccd2 Merge pull request #548 from stankovski/dispoable 2f6ad73 use newer ADAL with support on federated org-id 3a6d084 Uncommented skipped tests f6f3084 Make the variables not clash with parameters (#309) 2aa6f1c Merge pull request #547 from stankovski/resProperties2 78ebfa3 Changed service interface in C# to implement IDisposable (#278) 3118d06 Suppressed fxcop warning 4346ea7 Merge branch 'dev' of https://github.com/Azure/AutoRest into matt-gibbs/resProperties2 94c0277 Merge pull request #538 from brjohnstmsft/jsonconvertfix 4720aaf Merge pull request #545 from amarzavery/optional b37fc30 Add custom JacksonConvertyFactory and fix polymorphism a4be93b Add custom JacksonConvertyFactory and fix polymorphism 51dd311 fx cop 75d3810 treat …

…ecodeData methods (Azure#559) * [test] The protocol part of url property in httpbin response is not consistent with request url, fix:assert for both http and https. The '1.1 vegur' via header is not returned from httpbin anymore. * Adding default impls for methods in HttpResponseDecodeData interface, java-doc for HttpResponseDecoder. * Fixing the regression introduced (due to new MalformedValueException type) in the commit c6945f28534b3c57d261e30505c813114994fb84

* Fix bugs and docs * Fix checkstyle * Add status code checking to PollStrategy.updateFromAsync() * Fix checkstyle * Fix mentions of credentials in comments * Add proxy support * Ignore proxy tests * Add proxy authentication policy * Add scheme to proxy authentication header value * Fix checkstyle * Add address information to IllegalArgumentException * Add mention of proxy authentication in Builder.withProxy * Fixes from review feedback * Rename URI in NettyAdapter to channelAddress * Update to RxJava2 and fix build errors * Fix tests * Update build scripts * Fix Android CI * Fixes from feedback. Better RestProxy exception messages. * Fix gradle.build for Android * Fix handling of checked exceptions from serialization * Add required parameters to Builder constructor. Add default RestClient. * Tweak docs and use AzureRestClient in AzureServiceClient * Add back deprecated, parameterless builder constructor * Remove unused serializer adapters in tests * Replace RestClient with HttpPipeline (#302) * Add initial Pipeline implementation * Remove RestClient, AzureRestClient, ServiceClient, and AzureServiceClient. * Fix tests * Reorder HttpPipeline.build() arguments * Fix checkstyle * Add defaultSerializer() method on RestProxy * Add ServiceClient and AzureServiceClient back with modifications * Small changes to RestProxy and AzureProxy * Add createDefaultHttpClient() methods to RestProxy * Add HttpPipeline.Options and RequestPolicy.Options * Add UrlBuilder.parse() (#303) * Add UrlBuilder.parse() method * Add PortPolicy class * Parsing URLs is non-trivial. Revert to using Java URL parse * Fix copy and paste error * Add ProtocolPolicy and tests (#305) * Add health check to channel pool * Add extra request policies to RestProxy's default pipeline (#307) * Add extra request policies to RestProxy's default pipeline * Create a new NettyAdapter for each NettyClient * Fix checkstyle * Add InputStream support for HttpRequestBody (#308) * Create HttpPipeline.Builder from an existing HttpPipeline (#309) * Create HttpPipeline.Builder from an existing HttpPipeline * Insert directly into requestPolicyFactories * Use io.reactivex for new RequestPolicies * Use Maybe to deserialize response bodies * Remove usages of Exceptions.propagate * Add AzureEnvironment to AzureServiceClient and add AzureProxy.create(… (#310) * Add AzureEnvironment to AzureServiceClient and add AzureProxy.create() overload that takes an AzureServiceClient * Remove AzureProxy.create() overload that takes baseUrl * Remove RestProxy.create() overload that takes a baseUrl * Fix build errors * Add HostPolicy (#311) * Add HostPolicy * Remove extra 'withHost()' call * Add HostPolicy tests with port * Add http scheme if no scheme is provided when creating a HttpRequest … (#313) * Add http scheme if no scheme is provided when creating a HttpRequest in RestProxy * Remove adding a default protocol when one isn't specified * Remove unused exception import * Move LogLevel to LoggingPolicy, expand HttpPipeline.Logger and add si… (#312) * Move LogLevel to LoggingPolicy, expand HttpPipeline.Logger and add simple implementations * Remove RestProxyTests changes * Fix build breaks and checkstyle errors * Add withRequestPolicies * Add UrlTokenizer and make UrlBuilder use it (#316) * Fixes and coverage for exception serialization * Remove unused imports * Allow full URLs as value for PathParam (#317) * Begin experimenting with Flowable response content * Implement HttpContentFlowable * Fix checkstyle * Fix build errors * Add missing Test attribute * Some error handling and other tweaks * Update Netty version. Stress testing. Fix test build errors. * Add MD5 verification to downloads test * Test cancellation * Test small file uploads * Simplify download test * Recent requests from Rikki and Josh (#319) * Add HttpPipeline.LogLeve.OFF and AbstractRequestPolicy.shouldLog() * Make BodyParam Content-Type required * Fix build break * Hide HttpPipeline.Logger inside RequestPolicy.Options (#320) * Hide HttpPipeline.Logger inside RequestPolicy.Options * Add tests for RequestPolicy.Options * Add AsyncInputStream and FlowableFileStream * Extract all inner classes to their own files (#321) * Fix checkstyle * Add Flowable content to HttpRequestBody interface * Remove LoggingPolicy from RestProxyTests * Changes from feedback, bug fixes, additional testing * Fix bug in test * Add parallel upload test * Remove FlowableFileStream. Backpressure file reads. More stress testing. * Fix path replacement bug reported by Storage team (#323) * Tweak concurrency in tests * Add timeouts and central cleanup * Fix hanging issue and cleanup * Bring back FileRequestBody * Fix file over-reading bug * More fixes * Fix typo in doc * Don't overwrite a UrlBuilder path with a slash (#326) * Don't overwrite a UrlBuilder path with a slash * Add UrlBuilder tests * Add upload test which writes files to disk upfront * Add Throttling policy * Add isReplayable to AsyncInputStream * Add parallel download test * Add download time taken logging * Support AsyncInputStream return type * Set Content-Length: 0 when body is null * Add AsyncInputStream.create(byte[]) * Reduce duplication when sending request content * Single<HttpResponse> closes channel if disposed before emitting * Release channel back to pool after closing * Helpers for cancellation and error emit * Add a RestProxy.create() overload that takes a ServiceClient parameter (#332) * Add a RestProxy.create() overload that takes a ServiceClient parameter * Rename AzureProxy.defaultPipeline() to AzureProxy.createDefaultPipeline() * Remove Charsets.defaultCharset(). Update Jackson. * Revert Jackson version to 2.8.11 and add JacksonSerializer tests (#336) * Thread safety, native transports, and async file I/O (#337) * Experimental EpollEventLoopGroup * Add profiles to pom. Change HttpRequestBody to abstract class. * Try using getConstructor().getInstance() * Fix bug with mixed nio/native components * Get inner exception message if needed * Fix incorrect string for EpollEventLoopGroup * Use native transports when Netty sizes manually specified * Experiment with Rx test file creation * Add prepareFiles step and properly parallelize * More test file creation tweaks * Simplify stress tests and improve file gen * Fix bug in FileReadFlowable. Add writeContentToFile(Flowable). * Fix early completion in writeContentToFile * Write to file in download test. Fix thread safety in ResponseContentFlowable. * Limit concurrency in download test * Fix race in writeContentToFile * Add download/upload streaming test * Add x86_64 check to pom * Thread safety improvements * Change subscribeOn to observeOn and simplify test * Require users to include native modules in runtime builds * Make eventLoopGroup and channelPool final * Fixes from feedback * Use subscribeOn instead of observeOn for HTTP response content * Fix typo * Consolidate NettyAdapter constructors * ThrottlingInterceptor tweaks * Use HttpMethod instead of String (#342) * Add HttpMethod class * Use HttpMethod instead of strings * Use Single.error instead of throw Exceptions.propagate (#343) * Use URL objects instead of Strings (#344) * Remove check for null body parameter and get tests to pass (#346) * Tweaks for Azure Libraries for Java (#345) * Add ServiceFuture.fromBody(Single) * Throw unchecked exception from RestProxy.invoke * Add TimeoutPolicyFactory. Delete UseOtherHostPolicy. * Remove AddRequestPolicyBefore/After. UserAgentPolicyFactory inversion. * ProtocolPolicy.Factory -> ProtocolPolicyFactory * CredentialsPolicy.Factory -> CredentialsPolicyFactory * RetryPolicy.Factory -> RetryPolicyFactory * AddCookiesPolicy.Factory -> CookiePolicyFactory * PortPolicy.Factory -> PortPolicyFactory * AddHeadersPolicy.Factory -> AddHeadersPolicyFactory * ProxyAuthenticationPolicy.Factory -> ProxyAuthenticationPolicyFactory * Factory class inversion in RestProxyStressTests * LoggingPolicy.Factory -> HttpLoggingPolicyFactory * RequestIdPolicy.Factory -> RequestIdPolicyFactory * HostPolicy.Factory -> HostPolicyFactory * Fix checkstyle * Add flag to pretty print JSON HTTP bodies (#347) * Emit initial response when polling. Allow empty body to complete ProvisioningStatePollStrategy. (#348) * Emit OperationStatus corresponding to Void response (#349) * Remove unused ListOperationCallback (#353) * Use Flowable<byte[]> instead of AsyncInputStream. Drop File body types. (#354) * Use Flowable<byte[]> instead of AsyncInputStream. Drop File body types. * Remove HttpRequestBody. Refine HttpRequest.withBody doc. * Fix test build errors * Perform response deserialization in HttpPipeline (#360) * Add DecodingPolicyFactory. Fix client-runtime tests. * Fix test failures mainly by reverting to older impls * Rename inner class * Fix checkstyle * Cleanup * Remove unused methods * RestResponse implements Closeable * Add null check to DecodingPolicy * Fixes based on self-review * Fixes from review feedback * Use Flowable<ByteBuffer> instead of Flowable<byte[]> (#361) * byte[] -> ByteBuffer and experimental ByteBufAllocator * Fix checkstyle * Fix build errors. Use standard ByteBufAllocator. * Add memory mapped upload test * Add ByteBuffer splitting and read/write memory mapping * Fix build errors * Use ByteBuffer.remaining() * Remove AsyncInputStream (#363) * Wrap exceptions generated from deserialization and other minor tweaks (#364) * Add ByteBufferUtil and tests (#365) * Add ByteBufferUtil and tests * Update ByteBufferUtil.toByteArray() comment * Expanded test for ByteBufferUtil.toByteArray() * Add FlowableUtil.collectBytesInBuffer() method (#366) * Add decoding policy to default pipelines (#367) * Add DecodingRequestPolicy to default RestProxy HttpPipeline * Add DecodingRequestPolicy to AzureProxy default Pipeline * Fix checkstyle * addQueryParameter() -> setQueryParameter() (#368) * Add client-runtime-native module (#369) * Add client-runtime-native pom * Move mvn os extension to parent pom. Use os.detected.arch. * Simplify native pom * Actually necessary to manually include boringssl in each profile * Update to Netty 4.1.21 and test read-only memory mapped file (#370) * Add support for x-ms-header-collection-prefix extension (#371) * Add support for x-ms-header-collection-prefix extension * Fix checkstyle and update HeaderParam documentation * Add runtime support for deserializing HeaderCollections (#376) * Add runtime support for deserializing HeaderCollections * Fix checkstyle failures * Fix javadoc error (#378) * Always specify charset with new String(). Prefer StandardCharsets over Charsets. (#379) * Add shutdown() method to HttpClient.Factory (#380) * Make HttpClient.Factory Closeable and add tests * Experimenting with other approaches to try and make shutdown work reasonably * Use Completable for shutdown() * Factor out HttpClient inner interfaces * Fix leak in NettyResponse.collectContent() * Fixes to try/catch in NettyClient.java * Make shutdown() lazy * Handle missing Content-Length * Fix proxy host header bug * Handle readableBytes/array().length mismatch * Use daemon ThreadFactory in NettyClient * Use daemon mode for SharedChannelPool worker thread * Initial check in for resumable LRO. * checkstyle fix * Checkstyle fixes. * Check style fixes. * Checkstyle updates. * Checkstyle fixes. * Another checkstyle fix. * Fix Void response body connection leak (#384) * Fix spelling in PollStrategy Javadoc (#392) * Add RestResponse subtypes and handling (#393) * Add RestResponse subtypes and handling * Tweak Javadocs and modify tests to use some concrete types * Target Java 8 * Use lambdas in RestProxyStressTests * Use java.util.Base64 instead of Guava * Various minor improvements (#396) * Remove Apache Commons dependency * HttpClientFactory.close() instead of shutdown() * Use per-instance lock in SharedChannelPool. Fixes #388 * Fix condition wait in SharedChannelPool. Fixes #390 * Disable test for close() with in-flight request * Fix checkstyle * Update README.md and add convenience HttpPipelineBuilder methods (#398) * Update README.md. Add convenience methods to HttpPipelineBuilder. * Tweak wording * Remove unused test imports * Update groupId in example dependencies * Fix reentrant safety in ResponseContentFlowable (#402) * Use a queue drain flag * Use BackpressureHelper.addCap() * Update changelog for preview 1 * [maven-release-plugin] prepare release v2.0.0-beta1 * [maven-release-plugin] prepare for next development iteration * Remove Joda dependency (#404) * Remove Joda dependency in favor of Java 8 built-in classes * Serialize HTTP request header values and URL Query values * Fix checkstyle * Add back apache commons for now (#416) * Move groupId above parent groupId so publish tools can infer it (#418) * v2 NettyClient flowable rework (#406) * v2 NettyClient flowable rework * add break to drain loop, add await calls to unit tests * remove TODO line * add wip and missed comments to explain usage in drain loop * update wip and missed comments * update wip and missed comments * checkstyle fixes * use HttpClient.createDefault in NettyClientTests * increase timeout in test * add NettyClient test to test concurrency * NettyClientTests - add logging to testConcurrentRequests * disable WireMock request journalling for concurrency test * only use one client with concurrency test * assert md5 hash of responses for concurrency test * assert total number of bytes in NettyClient.testConcurrentRequests * refactor testConcurrentRequests * rename NettyResponse.streamBodyAsync to NettyResponse.body and add javadoc * make isDisposed volatile, rename didEmitHttpResponse to httpResponseEmitted and make volatile * use AtomicBoolean for disposed to ensure channelPool just gets closed once, protect FlowableResponseContent from events arriving before Subscription (queue them properly) and ensure drain by calling drain also from onSubscribe * add TODO * remove observeOn from request.body() because Netty handles scheduling on eventloop if required * refactor to extract getChannelAddress method to make easier to read * sendRequestInternalAsync rework * sendRequestInternalAsync rework * sendRequestInternalAsync rework * sendRequestInternalAsync rework - NettyClientTests pass * checkstyle fix in NettyClient.java * wrap long line, fix state transition on operationComplete * extract non-static class RequestSubscriber * make Subscription volatile * add comments * Add Jetty static server for RestProxyStressTest downloads * Don't write to file in download test * add failing download100MParallelTest and enable stress test * fix allocation of contentEmitter by assigning earlier * add sysout logs * call read after every channelRead event and set channel from channelActive call * ignore RestProxyStressTests * remove redundant transition * fix requested accounting (finally) * fix requested accounting a bit more * add comment about using BackpressureHelper.produced * fix checkstyle * remove no-modification compareAndSets * propagate HttpClient method renames to other modules * rewrite FlowableUtil.readFile and add tests * add backpressure test for FlowableUtil.readFile * increase number of chunks so that long input tests for FlowableUtil.readFile are about 100MB * delete large input test files on successful completion of tests in FlowableUtil.readFile * remove commment * extract constant * fix checkstyle and add overflow check * do another overflow check and move cancelled check inside while loop * add null check for channelInactive event * add FlowableUtil.split tests * remove old unused FileReadFlowable, refactor by embedding FileReadSubscription to save some allocations * Add MockServer and update RestProxyStressTests to communicate with it * Add exec-maven-plugin configuration for MockServer * FlowableUtil.readFile subscriber can implement CompletionHandler, fix unit test of split * simplify drain a little * Request content after channelWriteComplete. Test transient errors. Paranoid leak detection. * Null check in channelReadComplete. Simple file content generator in upload test. * Add request body error test * Warn when contentEmitter is null in channelReadComplete * Remove synchronous file read because it doesn't seem related to the root issue * Read request content during transient failure * fix transitions (retry wasn't happening), remove double setDisposable * add unit test for request body emitting an error * remove sysouts and add another unit test * make minor efficiency change to FlowableUtil.readFile * Use env var for temp folder path * fix maxRequired to be more defensive about long calculation returning less than zero, reduce volatile reads * set ByteBuffer position before flip to incorporate bytesWanted * edit comment * add comment * add writability processsing * fix state transition for writing * add comments * throw RuntimeException if item arrives before request made * Netty client rework 2 (#420) * Remove seemingly redundant writing state machine * Remove unnecessary EncoderException recovery * Optimistically add channel to leased list while waiting for it to connect * Remove apparently unnecessary warning about null contentEmitter * Only release and close on response completion if request not complete * Fix checkstyle * Send 202 for DELETE to satisfy testHighParallelism() * Launch MockServer automatically. Run stress tests based on env var. * Share IOService between test cases, not MockServer * More test tweaks. Still WIP. * Disable test server child process for now * Reduce parallelism in upload/download test * Don't close channel if response content subscription completed normally * Move os-maven-plugin to client-runtime-native package. Update Netty and RxJava versions. (#421) * Various minor improvements (#425) * Check for null channel before closeAndRelease * Remove client-runtime-native * channel.write() until not writable, then flush * Add Base64Util for all base64 encoding/decoding * HttpPipeline.build with Iterable. Fixes #375. * Extract AddDatePolicyFactory to public class. Fixes #391. * Require DecodingPolicyFactory for responses with serialized bodies * Fix NPE when getting the HttpClientInboundHandler from the pipeline * Refinements to FlowableUtil * Update README.md and release notes * Cleanup pom * Propagate nulls through Base64Util methods * add Netty config changes to changelog * Don't log by default in default Azure pipeline * Use .cache() instead of writing Single.just() to instance variable * Add delay param to RetryPolicyFactory. Check isDecoded() for custom headers types. * Use try-with-resources in FlowableUtilTests * [maven-release-plugin] prepare release v2.0.0-beta2 * [maven-release-plugin] prepare for next development iteration * Update version number in README * Add os-maven-plugin example to README * Update Netty to 4.1.25.Final (#429) * Add FlowableUtil.ensureLength (#430) * Add CountingOperator and tests * Use Flowable instead of FlowableOperator * Make ensureLength return FlowableTransformer * Use doOn* operators instead of custom operator * [maven-release-plugin] prepare release v2.0.0-beta3 * [maven-release-plugin] prepare for next development iteration * Initial tweaks in hopes of fixing channel pipeline NRE bug (#456) * Add request property to RestResponse (#457) * Support custom port for https proxy (#462) * Explicitly specify http vs https proxy instead of inferring by port * Update changelog * Update README.md to reference beta 4 * Raise MAX_SEND_BUF_SIZE to 64 KB * Update dependency versions * Fix checkstyle * [maven-release-plugin] prepare release v2.0.0-beta4 * [maven-release-plugin] prepare for next development iteration * Add UnexpectedLengthException (#468) * Add UnexpectedLengthException * Update tests * [maven-release-plugin] prepare release v2.0.0-beta5 * [maven-release-plugin] prepare for next development iteration * Fix HTTPS proxying (#476) * Progress on HTTPS proxying * Fix Azure compile error * Simplify netty pipeline and reduce possibility of corruption * Fix build error * Enable MSICrdentials in v2: Merging msi credentials for app-service and vm (#474) * Enable MSICrdentials in v2: Merging msi credentials for app-service and vm * Removing unused AppServiceMSICredentials and using binary expotential backoff algo retry * Guava gone (#477) * Try removing TypeToken * Fix all tests * Use TypeUtil * Simply getTypeArgument * Move things a little bit * Progress on HTTPS proxying * Fix Azure compile error * Simplify netty pipeline and reduce possibility of corruption * Fix build error * Remove type factory * Checkstyle * Clean up * Adding beta annotation (#478) * Add Context class, HttpRequest property, and RestProxy handling (#479) * Add Context class, HttpRequest property, and RestProxy handling * Handle null arguments * Implement our own URL escaper (#481) * Implement our own escaper Copy Guava url utils Use local guava copies Modify license according to CELA Use our own escaper * Be conservative about query escaping * Use our own license header * Checkstyle * Fix errors when guava gone in azure-client-runtime * Add tests for Url escaper and type util * Fix azure-client-authentication * Fix Cli token class * Add SkipParentValidation annotation from v1 (#484) * [fixes #460] Fix request body logging (#485) * [fixes #460] Fix request body logging * checkstyle * Remove Refresh token client and fix CLI login (#486) * Remove Refresh token client and fix CLI login * One more fix * ProvisioningStateStrategy should not poll if there is no provisioningState property (#487) * Remove channel writing state machine (#482) * Remove channel writing state machine This state machine doesn't appear to do anything because all the writes occur on the event loop anyway. We can rely on channel.isWritable() and the nature of the single event loop thread running for the channel to prevent multiple simultaneous requests for request content. * Use batch mode in maven * Request more data after writing if channel is still writable * [maven-release-plugin] prepare release v2.0.0 * [maven-release-plugin] prepare for next development iteration * Add versionConfig.csv * Support async adal authentication (#499) * Add delegated token credentials (#500) * Support async adal authentication * Add back delegated token credentials * Fix environment for Netty behaviors (#501) * Porting v1 runtime flattening serializer to v2 runtime & configurating jackon adapter to not to fail on empty bean (same config used in v1 jackson adapter) * Porting SkipParentValidation processing from v1 to v2 * Adding test for FlatteningSerializer * honor location header for POST & DELETE * Ignore android build * Migrate flattening serializer test * Migrate additional properties from v1 * Shared pool channel TTL support and fix to use available pool channels completely (#502) * Support for ttl for available connections. Ensure all connections in available pool are re-used * Polishing prev commit: Support for ttl for available connections. Ensure all connections in available pool are re-used * Adding a debug statement * Removing debug statements, Adding since to Beta, adding missing channel.close() * [do not merge] Netty client error handling (#505) * Some meaningless changes * Checkstyle * Replacing NettyAdapter with reactor-netty * Adding a Util type to azure-client-authentication module to hold common utility methods * Renaming package v2 to v3 * Up build tools version to v3 (#539) * Fixes in runtime v3 (#540) * Fix flattening serializer * Support proxy * Empty body should not return empty response * Address cr * V3 Netty ByteBuf, new pipeline and more (#545) * Changing HttpResponse::body() return type to ByteBuf * JDK ByteBuffer to Netty ByteBuf * Incorporating new pipeline * Removing HttpPipelineBuilder and enable var-arg policies for HttpPipeline * Removing inhouse Channel Pool and associated types in favor of reactor-netty's built-in pool * Removing Request::Context in favor of PipelineCallContext::ContextData. Updating RestProxy/SwaggerMethodParser accordingly. * Removing callerMethod property of Request instead storing it as pipelinecallcontext data. * Javadoc updates for set of runtime types * Removing ServiceFuture and ServiceFutureUtil given we support only reactive async programming * Adding the prefix 'Rest' to rest response types * Rename HttpClient::sendRequestAsync to HttpClient::send, Correcting Response::withIsDecoded's return type to Response, Java doc updates for runtime types * Moving policy as a subpackage of http package (to accomodate any future protocol based policies (tcp e.g.) * Removing SerializerAdapter Deprecated methods - serializer(), serialize(Object), deserialize(String, Type). * Removing utility methods for ByteBuffer given we moved to ByteBuf * Moving rx-java2 to test dependency [from compile-time dependency]. * Javadoc updates for set of runtime types * Rename HttpPipeline::sendRequest(args) to HttpPipeline::send(args). * Adding a contract for various paged response * Updating doc in package-info files of runtime packages. * Removing HttpClient Factory, some meaningful renames of types, methods, java-doc update (#546) * Removing HttpClient Factory, Rename NettyClient to ReactorNettyClient, java doc updates * Removing async suffix in some runtime method names. * Decouple HttpResponseDecoder from SwaggerMethodParser, Making Jackson encoders package private, Java-doc updates (#547) * Moving protocol/SerializerAdapter, HttpResponseDecoder to serializer package. * Making all runtime jackson codec types to package private * Improving HttpRrsponseDecoder so that client can easily create one with specific decoding settings, java-doc updates. * Httpbin update (check for https/http), default impl for HttpResponseDecodeData methods (#559) * [test] The protocol part of url property in httpbin response is not consistent with request url, fix:assert for both http and https. The '1.1 vegur' via header is not returned from httpbin anymore. * Adding default impls for methods in HttpResponseDecodeData interface, java-doc for HttpResponseDecoder. * Fixing the regression introduced (due to new MalformedValueException type) in the commit c6945f28534b3c57d261e30505c813114994fb84 * Types for http content and headers lazy deserialization and cleanup (#560) * Introducing types that enables lazy deserialization of http content and headers. * Using Duration instead of (amount, TemporalUnit) in RetryPolicy * Removing SystemOutLogger, HttpClientFactory & AbstractPipelinePolicy. Making ContentType & ReactorNettyClient pkg-private * bringing content-type back to public (need to decide what to do with this type) (#561) * Folding http configuration to HttpClient, Adding HttpResponse::bodyAsString(charset) (#562) * Rename NextPolicy to HttpPipelineNextPolicy. * (new pattern) Folding http configuration to HttpClient. * Adding HttpResponse::bodyAsString(Charset) overload * Upgrading netty version to 4.1.33.Final from 4.1.28.Final (#568) * Renames RestResponse to RestResponseBase, RestContentResponse to RestResponse (#570) * Renaming RestResponse to RestResponseBase. * Renaming RestContentResponse to RestResponse * Renaming generic types in rest response models (TBody -> T, THeaders -> H) * removing custom logger API (#571) * Making HttpMethod native enum (#572) * Making HttpClient interface (#576) * Eventhub-java: integrate event hubs into azure-sdk-for-java repo (#3067) * eventhubs-java: pom and code changes * eventhubs-java: client.test.live.yml updated * LicenseJava: add license info for all java files * PR-3067: Eventhub-java: integrate event hubs into azure-sdk-for-java repo [Follow up] * fix: update jproxy link for unit tests * fix<test-proxy-server>: add external proxy server lib source file for proxy tests * Making PercentEscaper UrlEscapers package private, Removing unused HttpPipelineLogLevel, using Duration in TimeoutPolicy (#578) * Defining better RestResponse type hierarchy (#579) * Integrating new rest response APIs, Refactoring of the RestProxy to adapt this. Adding tests. * Updating CheckStyle dependency on `autorest-build-tools` to v3, 3.0.0-SNAPSHOT. * Adding HttpPipeline::ctr that takes list (#581) * Disabling a failing test and fixing a regression I introduced. (#582) * Refactoring of the client-runtime module (#583) * Introducing implementation package in client-runtime module and moving all eligible types to it. * Improving the javadocs for the types in the annotations package. * Adapting to new package structure. (#586) * Adapting to new package structure. * using azure-common-parent parent artifactId, starting with version 1.0.0-SNAPSHOT * Adding all the existing presence and content issues as known issues. Removing "*/data-plane/*" exception in favor of real issues. Cleaning up `analyze` step of job to remove wonky sudo usage. (#3118) * Generate dependencymanagement report * Upgrade to Checkstyle 8.18 (#3129) * Fixes Checkstyle build errors (#3153) * Add RedundantModifier suppressions for auto-generated files. * Adding suppression for BatchClient because it is shipped. * upgrading jackson version to 2.9.4 (#591) * KeyVault updating versions for release (#3149) * KeyVault updating versions for release * updating missed parent version * EventHubs integration part 1 (#3100) * eventhubs-java: pom and code changes * eventhubs-java: client.test.live.yml updated * LicenseJava: add license info for all java files * PR-3067: Eventhub-java: integrate event hubs into azure-sdk-for-java repo [Follow up] * fix: update jproxy link for unit tests * fix<test-proxy-server>: add external proxy server lib source file for proxy tests * fix<checkstyle>: fixed all indentation errors * fix<checkstyle>: FileTabCharacter rule fixed * fix<checkstyle>: fixed OperatorWrap rule * fix<checkStyle>: fixed AvoidStarImport rule * fix<checkstyle>: WhitespaceAround rule * fix<checkstyle>: NoWhitespaceBefore and WhitespaceAfter rules * fix<checkstyle>: WhitespaceAround rule * fix<checkstyle>: RegexpSingleline rule * fix<checkstyle>: ArrayTypeStyle rule * fix<checkstyle>: NewlineAtEndOfFile rule * fix<checkstyle>: UnusedImports * fix<checkstyle>: ConstantName * fix<checkstyle>: MethodName and StaticVariableName rules * fix<checkstyle>: VisibilityModifier * fix<checkstyle>: EmptyBlock, InnerAssignment * fix<checkstyle>: ModifierOrder * fix<checkstyle>: RedundantModifier * fix<checkstyle-warning>: LeftCurly * fix<revert>: revert client.test.live.yml changes, exclude event hub * fix<checkstyle>: additional 10 Indentation errors * fix<checkstyle, pom>: updates changes for connie's code changes request * test<live-test>: enable live test for eventhubs * fix(CheckStyle): update to latest checkstyle-suppressions that matched spotbugs * EventHubs integration part 2 - spotbugs (#3105) This PR includes fix for SpotBugs and also corrects some CheckStyle errors left from previous PR (EventHubs integration part 1 #3100): * fix<SpotBugs>: all 6 P1 bugs * fix<SpotBugs>: supression and refactor * fix<SpotBugs>: update spotbugs-exclude with comment for EH * refactor(SpotBugs): import static * fix<checkstyle>: access can be package-private * fix<checkstyle>: modifier public is redundant for interface methods * fix<checkstyle>: modifier public is redundant for inner class of interface and modifier static is redundant for inner class of interface and inner enum * fix<checkstyle>: modifier final is redundant for final class * fix(stylecheck): EmptyBlock * fix(CheckStyle): EmptyBlock and ConstantName * fix(CheckStyle): MethodName * fix(CheckStyle): ConstantName * fix(CheckStyle): checkstyle suppressions file * fix(CheckStyle): refactor Inner Assignment * fix(CheckStyle): refactor Empty Block * fix(CheckStyle): update Check Style Suppressions * fix(CheckStyle): after update to checkstyle 8.18, final modifier modifier * docs(CheckStyle): clarity the comment, no functional things involved * Fixes allowing client build pipeline to be run targeting individual client library projects (#3163) * fixing jetty server to be invoked on pom.client.xml rather than the specified pom.xml * fixing Analyze tooling to install from root pom.client.xml * ignore the readme issue * Mixed reality 2019_02, HdInsight 2018_06_01_preview, Storage_2018_11_01, Edgegateway 2019_03_01 container 2019_02_01 and marketplace_ordering 2015_06_01 (#3179) * mixed reality 2019_02 * HDInsight 2018_06_01 preview * container services 2019_02_01 * correcting path to containerservice spec in api-spec.json * storage 2018_11_01 * edgegateway 2019_03_01 * marketplace ordering 2015_06_01 * spec update for marketplace ordering and edge gateway * JavaDoc: remove EPH from Other Packages (#3199) Eventhubs : fixed for JavaDoc * fix(JavaDoc): remove EPH from other packages * Update AsyncServiceClientCredentials to take HttpRequest (#3200) * Update AsyncServiceClientCredentials to take HttpRequest * Add AsyncCredentialsPolicy to common library * Fix editorconfig default settings

Refresh with latest code gen and use spn in tests

166116a

jianghaolu closed this Nov 20, 2015

jianghaolu reopened this Nov 20, 2015

jianghaolu added a commit that referenced this pull request Nov 20, 2015

Merge pull request #559 from jianghaolu/autorest

6433155

Refresh with latest code gen and use spn in tests

jianghaolu merged commit 6433155 into Azure:autorest Nov 20, 2015

azurecla added the cla-not-required label Nov 20, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refresh with latest code gen and use spn in tests #559

Refresh with latest code gen and use spn in tests #559

jianghaolu commented Nov 20, 2015

Refresh with latest code gen and use spn in tests #559

Refresh with latest code gen and use spn in tests #559

Conversation

jianghaolu commented Nov 20, 2015