-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update samples for new Event Hubs core classes #6546
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
conniey
commented
Nov 26, 2019
•
edited
Loading
edited
- Updates a bit of the javadocs in main classes (like the first sentence), but there will be another PR with a closer look at docs.
- Updates all the samples for publishing, consuming, adds sample for azure-identity
conniey
added
Event Hubs
Client
This issue points to a problem in the data-plane of the library.
labels
Nov 26, 2019
srnagar
reviewed
Nov 26, 2019
...-messaging-eventhubs/src/main/java/com/azure/messaging/eventhubs/EventHubConsumerClient.java
Outdated
Show resolved
Hide resolved
...eventhubs/src/samples/java/com/azure/messaging/eventhubs/PublishEventsWithAzureIdentity.java
Outdated
Show resolved
Hide resolved
srnagar
approved these changes
Nov 26, 2019
…e/messaging/eventhubs/EventHubConsumerClient.java Co-Authored-By: Srikanta <51379715+srnagar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.