add support for AuthFileCredential #7552
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luyunmt
requested review from
g2vinay,
hemanttanwar and
jianghaolu
as code owners
jianghaolu
reviewed
Jan 21, 2020
sdk/identity/azure-identity/src/main/java/com/azure/identity/AuthFileCredential.java
Show resolved
Hide resolved
g2vinay
reviewed
Jan 21, 2020
sdk/identity/azure-identity/src/main/java/com/azure/identity/AuthFileCredential.java
Outdated
Show resolved
Hide resolved
sdk/identity/azure-identity/src/main/java/com/azure/identity/AuthFileCredential.java
Outdated
Show resolved
Hide resolved
sdk/identity/azure-identity/src/main/java/com/azure/identity/AuthFileCredential.java
Outdated
Show resolved
Hide resolved
sdk/identity/azure-identity/src/test/java/com/azure/identity/AuthFileCredentialTests.java
Outdated
Show resolved
Hide resolved
ellismg
requested changes
Feb 3, 2020
sdk/identity/azure-identity/src/main/java/com/azure/identity/AuthFileCredential.java
Outdated
Show resolved
Hide resolved
schaabs
reviewed
Feb 4, 2020
sdk/identity/azure-identity/src/main/java/com/azure/identity/AuthFileCredential.java
Outdated
Show resolved
Hide resolved
srnagar
requested changes
Feb 27, 2020
sdk/identity/azure-identity/src/main/java/com/azure/identity/AuthFileCredential.java
Show resolved
Hide resolved
sdk/identity/azure-identity/src/main/java/com/azure/identity/AuthFileCredential.java
Outdated
Show resolved
Hide resolved
sdk/identity/azure-identity/src/main/java/com/azure/identity/AuthFileCredential.java
Outdated
Show resolved
Hide resolved
sdk/identity/azure-identity/src/main/java/com/azure/identity/AuthFileCredential.java
Outdated
Show resolved
Hide resolved
sdk/identity/azure-identity/src/main/java/com/azure/identity/AuthFileCredential.java
Outdated
Show resolved
Hide resolved
sdk/identity/azure-identity/src/main/java/com/azure/identity/ClientSecretCredential.java
Outdated
Show resolved
Hide resolved
Comment on lines
+11
to
+13
| import org.powermock.core.classloader.annotations.PowerMockIgnore; | ||
| import org.powermock.core.classloader.annotations.PrepareForTest; | ||
| import org.powermock.modules.junit4.PowerMockRunner; |
There was a problem hiding this comment.
Try using Mockito and avoid PowerMockito.
There was a problem hiding this comment.
This can be deferred as discussed.
sdk/identity/azure-identity/src/test/java/com/azure/identity/AuthFileCredentialTests.java
Outdated
Show resolved
Hide resolved
| void ensureCredential() { | ||
| if (credential == null) { | ||
| try { | ||
| credential = BuildCredentialForCredentialsFile(ParseCredentialsFile(filepath)); |
There was a problem hiding this comment.
Guard this creation of credential in a multi-threaded environment.
There was a problem hiding this comment.
credential is instance field and method credential.gettoken doesn't change the state of credential,so we don't think it is necessary to take care the multi-threaded environment
sdk/identity/azure-identity/src/main/java/com/azure/identity/AuthFileCredential.java
Outdated
Show resolved
Hide resolved
|
@g2vinay - Can you help us get this approved for April release? |
joshfree
added
Azure.Identity
Client
|
This is on hold for further discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added AuthFileCredential and its tests to azure-identity.
Azure/azure-sdk-for-net#9312