Fix tests

sdk/servicebus/service-bus/test/batchReceiver.spec.ts

@@ -687,7 +687,7 @@ describe("Batch Receiver - Settle deadlettered message", function(): void {
     const deadLetterMsg = await deadLetterMessage(testMessage);
 
     await deadLetterMsg.deadLetter().catch((err) => {
-      should.equal(err.code, "InvalidOperationError", "ErrorName is different than expected");
+      should.equal(err.code, "InvalidOperationError", "Error code is different than expected");
       errorWasThrown = true;
     });
 

sdk/servicebus/service-bus/test/renewLock.spec.ts

@@ -315,7 +315,7 @@ async function testBatchReceiverManualLockRenewalErrorOnLockExpiry(
 
   let errorWasThrown: boolean = false;
   await msgs[0].complete().catch((err) => {
-    should.equal(err.code, "MessageLockLostError", "ErrorName is different than expected");
+    should.equal(err.code, "MessageLockLostError", "Error code is different than expected");
     errorWasThrown = true;
   });
 
@@ -433,7 +433,7 @@ async function testAutoLockRenewalConfigBehavior(
 
       let errorWasThrown: boolean = false;
       await brokeredMessage.complete().catch((err) => {
-        should.equal(err.code, "MessageLockLostError", "ErrorName is different than expected");
+        should.equal(err.code, "MessageLockLostError", "Error code is different than expected");
         errorWasThrown = true;
       });
 

sdk/servicebus/service-bus/test/renewLockSessions.spec.ts

@@ -328,7 +328,7 @@ async function testBatchReceiverManualLockRenewalErrorOnLockExpiry(
 
   let errorWasThrown: boolean = false;
   await msgs[0].complete().catch((err) => {
-    should.equal(err.code, "SessionLockLostError", "ErrorName is different than expected");
+    should.equal(err.code, "SessionLockLostError", "Error code is different than expected");
     errorWasThrown = true;
   });
 
@@ -482,7 +482,7 @@ async function testAutoLockRenewalConfigBehavior(
 
   let errorWasThrown: boolean = false;
   await messagesReceived[0].complete().catch((err) => {
-    should.equal(err.code, "SessionLockLostError", "ErrorName is different than expected");
+    should.equal(err.code, "SessionLockLostError", "Error code is different than expected");
     errorWasThrown = true;
   });
 

sdk/servicebus/service-bus/test/serviceBusClient.spec.ts

@@ -33,11 +33,12 @@ import {
 } from "./utils/testUtils";
 import { ClientType } from "../src/client";
 import { DispositionType } from "../src/serviceBusMessage";
+import { isNode } from "./utils/envVarUtils";
 
 const should = chai.should();
 chai.use(chaiAsPromised);
 
-describe("Create ServiceBusClient and Queue/Topic/Subscription Clients #RunInBrowser", function(): void {
+describe.only("Create ServiceBusClient and Queue/Topic/Subscription Clients #RunInBrowser", function(): void {
   let sbClient: ServiceBusClient;
 
   afterEach(async () => {
@@ -85,7 +86,7 @@ describe("Create ServiceBusClient and Queue/Topic/Subscription Clients #RunInBro
   // });
 });
 
-describe("Errors with non existing Namespace #RunInBrowser", function(): void {
+describe.only("Errors with non existing Namespace #RunInBrowser", function(): void {
   let sbClient: ServiceBusClient;
   let errorWasThrown: boolean;
   beforeEach(() => {
@@ -99,10 +100,11 @@ describe("Errors with non existing Namespace #RunInBrowser", function(): void {
   });
 
   const testError = (err: Error): void => {
+    const expectedErrCode = isNode ? "ENOTFOUND" : "ServiceCommunicationError";
     should.equal(
       (err as MessagingError).code,
-      "ServiceCommunicationError",
-      "ErrorName is different than expected"
+      expectedErrCode,
+      "Error code is different than expected"
     );
     errorWasThrown = true;
   };
@@ -191,7 +193,7 @@ describe("Errors with non existing Namespace #RunInBrowser", function(): void {
   });
 });
 
-describe("Errors with non existing Queue/Topic/Subscription", async function(): Promise<void> {
+describe.only("Errors with non existing Queue/Topic/Subscription", async function(): Promise<void> {
   let sbClient: ServiceBusClient;
   let errorWasThrown: boolean;
   beforeEach(() => {
@@ -206,7 +208,7 @@ describe("Errors with non existing Queue/Topic/Subscription", async function():
     should.equal(
       (err as MessagingError).code,
       "MessagingEntityNotFoundError",
-      "ErrorName is different than expected"
+      "Error code is different than expected"
     );
     should.equal(
       err.message.startsWith(
@@ -318,7 +320,7 @@ describe("Errors with non existing Queue/Topic/Subscription", async function():
   });
 });
 
-// describe("Test createFromAadTokenCredentials", function(): void {
+// describe.only("Test createFromAadTokenCredentials", function(): void {
 //   let sbClient: ServiceBusClient;
 //   let errorWasThrown: boolean = false;
 
@@ -392,7 +394,7 @@ describe("Errors with non existing Queue/Topic/Subscription", async function():
 //   });
 // });
 
-describe("Errors after close()", function(): void {
+describe.only("Errors after close()", function(): void {
   let sbClient: ServiceBusClient;
   let senderClient: QueueClient | TopicClient;
   let receiverClient: QueueClient | SubscriptionClient;
@@ -755,7 +757,7 @@ describe("Errors after close()", function(): void {
     should.equal(errorGetRules, expectedErrorMsg, "Expected error not thrown for getRule()");
   }
 
-  describe("Errors after close() on namespace", function(): void {
+  describe.only("Errors after close() on namespace", function(): void {
     const entityToClose = "namespace";
     const expectedErrorMsg = "The underlying AMQP connection is closed.";
 
@@ -872,7 +874,7 @@ describe("Errors after close()", function(): void {
     });
   });
 
-  describe("Errors after close() on senderClient", function(): void {
+  describe.only("Errors after close() on senderClient", function(): void {
     const entityToClose = "senderClient";
 
     it("Unpartitioned Queue: errors after close() on senderClient #RunInBrowser", async function(): Promise<
@@ -906,7 +908,7 @@ describe("Errors after close()", function(): void {
     });
   });
 
-  describe("Errors after close() on receiverClient", function(): void {
+  describe.only("Errors after close() on receiverClient", function(): void {
     const entityToClose = "receiverClient";
 
     it("Unpartitioned Queue: errors after close() on receiverClient #RunInBrowser", async function(): Promise<
@@ -984,7 +986,7 @@ describe("Errors after close()", function(): void {
     });
   });
 
-  describe("Errors after close() on sender", function(): void {
+  describe.only("Errors after close() on sender", function(): void {
     const entityToClose = "sender";
 
     it("Unpartitioned Queue: errors after close() on sender #RunInBrowser", async function(): Promise<
@@ -1002,7 +1004,7 @@ describe("Errors after close()", function(): void {
     });
   });
 
-  describe("Errors after close() on receiver", function(): void {
+  describe.only("Errors after close() on receiver", function(): void {
     const entityToClose = "receiver";
 
     it("Unpartitioned Queue: errors after close() on receiver #RunInBrowser", async function(): Promise<
@@ -1042,7 +1044,7 @@ describe("Errors after close()", function(): void {
     });
   });
 
-  describe("Errors when creating second sender/receiver with first not closed", function(): void {
+  describe.only("Errors when creating second sender/receiver with first not closed", function(): void {
     it("Open sender exists on QueueClient", async function(): Promise<void> {
       await beforeEachTest(TestClientType.PartitionedQueue, TestClientType.PartitionedQueue, "");
 

sdk/servicebus/service-bus/test/topicFilters.spec.ts

@@ -241,7 +241,7 @@ describe("addRule() #RunInBrowser", function(): void {
       should.equal(
         error.code,
         "MessagingEntityAlreadyExistsError",
-        "ErrorName is different than expected"
+        "Error code is different than expected"
       );
     }
     should.equal(errorWasThrown, true, "Error thrown flag must be true");
@@ -272,7 +272,7 @@ describe("removeRule()", function(): void {
       should.equal(
         error.code,
         "MessagingEntityNotFoundError",
-        "ErrorName is different than expected"
+        "Error code is different than expected"
       );
       errorWasThrown = true;
     }