Skip to content

Commit

Permalink
Remove dependency overrides for Identity (#18474)
Browse files Browse the repository at this point in the history
Related to #14581

In #18463, we updated all samples to use GA of Identity v2
In #18470, we updated devDependencies of Identity v2 beta to use Identity v2 GA

This PR removes the dependency overrides put in place for the reason (am guessing) that we wanted tests to use the beta v2 Identity, but not samples

Now that the samples are using v2, we no longer need the dependency overrides
  • Loading branch information
ramya-rao-a authored Nov 1, 2021
1 parent ae6b6e3 commit 727b2e0
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 9 deletions.
3 changes: 0 additions & 3 deletions sdk/containerregistry/container-registry/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -132,9 +132,6 @@
],
"requiredResources": {
"Azure Container Registry": "https://docs.microsoft.com/azure/container-registry/container-registry-get-started-portal"
},
"dependencyOverrides": {
"@azure/identity": "^1.3.0"
}
}
}
3 changes: 0 additions & 3 deletions sdk/eventhub/event-hubs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,6 @@
]
},
"//sampleConfiguration": {
"dependencyOverrides": {
"@azure/identity": "^1.5.1"
},
"extraFiles": {
"./samples-browser": [
"browser"
Expand Down
3 changes: 0 additions & 3 deletions sdk/servicebus/service-bus/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,6 @@
"requiredResources": {
"Azure Service Bus": "https://docs.microsoft.com/azure/service-bus-messaging"
},
"dependencyOverrides": {
"@azure/identity": "^1.1.0"
},
"skip": [
"receiveMessagesLoop.js",
"receiveMessagesStreaming.js",
Expand Down

0 comments on commit 727b2e0

Please sign in to comment.