bug fixes for correct ISO8601 values for duration aliases

update the version and changelog update api update api view fix tests [engsys] Upgrade dev dependency `dotenv` version to `^16.0.0` for selected packages (#24020) Update eng/common/scripts/get-codeowners.ps1 Update get-codeowners.ps1 update Sync eng/common directory with azure-sdk-tools for PR 5608 (#25133) Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#5608 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow) --------- Co-authored-by: Konrad Jamrozik <kojamroz@microsoft.com> update changelog Update eng/common/scripts/get-codeowners.ps1 update update
Azure · May 8, 2023 · 7db1c94 · 7db1c94
1 parent 935a507
commit 7db1c94
Show file tree

Hide file tree

Showing 10 changed files with 30 additions and 15 deletions.
diff --git a/sdk/monitor/monitor-query/CHANGELOG.md b/sdk/monitor/monitor-query/CHANGELOG.md
@@ -1,13 +1,23 @@
 # Release History
 
+## 1.0.4 (2023-05-05)
+
+### Bugs Fixed
+
+- Fixed the ISO8601 value for `twentyFourHours`to reflect `P24H`, instead of `P1D` under `Durations` object.
+
+### Other Changes
+
+- Added alias `fortyEightHours` for ISO8601 value `P48H` under `Durations` object.
+- Deprecated alias name `fourtyEightHours` and fixed the ISO8601 value  to be `P48H` instead of `P2D` under `Durations` object.
+
 ## 1.1.0-beta.1 (2023-05-02)
 
 ### Features Added
 
 - Added Resource centric query logs api for `LogsIngestionClient`.
 
 ## 1.0.3 (2022-10-05)
-
 ### Bugs Fixed
 
 - #23349 Fixed endpoint resolution to allow endpoints from sovereign clouds

diff --git a/...uery/recordings/browsers/logsqueryclient_live_tests/recording_includequerystatistics.json b/...uery/recordings/browsers/logsqueryclient_live_tests/recording_includequerystatistics.json
diff --git a/...ings/browsers/logsqueryclient_live_tests/recording_includerenderincludevisualization.json b/...ings/browsers/logsqueryclient_live_tests/recording_includerenderincludevisualization.json
diff --git a/...browsers/logsqueryclient_live_tests__server_timeout/recording_servertimeoutinseconds.json b/...browsers/logsqueryclient_live_tests__server_timeout/recording_servertimeoutinseconds.json
diff --git a/...or-query/recordings/node/logsqueryclient_live_tests/recording_includequerystatistics.json b/...or-query/recordings/node/logsqueryclient_live_tests/recording_includequerystatistics.json
diff --git a/...cordings/node/logsqueryclient_live_tests/recording_includerenderincludevisualization.json b/...cordings/node/logsqueryclient_live_tests/recording_includerenderincludevisualization.json
diff --git a/...ngs/node/logsqueryclient_live_tests__server_timeout/recording_servertimeoutinseconds.json b/...ngs/node/logsqueryclient_live_tests__server_timeout/recording_servertimeoutinseconds.json
diff --git a/sdk/monitor/monitor-query/review/monitor-query.api.md b/sdk/monitor/monitor-query/review/monitor-query.api.md
@@ -20,8 +20,9 @@ export const Durations: {
     readonly oneDay: "P1D";
     readonly oneHour: "PT1H";
     readonly fourHours: "PT4H";
-    readonly twentyFourHours: "P1D";
-    readonly fourtyEightHours: "P2D";
+    readonly twentyFourHours: "P24H";
+    readonly fortyEightHours: "P48H";
+    readonly fourtyEightHours: "P48H";
     readonly thirtyMinutes: "PT30M";
     readonly fiveMinutes: "PT5M";
 };

diff --git a/sdk/monitor/monitor-query/src/models/constants.ts b/sdk/monitor/monitor-query/src/models/constants.ts
@@ -17,10 +17,14 @@ export const Durations = {
   oneHour: "PT1H",
   /** Alias for ISO8601 value 'PT4H' */
   fourHours: "PT4H",
-  /** Alias for ISO8601 value 'P1D' */
-  twentyFourHours: "P1D",
-  /** Alias for ISO8601 value 'P2D' */
-  fourtyEightHours: "P2D",
+  /** Alias for ISO8601 value 'P24H' */
+  twentyFourHours: "P24H",
+  /** Alias for ISO8601 value 'P48H' */
+  fortyEightHours: "P48H",
+  /**
+   * @deprecated Alias name `fourtyEightHours` for ISO8601 value 'P48H' is deprecated
+   */
+  fourtyEightHours: "P48H",
   /** Alias for ISO8601 value 'PT30M' */
   thirtyMinutes: "PT30M",
   /** Alias for ISO8601 value 'PT5M' */

diff --git a/sdk/monitor/monitor-query/test/public/metricsQueryClient.spec.ts b/sdk/monitor/monitor-query/test/public/metricsQueryClient.spec.ts
@@ -69,7 +69,7 @@ describe("MetricsClient live tests", function () {
       if (i % 20 === 0 || i === metricDefinitionsLength) {
         const newResults = await metricsQueryClient.queryResource(resourceId, definitionNames, {
           timespan: {
-            duration: Durations.twentyFourHours,
+            duration: Durations.oneDay,
           },
         });
         assert.ok(newResults);
@@ -87,7 +87,7 @@ describe("MetricsClient live tests", function () {
       resourceId,
       [firstResult.name!],
       {
-        timespan: { duration: Durations.twentyFourHours },
+        timespan: { duration: Durations.oneDay },
         metricNamespace: firstResult.namespace,
       }
     );