[monitor] Fix some of the more obvious breakages (CI is still broken …

…afterwards, however) (#13881) (NOTE: CI is still broken as we have to investigate the rest of the breakages in the test) * Problem #1 - the underlying value has changed (it used to be a CanonicalCode.OK (0) but now is StatusCode.OK (1)). * Fixing issue where the test failing wasn't actually passed on to the test framework.
Azure · Feb 19, 2021 · 8a86351 · 8a86351
1 parent 4a6bb5c
commit 8a86351
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/sdk/monitor/monitor-opentelemetry-exporter/test/common/scenario/basic.ts b/sdk/monitor/monitor-opentelemetry-exporter/test/common/scenario/basic.ts
@@ -91,7 +91,7 @@ export class BasicScenario implements Scenario {
           version: 1,
           name: "BasicScenario.Root",
           duration: msToTimeSpan(600),
-          responseCode: "0",
+          responseCode: SpanStatusCode.OK.toString(),
           success: true,
           properties: {
             foo: "bar"
@@ -108,7 +108,7 @@ export class BasicScenario implements Scenario {
               name: "BasicScenario.Child.1",
               duration: msToTimeSpan(100),
               success: true,
-              resultCode: "0",
+              resultCode: SpanStatusCode.OK.toString(),
               properties: {
                 numbers: "123"
               }
@@ -125,7 +125,7 @@ export class BasicScenario implements Scenario {
               name: "BasicScenario.Child.2",
               duration: msToTimeSpan(100),
               success: true,
-              resultCode: "0",
+              resultCode: SpanStatusCode.OK.toString(),
               properties: {
                 numbers: "1234"
               }

diff --git a/sdk/monitor/monitor-opentelemetry-exporter/test/functional/trace.test.ts b/sdk/monitor/monitor-opentelemetry-exporter/test/functional/trace.test.ts
@@ -46,7 +46,7 @@ describe("Trace Exporter Scenarios", () => {
           });
         })
         .catch((e) => {
-          throw e;
+          done(e);
         });
     });
   });
-Original file line number
+Diff line change
@@ Expand Up / @@ -46,7 +46,7 @@ describe("Trace Exporter Scenarios", () => { @@
               });
             })
             .catch((e) => {
-              throw e;
+              done(e);
             });
         });
       });
@@ Expand Down @@