Add tracing to storage-file (#5363)

Adds a dependency on @azure/core-tracing from storage-file and makes it possible to pass a parent `Span` to public facing operations.
Azure · Oct 4, 2019 · c100951 · c100951
1 parent e289dba
commit c100951
Show file tree

Hide file tree

Showing 14 changed files with 2,281 additions and 691 deletions.
diff --git a/sdk/storage/storage-file/package.json b/sdk/storage/storage-file/package.json
@@ -81,6 +81,7 @@
     "@azure/abort-controller": "1.0.0-preview.2",
     "@azure/core-http": "1.0.0-preview.3",
     "@azure/core-paging": "1.0.0-preview.2",
+    "@azure/core-tracing": "1.0.0-preview.3",
     "events": "^3.0.0",
     "tslib": "^1.9.3"
   },

diff --git a/...recordings/browsers/directoryclient/recording_createfile_and_deletefile_with_tracing.json b/...recordings/browsers/directoryclient/recording_createfile_and_deletefile_with_tracing.json
@@ -0,0 +1,210 @@
+{
+ "recordings": [
+  {
+   "method": "PUT",
+   "url": "https://fakestorageaccount.file.core.windows.net/share157008902598508682",
+   "query": {
+    "restype": "share"
+   },
+   "requestBody": null,
+   "status": 201,
+   "response": "",
+   "responseHeaders": {
+    "date": "Thu, 03 Oct 2019 07:50:25 GMT",
+    "last-modified": "Thu, 03 Oct 2019 07:50:25 GMT",
+    "server": "Windows-Azure-File/1.0 Microsoft-HTTPAPI/2.0",
+    "etag": "\"0x8D747D65A44649F\"",
+    "x-ms-request-id": "127353d9-401a-00dc-76bf-795253000000",
+    "x-ms-version": "2019-02-02",
+    "x-ms-client-request-id": "23fd9509-a948-480f-9459-1083ef4991ef",
+    "content-length": "0"
+   }
+  },
+  {
+   "method": "PUT",
+   "url": "https://fakestorageaccount.file.core.windows.net/share157008902598508682/dir157008902641103201",
+   "query": {
+    "restype": "directory"
+   },
+   "requestBody": null,
+   "status": 201,
+   "response": "",
+   "responseHeaders": {
+    "date": "Thu, 03 Oct 2019 07:50:25 GMT",
+    "x-ms-file-change-time": "2019-10-03T07:50:26.0424091Z",
+    "x-ms-file-attributes": "Directory",
+    "x-ms-file-id": "13835128424026341376",
+    "x-ms-request-server-encrypted": "true",
+    "x-ms-file-creation-time": "2019-10-03T07:50:26.0424091Z",
+    "x-ms-file-parent-id": "0",
+    "x-ms-file-permission-key": "10601938801812273194*18156966929047809955",
+    "x-ms-client-request-id": "922c5e1e-9c6b-47b5-94ac-39d48c77b4b7",
+    "content-length": "0",
+    "last-modified": "Thu, 03 Oct 2019 07:50:26 GMT",
+    "server": "Windows-Azure-File/1.0 Microsoft-HTTPAPI/2.0",
+    "etag": "\"0x8D747D65A56C59B\"",
+    "x-ms-request-id": "127353dc-401a-00dc-78bf-795253000000",
+    "x-ms-file-last-write-time": "2019-10-03T07:50:26.0424091Z",
+    "x-ms-version": "2019-02-02"
+   }
+  },
+  {
+   "method": "PUT",
+   "url": "https://fakestorageaccount.file.core.windows.net/share157008902598508682/dir157008902641103201/directory157008902652205219",
+   "query": {
+    "restype": "directory"
+   },
+   "requestBody": null,
+   "status": 201,
+   "response": "",
+   "responseHeaders": {
+    "date": "Thu, 03 Oct 2019 07:50:26 GMT",
+    "x-ms-file-change-time": "2019-10-03T07:50:26.1604916Z",
+    "x-ms-file-attributes": "Directory",
+    "x-ms-file-id": "11529285414812647424",
+    "x-ms-request-server-encrypted": "true",
+    "x-ms-file-creation-time": "2019-10-03T07:50:26.1604916Z",
+    "x-ms-file-parent-id": "13835128424026341376",
+    "x-ms-file-permission-key": "10601938801812273194*18156966929047809955",
+    "x-ms-client-request-id": "7af0d550-aed6-4794-80b0-1b65c9dbb589",
+    "content-length": "0",
+    "last-modified": "Thu, 03 Oct 2019 07:50:26 GMT",
+    "server": "Windows-Azure-File/1.0 Microsoft-HTTPAPI/2.0",
+    "etag": "\"0x8D747D65A68CA34\"",
+    "x-ms-request-id": "127353de-401a-00dc-7abf-795253000000",
+    "x-ms-file-last-write-time": "2019-10-03T07:50:26.1604916Z",
+    "x-ms-version": "2019-02-02"
+   }
+  },
+  {
+   "method": "PUT",
+   "url": "https://fakestorageaccount.file.core.windows.net/share157008902598508682/dir157008902641103201/directory157008902652205219/file157008902663800316",
+   "query": {},
+   "requestBody": null,
+   "status": 201,
+   "response": "",
+   "responseHeaders": {
+    "date": "Thu, 03 Oct 2019 07:50:26 GMT",
+    "x-ms-file-change-time": "2019-10-03T07:50:26.2705685Z",
+    "x-ms-file-attributes": "Archive",
+    "x-ms-file-id": "16140971433240035328",
+    "x-ms-request-server-encrypted": "true",
+    "x-ms-file-creation-time": "2019-10-03T07:50:26.2705685Z",
+    "x-ms-file-parent-id": "11529285414812647424",
+    "x-ms-file-permission-key": "6006229023213291309*18156966929047809955",
+    "x-ms-client-request-id": "cacbbb51-e1c6-4d46-bf9f-7757eb338958",
+    "content-length": "0",
+    "last-modified": "Thu, 03 Oct 2019 07:50:26 GMT",
+    "server": "Windows-Azure-File/1.0 Microsoft-HTTPAPI/2.0",
+    "etag": "\"0x8D747D65A799615\"",
+    "x-ms-request-id": "127353e0-401a-00dc-7cbf-795253000000",
+    "x-ms-file-last-write-time": "2019-10-03T07:50:26.2705685Z",
+    "x-ms-version": "2019-02-02"
+   }
+  },
+  {
+   "method": "HEAD",
+   "url": "https://fakestorageaccount.file.core.windows.net/share157008902598508682/dir157008902641103201/directory157008902652205219/file157008902663800316",
+   "query": {},
+   "requestBody": null,
+   "status": 200,
+   "response": "",
+   "responseHeaders": {
+    "date": "Thu, 03 Oct 2019 07:50:26 GMT",
+    "last-modified": "Thu, 03 Oct 2019 07:50:26 GMT",
+    "x-ms-file-attributes": "Archive",
+    "x-ms-file-id": "16140971433240035328",
+    "x-ms-server-encrypted": "true",
+    "x-ms-file-creation-time": "2019-10-03T07:50:26.2705685Z",
+    "x-ms-file-parent-id": "11529285414812647424",
+    "x-ms-file-permission-key": "6006229023213291309*18156966929047809955",
+    "x-ms-client-request-id": "2206054b-9fc0-4932-9a54-51e9a33ba89c",
+    "x-ms-type": "File",
+    "content-length": "256",
+    "x-ms-meta-key": "value",
+    "x-ms-file-change-time": "2019-10-03T07:50:26.2705685Z",
+    "server": "Windows-Azure-File/1.0 Microsoft-HTTPAPI/2.0",
+    "etag": "\"0x8D747D65A799615\"",
+    "content-type": "application/octet-stream",
+    "x-ms-request-id": "127353e2-401a-00dc-7ebf-795253000000",
+    "x-ms-file-last-write-time": "2019-10-03T07:50:26.2705685Z",
+    "x-ms-version": "2019-02-02"
+   }
+  },
+  {
+   "method": "DELETE",
+   "url": "https://fakestorageaccount.file.core.windows.net/share157008902598508682/dir157008902641103201/directory157008902652205219/file157008902663800316",
+   "query": {},
+   "requestBody": null,
+   "status": 202,
+   "response": "",
+   "responseHeaders": {
+    "date": "Thu, 03 Oct 2019 07:50:26 GMT",
+    "server": "Windows-Azure-File/1.0 Microsoft-HTTPAPI/2.0",
+    "x-ms-request-id": "127353e5-401a-00dc-80bf-795253000000",
+    "x-ms-version": "2019-02-02",
+    "x-ms-client-request-id": "c1d7b71a-05fc-4377-a9f1-cb4d2c35d22c",
+    "content-length": "0"
+   }
+  },
+  {
+   "method": "HEAD",
+   "url": "https://fakestorageaccount.file.core.windows.net/share157008902598508682/dir157008902641103201/directory157008902652205219/file157008902663800316",
+   "query": {},
+   "requestBody": null,
+   "status": 404,
+   "response": "",
+   "responseHeaders": {
+    "date": "Thu, 03 Oct 2019 07:50:26 GMT",
+    "server": "Windows-Azure-File/1.0 Microsoft-HTTPAPI/2.0",
+    "x-ms-error-code": "ResourceNotFound",
+    "transfer-encoding": "chunked",
+    "x-ms-request-id": "127353e7-401a-00dc-02bf-795253000000",
+    "x-ms-version": "2019-02-02",
+    "x-ms-client-request-id": "a8607656-ca13-4bc2-adc3-81d873a074a7"
+   }
+  },
+  {
+   "method": "DELETE",
+   "url": "https://fakestorageaccount.file.core.windows.net/share157008902598508682/dir157008902641103201/directory157008902652205219",
+   "query": {
+    "restype": "directory"
+   },
+   "requestBody": null,
+   "status": 202,
+   "response": "",
+   "responseHeaders": {
+    "date": "Thu, 03 Oct 2019 07:50:26 GMT",
+    "server": "Windows-Azure-File/1.0 Microsoft-HTTPAPI/2.0",
+    "x-ms-request-id": "127353ea-401a-00dc-04bf-795253000000",
+    "x-ms-version": "2019-02-02",
+    "x-ms-client-request-id": "b9b1b51e-8d70-4745-b95c-df4226365074",
+    "content-length": "0"
+   }
+  },
+  {
+   "method": "DELETE",
+   "url": "https://fakestorageaccount.file.core.windows.net/share157008902598508682",
+   "query": {
+    "restype": "share"
+   },
+   "requestBody": null,
+   "status": 202,
+   "response": "",
+   "responseHeaders": {
+    "date": "Thu, 03 Oct 2019 07:50:26 GMT",
+    "server": "Windows-Azure-File/1.0 Microsoft-HTTPAPI/2.0",
+    "x-ms-request-id": "127353ec-401a-00dc-06bf-795253000000",
+    "x-ms-version": "2019-02-02",
+    "x-ms-client-request-id": "c73c326b-ab19-4573-bfe7-324bc405abf3",
+    "content-length": "0"
+   }
+  }
+ ],
+ "uniqueTestInfo": {
+  "share": "share157008902598508682",
+  "dir": "dir157008902641103201",
+  "directory": "directory157008902652205219",
+  "file": "file157008902663800316"
+ }
+}
diff --git a/sdk/storage/storage-file/recordings/browsers/fileclient/recording_create_with_tracing.json b/sdk/storage/storage-file/recordings/browsers/fileclient/recording_create_with_tracing.json
@@ -0,0 +1,101 @@
+{
+ "recordings": [
+  {
+   "method": "PUT",
+   "url": "https://fakestorageaccount.file.core.windows.net/share157008773128100374",
+   "query": {
+    "restype": "share"
+   },
+   "requestBody": null,
+   "status": 201,
+   "response": "",
+   "responseHeaders": {
+    "date": "Thu, 03 Oct 2019 07:28:50 GMT",
+    "last-modified": "Thu, 03 Oct 2019 07:28:51 GMT",
+    "server": "Windows-Azure-File/1.0 Microsoft-HTTPAPI/2.0",
+    "etag": "\"0x8D747D356851B72\"",
+    "x-ms-request-id": "9107613d-c01a-007b-12bc-79ba91000000",
+    "x-ms-version": "2019-02-02",
+    "x-ms-client-request-id": "a4b94f83-271f-46fb-adaa-904cd58df677",
+    "content-length": "0"
+   }
+  },
+  {
+   "method": "PUT",
+   "url": "https://fakestorageaccount.file.core.windows.net/share157008773128100374/dir157008773165503232",
+   "query": {
+    "restype": "directory"
+   },
+   "requestBody": null,
+   "status": 201,
+   "response": "",
+   "responseHeaders": {
+    "date": "Thu, 03 Oct 2019 07:28:50 GMT",
+    "x-ms-file-change-time": "2019-10-03T07:28:51.2995150Z",
+    "x-ms-file-attributes": "Directory",
+    "x-ms-file-id": "13835128424026341376",
+    "x-ms-request-server-encrypted": "true",
+    "x-ms-file-creation-time": "2019-10-03T07:28:51.2995150Z",
+    "x-ms-file-parent-id": "0",
+    "x-ms-file-permission-key": "10601938801812273194*18156966929047809955",
+    "x-ms-client-request-id": "63ec792d-796d-4ed1-a0d4-e34d6e7c3735",
+    "content-length": "0",
+    "last-modified": "Thu, 03 Oct 2019 07:28:51 GMT",
+    "server": "Windows-Azure-File/1.0 Microsoft-HTTPAPI/2.0",
+    "etag": "\"0x8D747D3569CAF4E\"",
+    "x-ms-request-id": "91076140-c01a-007b-14bc-79ba91000000",
+    "x-ms-file-last-write-time": "2019-10-03T07:28:51.2995150Z",
+    "x-ms-version": "2019-02-02"
+   }
+  },
+  {
+   "method": "PUT",
+   "url": "https://fakestorageaccount.file.core.windows.net/share157008773128100374/dir157008773165503232/file157008773176801350",
+   "query": {},
+   "requestBody": null,
+   "status": 201,
+   "response": "",
+   "responseHeaders": {
+    "date": "Thu, 03 Oct 2019 07:28:51 GMT",
+    "x-ms-file-change-time": "2019-10-03T07:28:51.4316073Z",
+    "x-ms-file-attributes": "Archive",
+    "x-ms-file-id": "11529285414812647424",
+    "x-ms-request-server-encrypted": "true",
+    "x-ms-file-creation-time": "2019-10-03T07:28:51.4316073Z",
+    "x-ms-file-parent-id": "13835128424026341376",
+    "x-ms-file-permission-key": "6006229023213291309*18156966929047809955",
+    "x-ms-client-request-id": "3d28f40c-45cc-4378-b524-fe38a4da3f9b",
+    "content-length": "0",
+    "last-modified": "Thu, 03 Oct 2019 07:28:51 GMT",
+    "server": "Windows-Azure-File/1.0 Microsoft-HTTPAPI/2.0",
+    "etag": "\"0x8D747D356B0D729\"",
+    "x-ms-request-id": "91076142-c01a-007b-16bc-79ba91000000",
+    "x-ms-file-last-write-time": "2019-10-03T07:28:51.4316073Z",
+    "x-ms-version": "2019-02-02"
+   }
+  },
+  {
+   "method": "DELETE",
+   "url": "https://fakestorageaccount.file.core.windows.net/share157008773128100374",
+   "query": {
+    "restype": "share"
+   },
+   "requestBody": null,
+   "status": 202,
+   "response": "",
+   "responseHeaders": {
+    "date": "Thu, 03 Oct 2019 07:28:51 GMT",
+    "server": "Windows-Azure-File/1.0 Microsoft-HTTPAPI/2.0",
+    "x-ms-request-id": "91076144-c01a-007b-18bc-79ba91000000",
+    "x-ms-version": "2019-02-02",
+    "x-ms-client-request-id": "f8d7dea4-1723-4d5c-80fc-4119c4770d68",
+    "content-length": "0"
+   }
+  }
+ ],
+ "uniqueTestInfo": {
+  "share": "share157008773128100374",
+  "dir": "dir157008773165503232",
+  "file": "file157008773176801350"
+ }
+}