[Communication]: Always use x-ms-date for Hmac (#15807)

* Always use x-ms-date for Hmac * Try to fix phone number tests * Still another error in phone number tests * Update phoneNumber session records * Update phone numbers node sessions * Manually fix node record sessions for phone numbers * Update missed session files Co-authored-by: JP Chen <jiach@microsoft.com>
Azure · Jun 18, 2021 · ddf4714 · ddf4714
1 parent 1d0b3dd
commit ddf4714
Show file tree

Hide file tree

Showing 37 changed files with 931 additions and 1,059 deletions.
diff --git a/...mmunication/communication-common/src/credential/communicationAccessKeyCredentialPolicy.ts b/...mmunication/communication-common/src/credential/communicationAccessKeyCredentialPolicy.ts
@@ -58,7 +58,7 @@ class CommunicationAccessKeyCredentialPolicy extends BaseRequestPolicy {
     const verb = webResource.method.toUpperCase();
     const utcNow = new Date().toUTCString();
     const contentHash = await shaHash(webResource.body || "");
-    const dateHeader = isNode ? "date" : "x-ms-date";
+    const dateHeader = "x-ms-date";
     const signedHeaders = `${dateHeader};host;x-ms-content-sha256`;
 
     const url = URLBuilder.parse(webResource.url);

diff --git a/...mmunication/communication-identity/test/public/communicationIdentityClient.mocked.spec.ts b/...mmunication/communication-identity/test/public/communicationIdentityClient.mocked.spec.ts
@@ -13,7 +13,7 @@ import { TestCommunicationIdentityClient } from "./utils/testCommunicationIdenti
 import { exchangeTeamsTokenHttpClient, getTokenHttpClient } from "./utils/mockHttpClients";
 
 describe("CommunicationIdentityClient [Mocked]", () => {
-  const dateHeader = isNode ? "date" : "x-ms-date";
+  const dateHeader = "x-ms-date";
   const user: CommunicationUserIdentifier = { communicationUserId: "ACS_ID" };
 
   afterEach(() => {

diff --git a/...sers/phonenumbersclient__get_phone_number/recording_can_get_a_purchased_phone_number.json b/...sers/phonenumbersclient__get_phone_number/recording_can_get_a_purchased_phone_number.json
diff --git a/...sers/phonenumbersclient__get_phone_number/recording_errors_if_phone_number_not_found.json b/...sers/phonenumbersclient__get_phone_number/recording_errors_if_phone_number_not_found.json
diff --git a/.../phonenumbersclient__get_phone_number_aad/recording_can_get_a_purchased_phone_number.json b/.../phonenumbersclient__get_phone_number_aad/recording_can_get_a_purchased_phone_number.json
diff --git a/.../phonenumbersclient__get_phone_number_aad/recording_errors_if_phone_number_not_found.json b/.../phonenumbersclient__get_phone_number_aad/recording_errors_if_phone_number_not_found.json
diff --git a/...gs/browsers/phonenumbersclient__lists/recording_can_list_all_purchased_phone_numbers.json b/...gs/browsers/phonenumbersclient__lists/recording_can_list_all_purchased_phone_numbers.json