[communication] use correct connection string env var (#14220)

Azure · Mar 10, 2021 · f858ce0 · f858ce0
1 parent f1dc4f7
commit f858ce0
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/sdk/communication/communication-phone-numbers/karma.conf.js b/sdk/communication/communication-phone-numbers/karma.conf.js
@@ -58,7 +58,7 @@ module.exports = function(config) {
     // https://www.npmjs.com/package/karma-env-preprocessor
     envPreprocessor: [
       "TEST_MODE",
-      "COMMUNICATION_CONNECTION_STRING",
+      "AZURE_COMMUNICATION_LIVETEST_CONNECTION_STRING",
       "INCLUDE_PHONENUMBER_LIVE_TESTS",
       "AZURE_PHONE_NUMBER",
       "COMMUNICATION_ENDPOINT"

diff --git a/sdk/communication/communication-phone-numbers/sample.env b/sdk/communication/communication-phone-numbers/sample.env
@@ -1,6 +1,6 @@
 # Used in most samples. Retrieve these values from a Communication Services resource
 # in the Azure Portal.
-COMMUNICATION_CONNECTION_STRING="endpoint=<endpoint>;accessKey=<accessKey>"
+AZURE_COMMUNICATION_LIVETEST_CONNECTION_STRING="endpoint=<endpoint>;accessKey=<accessKey>"
 
 # Our tests assume that TEST_MODE is "playback" by default. You can
 # change it to "record" to generate new recordings, or "live" to bypass the recorder entirely.

diff --git a/sdk/communication/communication-phone-numbers/test/utils/recordedClient.ts b/sdk/communication/communication-phone-numbers/test/utils/recordedClient.ts
@@ -26,7 +26,7 @@ export interface RecordedClient<T> {
 }
 
 const replaceableVariables: { [k: string]: string } = {
-  COMMUNICATION_CONNECTION_STRING: "endpoint=https://endpoint/;accesskey=banana",
+  AZURE_COMMUNICATION_LIVETEST_CONNECTION_STRING: "endpoint=https://endpoint/;accesskey=banana",
   INCLUDE_PHONENUMBER_LIVE_TESTS: "false",
   COMMUNICATION_ENDPOINT: "https://endpoint/",
   AZURE_CLIENT_ID: "SomeClientId",
@@ -54,7 +54,7 @@ export function createRecordedClient(
   const recorder = record(context, environmentSetup);
 
   return {
-    client: new PhoneNumbersClient(env.COMMUNICATION_CONNECTION_STRING),
+    client: new PhoneNumbersClient(env.AZURE_COMMUNICATION_LIVETEST_CONNECTION_STRING),
     recorder,
     includePhoneNumberLiveTests: env.INCLUDE_PHONENUMBER_LIVE_TESTS == "true"
   };
@@ -69,7 +69,8 @@ export function createRecordedClientWithToken(
   | undefined {
   const recorder = record(context, environmentSetup);
   let credential: TokenCredential;
-  const endpoint = parseConnectionString(env.COMMUNICATION_CONNECTION_STRING).endpoint;
+  const endpoint = parseConnectionString(env.AZURE_COMMUNICATION_LIVETEST_CONNECTION_STRING)
+    .endpoint;
   if (isPlaybackMode()) {
     credential = {
       getToken: async (_scopes) => {