Unblock react native support when using corev2 packages (#17783)

~This is a WIP. Currently these changes, along with a shims file, allows our packages that depend on core-client to run in react native.~ ~ToDo: I've created expo and react-native cli projects that illustrate what shims are needed to get this working. Currently working on getting those samples into this PR.~ This PR has been updated to just include making the changes needed for the corev2 packages to run in react native, assuming that the requisite browser APIs are pollyfilled.
Azure · Sep 29, 2021 · fd3faee · fd3faee
1 parent 5d9f840
commit fd3faee
Show file tree

Hide file tree

Showing 17 changed files with 65 additions and 1 deletion.
diff --git a/sdk/core/core-client-paging-rest/CHANGELOG.md b/sdk/core/core-client-paging-rest/CHANGELOG.md
@@ -10,6 +10,8 @@
 
 ### Other Changes
 
+- Updates package to work with the react native bundler. Browser APIs may still need to be pollyfilled for this package to run in react native. [PR #17783](https://github.com/Azure/azure-sdk-for-js/pull/17783)
+
 ## 1.0.0-beta.1 (2021-08-05)
 
 - First release of package, see README.md for details.
diff --git a/sdk/core/core-client-paging-rest/package.json b/sdk/core/core-client-paging-rest/package.json
@@ -9,6 +9,9 @@
   "browser": {
     "./dist-esm/src/url.js": "./dist-esm/src/url.browser.js"
   },
+  "react-native": {
+    "./dist/index.js": "./dist-esm/src/index.js"
+  },
   "scripts": {
     "audit": "node ../../../common/scripts/rush-audit.js && rimraf node_modules package-lock.json && npm i --package-lock-only 2>&1 && npm audit",
     "build:samples": "echo Obsolete",

diff --git a/sdk/core/core-client/CHANGELOG.md b/sdk/core/core-client/CHANGELOG.md
@@ -10,6 +10,8 @@
 
 ### Other Changes
 
+- Updates package to work with the react native bundler. Browser APIs may still need to be pollyfilled for this package to run in react native. [PR #17783](https://github.com/Azure/azure-sdk-for-js/pull/17783)
+
 ## 1.3.0 (2021-08-04)
 
 ### Features Added

diff --git a/sdk/core/core-client/package.json b/sdk/core/core-client/package.json
@@ -8,6 +8,9 @@
   "browser": {
     "./dist-esm/src/base64.js": "./dist-esm/src/base64.browser.js"
   },
+  "react-native": {
+    "./dist/index.js": "./dist-esm/src/index.js"
+  },
   "types": "types/latest/core-client.d.ts",
   "typesVersions": {
     "<3.6": {

diff --git a/sdk/core/core-crypto/package.json b/sdk/core/core-crypto/package.json
@@ -8,6 +8,9 @@
   "browser": {
     "./dist-esm/src/sha256.js": "./dist-esm/src/sha256.browser.js"
   },
+  "react-native": {
+    "./dist/index.js": "./dist-esm/src/index.js"
+  },
   "types": "types/latest/core-crypto.d.ts",
   "typesVersions": {
     "<3.6": {

diff --git a/sdk/core/core-crypto/src/sha256.browser.ts b/sdk/core/core-crypto/src/sha256.browser.ts
@@ -67,7 +67,7 @@ export async function computeSha256Hash(
   encoding: "base64" | "hex"
 ): Promise<string> {
   const contentBytes = utf8ToBytes(content);
-  const digest = await getCrypto().digest("SHA-256", contentBytes);
+  const digest = await getCrypto().digest({ name: "SHA-256" }, contentBytes);
 
   switch (encoding) {
     case "base64":

diff --git a/sdk/core/core-lro/CHANGELOG.md b/sdk/core/core-lro/CHANGELOG.md
@@ -12,6 +12,8 @@
 
 ### Other Changes
 
+- Updates package to work with the react native bundler. [PR #17783](https://github.com/Azure/azure-sdk-for-js/pull/17783)
+
 ## 2.2.0 (2021-08-05)
 
 ### Features Added

diff --git a/sdk/core/core-lro/package.json b/sdk/core/core-lro/package.json
@@ -41,6 +41,9 @@
     "os": false,
     "process": false
   },
+  "react-native": {
+    "./dist/index.js": "./dist-esm/src/index.js"
+  },
   "license": "MIT",
   "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/core/core-lro/README.md",
   "repository": "github:Azure/azure-sdk-for-js",

diff --git a/sdk/core/core-rest-pipeline/CHANGELOG.md b/sdk/core/core-rest-pipeline/CHANGELOG.md
@@ -10,6 +10,8 @@
 
 ### Other Changes
 
+- Updates package to work with the react native bundler. Browser APIs such as `URL` will still need to be pollyfilled for this package to run in react native. [PR #17783](https://github.com/Azure/azure-sdk-for-js/pull/17783)
+
 ## 1.3.0 (2021-09-02)
 
 ### Bugs Fixed

diff --git a/sdk/core/core-rest-pipeline/package.json b/sdk/core/core-rest-pipeline/package.json
@@ -14,6 +14,10 @@
     "./dist-esm/src/util/url.js": "./dist-esm/src/util/url.browser.js",
     "./dist-esm/src/util/userAgentPlatform.js": "./dist-esm/src/util/userAgentPlatform.browser.js"
   },
+  "react-native": {
+    "./dist/index.js": "./dist-esm/src/index.js",
+    "./dist-esm/src/util/userAgentPlatform.js": "./dist-esm/src/util/userAgentPlatform.native.js"
+  },
   "types": "core-rest-pipeline.shims.d.ts",
   "typesVersions": {
     "<3.6": {

diff --git a/sdk/core/core-rest-pipeline/src/util/userAgentPlatform.native.ts b/sdk/core/core-rest-pipeline/src/util/userAgentPlatform.native.ts
@@ -0,0 +1,23 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT license.
+
+/*
+ * NOTE: When moving this file, please update "react-native" section in package.json.
+ */
+
+/**
+ * @internal
+ */
+export function getHeaderName(): string {
+  return "x-ms-useragent";
+}
+
+/**
+ * @internal
+ */
+export function setPlatformSpecificData(map: Map<string, string>): void {
+  // TODO: Investigate using `import { Platform } from "react-native"` to get "OS" and "Version".
+  // This may bring in a lot of overhead if we have to use this package directly, perhaps we can shim
+  // types.
+  map.set("OS", `react-native`);
+}
diff --git a/sdk/core/core-tracing/CHANGELOG.md b/sdk/core/core-tracing/CHANGELOG.md
@@ -13,6 +13,8 @@
 
 ### Other Changes
 
+- Updates package to work with the react native bundler. [PR #17783](https://github.com/Azure/azure-sdk-for-js/pull/17783)
+
 ## 1.0.0-preview.13 (2021-07-15)
 
 ### Features Added

diff --git a/sdk/core/core-tracing/package.json b/sdk/core/core-tracing/package.json
@@ -8,6 +8,9 @@
   "browser": {
     "./dist-esm/src/utils/global.js": "./dist-esm/src/utils/global.browser.js"
   },
+  "react-native": {
+    "./dist/index.js": "./dist-esm/src/index.js"
+  },
   "types": "types/core-tracing.d.ts",
   "scripts": {
     "audit": "node ../../../common/scripts/rush-audit.js && rimraf node_modules package-lock.json && npm i --package-lock-only 2>&1 && npm audit",

diff --git a/sdk/core/core-util/CHANGELOG.md b/sdk/core/core-util/CHANGELOG.md
@@ -2,6 +2,9 @@
 
 ## 1.0.0-beta.2 (Unreleased)
 
+### Other Changes
+
+- Updates package to work with the react native bundler. [PR #17783](https://github.com/Azure/azure-sdk-for-js/pull/17783)
 
 ## 1.0.0-beta.1 (2021-05-06)
 

diff --git a/sdk/core/core-util/package.json b/sdk/core/core-util/package.json
@@ -8,6 +8,9 @@
   "browser": {
     "./dist-esm/src/isNode.js": "./dist-esm/src/isNode.browser.js"
   },
+  "react-native": {
+    "./dist/index.js": "./dist-esm/src/index.js"
+  },
   "types": "types/latest/core-util.d.ts",
   "typesVersions": {
     "<3.6": {

diff --git a/sdk/core/logger/CHANGELOG.md b/sdk/core/logger/CHANGELOG.md
@@ -2,6 +2,9 @@
 
 ## 1.0.3 (Unreleased)
 
+### Other Changes
+
+- Updates package to work with the react native bundler. [PR #17783](https://github.com/Azure/azure-sdk-for-js/pull/17783)
 
 ## 1.0.2 (2021-03-04)
 

diff --git a/sdk/core/logger/package.json b/sdk/core/logger/package.json
@@ -9,6 +9,9 @@
     "./dist-esm/src/log.js": "./dist-esm/src/log.browser.js",
     "process": false
   },
+  "react-native": {
+    "./dist/index.js": "./dist-esm/src/index.js"
+  },
   "engines": {
     "node": ">=12.0.0"
   },