re-record, wip

Azure · Aug 27, 2020 · fde972b · fde972b
1 parent baa6f13
commit fde972b
Show file tree

Hide file tree

Showing 7 changed files with 487 additions and 4,813 deletions.
diff --git a/...age/storage-blob-changefeed/recordings/node/blobchangefeedclient/recording_could_abort.js b/...age/storage-blob-changefeed/recordings/node/blobchangefeedclient/recording_could_abort.js
diff --git a/...e-blob-changefeed/recordings/node/blobchangefeedclient/recording_next_fetch_all_events.js b/...e-blob-changefeed/recordings/node/blobchangefeedclient/recording_next_fetch_all_events.js
diff --git a/...changefeed/recordings/node/blobchangefeedclient/recording_next_with_start_and_end_time.js b/...changefeed/recordings/node/blobchangefeedclient/recording_next_with_start_and_end_time.js
diff --git a/...lob-changefeed/recordings/node/blobchangefeedclient/recording_user_agent_set_correctly.js b/...lob-changefeed/recordings/node/blobchangefeedclient/recording_user_agent_set_correctly.js
diff --git a/...angefeedclient_change_feed_not_configured/recording_should_throw_when_fetching_changes.js b/...angefeedclient_change_feed_not_configured/recording_should_throw_when_fetching_changes.js
diff --git a/sdk/storage/storage-blob-changefeed/review/storage-blob-changefeed.api.md b/sdk/storage/storage-blob-changefeed/review/storage-blob-changefeed.api.md
@@ -85,7 +85,7 @@ export type BlobChangeFeedEventType = "UnspecifiedEventType" | "BlobCreated" | "
 export type BlobType = "BlockBlob" | "AppendBlob" | "PageBlob";
 
 // @public (undocumented)
-export function newPipeline(credential: StorageSharedKeyCredential | AnonymousCredential | TokenCredential, pipelineOptions?: StoragePipelineOptions): Pipeline;
+export function newPipeline(credential?: StorageSharedKeyCredential | AnonymousCredential | TokenCredential, pipelineOptions?: StoragePipelineOptions): Pipeline;
 
 
 // (No @packageDocumentation comment for this package)

diff --git a/sdk/storage/storage-blob-changefeed/src/BlobChangeFeedClient.ts b/sdk/storage/storage-blob-changefeed/src/BlobChangeFeedClient.ts
@@ -27,7 +27,7 @@ export class BlobChangeFeedEventPage {
 }
 
 export function newPipeline(
-  credential: StorageSharedKeyCredential | AnonymousCredential | TokenCredential,
+  credential?: StorageSharedKeyCredential | AnonymousCredential | TokenCredential,
   pipelineOptions: StoragePipelineOptions = {}
 ): Pipeline {
   return newPipeline(credential, BlobChangeFeedClient.appendUserAgentPrefix(pipelineOptions));