Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core-amqp] Update documentation and samples. #11114

Closed
2 tasks
richardpark-msft opened this issue Sep 8, 2020 · 1 comment · Fixed by #12554
Closed
2 tasks

[core-amqp] Update documentation and samples. #11114

richardpark-msft opened this issue Sep 8, 2020 · 1 comment · Fixed by #12554
Assignees
@ramya-rao-a
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. Docs
Milestone
[2020] December

Comments

@richardpark-msft
Copy link
Member

Going through the release checklist it looks like core-amqp's readme isn't compliant with our normal package format:

  • Needs a "support matrix" listed for node.js/browsers
  • readme snippets are missing some variables and imports so you can't just copy/paste them and run
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 8, 2020
@ramya-rao-a ramya-rao-a added Azure.Core Client This issue points to a problem in the data-plane of the library. labels Sep 9, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 9, 2020
@ramya-rao-a ramya-rao-a added this to the Backlog milestone Sep 9, 2020
@ramya-rao-a ramya-rao-a added the help wanted This issue is tracking work for which community contributions would be welcomed and appreciated label Sep 9, 2020
@ramya-rao-a ramya-rao-a self-assigned this Nov 16, 2020
@ramya-rao-a ramya-rao-a mentioned this issue Nov 16, 2020
Merged
@ramya-rao-a
Copy link
Contributor

In #12454 we removed the code snippets from the readme
#12554 will add the node.js support matrix

@ramya-rao-a ramya-rao-a removed the help wanted This issue is tracking work for which community contributions would be welcomed and appreciated label Nov 16, 2020
@ramya-rao-a ramya-rao-a modified the milestones: Backlog, [2020] December Nov 16, 2020
@ghost ghost closed this as completed in #12554 Nov 16, 2020
ghost pushed a commit that referenced this issue Nov 16, 2020
@ramya-rao-a
Add node.js support matrix in readme (#12554)
4499540 
Fixes #11114
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ramya-rao-a ramya-rao-a

Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. Docs
Projects
None yet
Milestone
[2020] December
Development

Successfully merging a pull request may close this issue.

Add node.js support matrix in readme ramya-rao-a/azure-sdk-for-js
2 participants
@ramya-rao-a @richardpark-msft