Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cosmos] Set strict to true in tsconfig #11437

Closed
ramya-rao-a opened this issue Sep 23, 2020 · 2 comments
Closed

[Cosmos] Set strict to true in tsconfig #11437

ramya-rao-a opened this issue Sep 23, 2020 · 2 comments
Labels
Client This issue points to a problem in the data-plane of the library. Cosmos good first issue This issue tracks work that may be a good starting point for a first-time contributor help wanted This issue is tracking work for which community contributions would be welcomed and appreciated

Comments

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Sep 23, 2020 •
edited
Loading

With #11424, we now have the tsconfig.json file in the cosmos project extending the base configuration, but it overrides the strict option set in the base file. This issue is to remove this override and fix any resulting errors in the project.

PRs are welcome to make this change.
Code pointers:

If you find yourself able to fix some, but not all of the resulting errors, feel free to send a PR that includes the fixes that you do have without changing the tsconfig file
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 23, 2020
@Azure Azure deleted a comment Sep 23, 2020
@ramya-rao-a
Copy link
Contributor Author

cc @zfoster for any extra thoughts on the subject

@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. Cosmos labels Sep 23, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 23, 2020
@ramya-rao-a ramya-rao-a added help wanted This issue is tracking work for which community contributions would be welcomed and appreciated needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Sep 23, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 23, 2020
@ramya-rao-a ramya-rao-a added the good first issue This issue tracks work that may be a good starting point for a first-time contributor label Sep 23, 2020
@ramya-rao-a ramya-rao-a mentioned this issue Sep 23, 2020
Merged
@underTakerChamp underTakerChamp mentioned this issue Oct 13, 2020
Merged
@ramya-rao-a
Copy link
Contributor Author

Closing in favor of #12745

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Cosmos good first issue This issue tracks work that may be a good starting point for a first-time contributor help wanted This issue is tracking work for which community contributions would be welcomed and appreciated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ramya-rao-a