Extend tsconfig in cosmos, identity from base config #11424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Should we file a separate issue to track this so it doesn't get lost? |
Yes, I plan to do that right after this PR is merged |
This was referenced Sep 23, 2020
sophiajt
approved these changes
Sep 24, 2020
deyaaeldeen
pushed a commit
to deyaaeldeen/azure-sdk-for-js
that referenced
this pull request
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the tsconfig file in the cosmos and identity packages to extend from the base file as the first step towards #5276
The next step would be to update the code to allow the strict checks that have now been disabled