Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Key Vault Admin] Restore LRO error question #12693

Closed
sadasant opened this issue Nov 25, 2020 · 2 comments
Closed

[Key Vault Admin] Restore LRO error question #12693

sadasant opened this issue Nov 25, 2020 · 2 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Milestone

Comments

@sadasant
Copy link
Contributor

We currently do the following for the KV Admin Restore LRO errors:

  • We only assume they're valid if they have a message.
  • We instantiate a new error based on the incoming error's message (this is because the incoming error is of type ErrorModel).

Is this the correct behavior?

From Jeff's feedback here:

@sadasant sadasant added Client This issue points to a problem in the data-plane of the library. KeyVault labels Nov 25, 2020
@sadasant sadasant added this to the [2021] February milestone Nov 25, 2020
@sadasant sadasant self-assigned this Nov 25, 2020
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Feb 5, 2021
typo: teh -> the (Azure#12693)

Add to flagWords since 3 letter words are usually ignored
@maorleger
Copy link
Member

We want to have a quick conversation with the service folks about what we can expect when an error condition happens. Right now there's an open issue in ADO because Authentication errors are not showing up in the error field, but are in status Details.

Ideally we'd make sure that all error conditions show up in the error field itself and we will need to confirm with them whether an error with no message is still a valid error condition (for example, maybe the innerError if still present has the message)

@maorleger
Copy link
Member

Actually, closing this one in favor of #13632

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Development

No branches or pull requests

2 participants