Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Identity] Should we separate InteractiveBrowserCredential? One for Node, one for the browser. #14783

Closed
sadasant opened this issue Apr 7, 2021 · 1 comment
Assignees
Labels
Azure.Identity blocking-release Blocks release breaking-change Client This issue points to a problem in the data-plane of the library.
Milestone

Comments

@sadasant
Copy link
Contributor

sadasant commented Apr 7, 2021

InteractiveBrowserCredential currently can be used in Node and in the browser, however:

  • In the browser, the AAD apps have to be of type SPA, while in Node they have to be Web.
  • In the browser, clientId is necessary.
  • In the browser, we allow passing configuration like "loginStyle".

I believe we started these thinking of an isomorphic experience because we were overly optimistic, but at this point it's clearer that these two are fundamentally different, and it will be hard to keep them related.

@sadasant sadasant added Client This issue points to a problem in the data-plane of the library. Azure.Identity blocking-release Blocks release labels Apr 7, 2021
@sadasant sadasant added this to the [2021] May milestone Apr 7, 2021
@ramya-rao-a
Copy link
Contributor

For the moment, we will keep the InteractiveBrowserCredential as is and focus on clearer docs where we talk about client side and server side applications separately like we have started to in http://aka.ms/azsdk/js/identity/examples

#14909 captures our plans to not have a v2 at the moment. This would mean that the implicit auth flow in InteractiveBrowserCredential will be the default, while the auth code flow is opt-in. When auth code flow is chosen and clientId is not provided, we will throw an error.

The MSAL team already has @azure/msal-browser, @azure/msal-react and @azure/msal-angular. Before making any further high stakes changes in the our auth story in the browser, it is worth syncing with the MSAL team and plan the charter together.

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Jun 15, 2021
Azure Event Grid: Add support for 2021-06-01-preview swagger (Azure#14783)

* Add support for 2021-06-01-preview swagger

* Add 2021-10-15-preview as a baseline for this commit

* Add 2021-06-06-01-preview support

* fix example

* Remove example as path/operation is not used

* Update readme.python.md

* fix python pipeline failure

Co-authored-by: Ashraf Hamad <ahamad@ntdev.microsoft.com>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Identity blocking-release Blocks release breaking-change Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants