Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ContainerRegistry] refresh token expiry time should be decoded from the token #15183

Closed
1 of 2 tasks
jeremymeng opened this issue May 7, 2021 · 0 comments · Fixed by #15457
Closed
1 of 2 tasks

[ContainerRegistry] refresh token expiry time should be decoded from the token #15183

jeremymeng opened this issue May 7, 2021 · 0 comments · Fixed by #15457
Assignees
@jeremymeng
Labels
Client This issue points to a problem in the data-plane of the library. Container Registry
Milestone
[2021] June

Comments

@jeremymeng
Copy link
Member

jeremymeng commented May 7, 2021 •
edited
Loading

currently it's hard-coded to 3 hours later.

  • need to decode it from the JWT
  • need to update recording/playback to still keep the expiry time while sanitizing the other parts.
@jeremymeng jeremymeng added Client This issue points to a problem in the data-plane of the library. Container Registry labels May 7, 2021
@jeremymeng jeremymeng added this to the [2021] June milestone May 7, 2021
@jeremymeng jeremymeng self-assigned this May 7, 2021
@jeremymeng jeremymeng mentioned this issue May 28, 2021
Merged
jeremymeng added a commit that referenced this issue Jun 7, 2021
@jeremymeng
[ContainerRegistry] get expiry time from refresh_token JWT (#15457)
486ca8a 
instead of using hard-coded 3 hours

Also update recording to replace the token value with a fake one that
contains expiry time at max date.

Resolves #15183
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Jul 14, 2021
CodeGen from PR 15183 in Azure/azure-rest-api-specs
dcc7c66 
Removing duplicate tag (Azure#15183)
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeremymeng jeremymeng

Labels
Client This issue points to a problem in the data-plane of the library. Container Registry
Projects
None yet
Milestone
[2021] June
Development

Successfully merging a pull request may close this issue.

[ContainerRegistry] get expiry time from refresh_token JWT jeremymeng/azure-sdk-for-js
1 participant
@jeremymeng