Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[monitor-query] items to complete for first release (1.0.0-beta.1) #15296

Closed
9 tasks done
richardpark-msft opened this issue May 15, 2021 · 1 comment
Closed
9 tasks done

[monitor-query] items to complete for first release (1.0.0-beta.1) #15296

richardpark-msft opened this issue May 15, 2021 · 1 comment
Assignees
@richardpark-msft
Labels
design-discussion An area of design currently under discussion and open to team and community feedback.
Milestone
[2021] July

Comments

@richardpark-msft
Copy link
Member

richardpark-msft commented May 15, 2021 •
edited
Loading

Meta-issue to keep track of the various things I'm finding as I build out the monitor-query layer and will need to continue working on:

Current

Completed

(Fixed with #15578)

  • Metrics has duplicated types across it's multiple endpoints (Unit and LocalizableString).
  • Documentation comments

(Previously fixed)

  • Current SDK doesn't have a place to specify an API key but the main demo site for ALA specifies one (https://dev.loganalytics.io/). So users won't be able to try out the library immediately.
    (feature crew has decided to not support this)
  • CI doesn't appear to be setup correctly (doesn't run on the PR for track 2): link
    (looks good now - main issue was running /azp prepare)
  • Readme is still using the template
    (readme updated!)
@richardpark-msft richardpark-msft added the design-discussion An area of design currently under discussion and open to team and community feedback. label May 15, 2021
@richardpark-msft richardpark-msft self-assigned this May 15, 2021
@richardpark-msft richardpark-msft mentioned this issue May 17, 2021
Merged
@richardpark-msft richardpark-msft changed the title [monitor-query] Meta-issue for tasks [monitor-query] items to complete for first release (1.0.0-beta.1) May 17, 2021
@richardpark-msft richardpark-msft added this to the [2021] June milestone May 17, 2021
@richardpark-msft
Copy link
Member Author

(this might release earlier than June, but it's the nearest milestone that has not passed)

@richardpark-msft richardpark-msft mentioned this issue Jun 5, 2021
Merged
richardpark-msft added a commit that referenced this issue Jun 7, 2021
@richardpark-msft
[monitor-query] Addressing last bits of feedback for 1.0.0-beta.1 (#1…
eb44449 
…5578)

Addressing more of the API review and feature crew feedback:

- Rename CommonDurations to Durations, Logs and Metrics clients are now LogsQueryClient and MetricsQueryClient, respectively.
- Make timespan a required parameter (request from the service team)
- Fixing some cosmetic naming in the samples. We have three parameters now and they're all strings...
- Deserialize `dynamic` and `Date` properties into their native types, when possible. Also, - fixed type definition for 'Table.rows' so it accomodates the wider variety of primitives it deserializes (Date, number (int, long, real), boolean and dynamic).
- LocalizableStrings are now just normal `string`'s.
- Rename the return objects from the operations to be `*Result` rather than `*Response`.

And some other general improvements:
- Add in a reliable test for server timeout using a query that Pavel cooked up.
- Fixed any outstanding lint issues and made lint a required build step so they don't sneak back in.

And making some things a bit less specified:
- Replace statistics with 'any' until we figure out how we want to map the schema.
- Leaving MetadataValue in place until I find the right replacement for it.

Fixing most of #15296
This was referenced Jun 30, 2021
Closed
Closed
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Aug 4, 2021
CodeGen from PR 15296 in Azure/azure-rest-api-specs
1936a76 
Add userAssignedIdentities property to the Identity section in 2021-05-01 and 2021-06-01-preview (Azure#15296)
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@richardpark-msft richardpark-msft

Labels
design-discussion An area of design currently under discussion and open to team and community feedback.
Projects
None yet
Milestone
[2021] July
Development

No branches or pull requests
1 participant
@richardpark-msft