Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Event Grid]Move the Event Grid package to use core-rest-pipeline #15823

Closed
sarangan12 opened this issue Jun 17, 2021 · 1 comment · Fixed by #16047
Closed

[Event Grid]Move the Event Grid package to use core-rest-pipeline #15823

sarangan12 opened this issue Jun 17, 2021 · 1 comment · Fixed by #16047
Assignees
@ellismg
Labels
Client This issue points to a problem in the data-plane of the library. Event Grid
Milestone
[2021] July

Comments

@sarangan12
Copy link
Member

Please find the details provided in #15594
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 17, 2021
@sarangan12 sarangan12 mentioned this issue Jun 17, 2021
Closed
22 tasks
@ramya-rao-a ramya-rao-a added the Client This issue points to a problem in the data-plane of the library. label Jun 17, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 17, 2021
@ellismg
Copy link
Member

ellismg commented Jun 18, 2021

Here's some work in progress: https://github.com/ellismg/azure-sdk-for-js/tree/ellismg/use-core-v2-generator The only real blocker here is the need to generate operation specs with empty paths, so right now there's a post processing step to go fix some of the generated code up.

ellismg added a commit to ellismg/azure-sdk-for-js that referenced this issue Jun 28, 2021
@ellismg
[EventGrid] Move to Core V2 Generator
ea2db80 
As part of the development of the new pipeline, event grid was hand
ported to use the new pipeline. Now that the code generator targets
the new pipeline, we can start using it to generate the code.

Since EventGrid includes the `/api/events` path segement in the
Endpoint, We need to do a small amount of post processing of the
generated code, to ensure `/api/events` is not appended to the
endpoint (we do this by setting an empty path in the operation spec,
which is as things were before moving over to the generator).

Fixes Azure#15823
@ellismg ellismg mentioned this issue Jun 28, 2021
Merged
ellismg added a commit that referenced this issue Jun 28, 2021
@ellismg
[EventGrid] Move to Core V2 Generator (#16047)
5c5c2cf 
As part of the development of the new pipeline, event grid was hand
ported to use the new pipeline. Now that the code generator targets
the new pipeline, we can start using it to generate the code.

Since EventGrid includes the `/api/events` path segment in the
Endpoint, We need to do a small amount of post processing of the
generated code, to ensure `/api/events` is not appended to the
endpoint (we do this by setting an empty path in the operation spec,
which is as things were before moving over to the generator).

Fixes #15823
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ellismg ellismg

Labels
Client This issue points to a problem in the data-plane of the library. Event Grid
Projects
None yet
Milestone
[2021] July
Development

Successfully merging a pull request may close this issue.

[EventGrid] Move to Core V2 Generator ellismg/azure-sdk-for-js
3 participants
@sarangan12 @ellismg @ramya-rao-a