Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Key Vault Keys Readme Issue #20665

Closed
zzhxiaofeng opened this issue Mar 4, 2022 · 2 comments · Fixed by #20686
Closed

Azure Key Vault Keys Readme Issue #20665

zzhxiaofeng opened this issue Mar 4, 2022 · 2 comments · Fixed by #20686
Assignees
@maorleger
Labels
Client This issue points to a problem in the data-plane of the library. Docs help wanted This issue is tracking work for which community contributions would be welcomed and appreciated KeyVault test-manual-pass

Comments

@zzhxiaofeng
Copy link
Contributor

Section link:
image

Reason:
Not output name.

Suggestion:
Remove property name.

@xirzec, @heaths, @dw511214992 for notification.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 4, 2022
@azure-sdk azure-sdk added Client This issue points to a problem in the data-plane of the library. KeyVault needs-team-triage Workflow: This issue needs the team to triage. labels Mar 4, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 4, 2022
@maorleger maorleger self-assigned this Mar 4, 2022
@maorleger maorleger added help wanted This issue is tracking work for which community contributions would be welcomed and appreciated and removed needs-team-triage Workflow: This issue needs the team to triage. labels Mar 4, 2022
@maorleger
Copy link
Member

This makes sense to me if you can open a PR to make the change? We don't use name anywhere below either so I'm fine removing it

@heaths
Copy link
Member

heaths commented Mar 4, 2022 •
edited
Loading

It used to be an output property when these docs were written but was recently removed.

@zzhxiaofeng zzhxiaofeng mentioned this issue Mar 7, 2022
Merged
maorleger pushed a commit that referenced this issue Mar 7, 2022
@zzhxiaofeng
Fix Azure Key Vault Keys Readme Issue (#20686)
19bd16d 
Fixes #20665
WeiJun428 pushed a commit to WeiJun428/azure-sdk-for-js that referenced this issue Mar 20, 2022
@zzhxiaofeng @WeiJun428
Fix Azure Key Vault Keys Readme Issue (Azure#20686)
dc241ab 
Fixes Azure#20665
WeiJun428 pushed a commit to WeiJun428/azure-sdk-for-js that referenced this issue Mar 20, 2022
@zzhxiaofeng @WeiJun428
Fix Azure Key Vault Keys Readme Issue (Azure#20686)
b2f4d03 
Fixes Azure#20665
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this issue Sep 28, 2022
@dosegal @loriatarms
@necoh @nmizrahi6 @NatanelMizrahi
CodeGen from PR 20858 in Azure/azure-rest-api-specs
0aab684 
release-securityinsights-Microsoft.SecurityInsights-2022-10-01-preview (Azure#20858)

* Adds base for updating Microsoft.SecurityInsights from version preview/2022-09-01-preview to version 2022-10-01-preview

* Updates readme

* Updates API version in new specs and examples

* fix (Azure#20640)

* AlertRules- Add SentinelEntities and extend AlertDetailsOverride (Azure#20645)

* Add SentinelEntities and extend AlertDetailsOverride

* Add SentinelEntities and extend AlertDetailsOverride

* Entities 2022 10 01 preview added security alert timeline item intent and techniques (Azure#20665)

* Added SecurityAlertTimelineItem Intent and techiques

* changed intent to enum

* reran prettier

Co-authored-by: Natanel Mizrahi <natanel.mizrahi@gmail.com>

Co-authored-by: dosegal <51155368+dosegal@users.noreply.github.com>
Co-authored-by: loriatarms <105870291+loriatarms@users.noreply.github.com>
Co-authored-by: necoh <53861229+necoh@users.noreply.github.com>
Co-authored-by: nmizrahi6 <100570740+nmizrahi6@users.noreply.github.com>
Co-authored-by: Natanel Mizrahi <natanel.mizrahi@gmail.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maorleger maorleger

Labels
Client This issue points to a problem in the data-plane of the library. Docs help wanted This issue is tracking work for which community contributions would be welcomed and appreciated KeyVault test-manual-pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Azure Key Vault Keys Readme Issue zzhxiaofeng/azure-sdk-for-js
5 participants
@maorleger @heaths @zzhxiaofeng @azure-sdk @v-xuto