[KeyVault] - Update tests that depend on non-exported constant #21188
Labels
Client
This issue points to a problem in the data-plane of the library.
KeyVault
needs-team-triage
Workflow: This issue needs the team to triage.
Comments
ghost
added
the
needs-triage
azure-sdk
added
Client
ghost
removed
the
needs-triage
This was referenced Apr 4, 2022
maorleger
added a commit
that referenced
this issue
Apr 5, 2022
### Packages impacted by this PR @azure/keyvault-admin ### Issues associated with this PR Resolves #21188 ### Describe the problem that is addressed by this PR `KeyVaultClientContext` is a generated file that in core v1 included a non-exported constant `packageVersion`. Because we have a test that depends on that constant we always have to update the file to re-export it (as the generated code does not export it). Even worse, in coreV2 that constant is not even generated anymore, so the test is outdated. This PR fixes all of these issues by examining what we _actually_ care about, which is that our user-agent includes the correct package version. This way anyone can regenerate the code at any time without getting weird build errors.
|
@maorleger did you intentionally closed this issue? |
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this issue
Nov 12, 2022
Ariflakhani/add plan is system extension property (Azure#21188) * Copied API version 2022-07-01 to 2022-11-01 * updating the API version to 2022-11-01 * udpated plan info and isSystemExtension property * Add tags for packages * Add currentVersion, deprecate installedVersion * Remove deprecated from installed version * Build error fixes * Seperate Get extension with plan and add current version property to examples * Remove Installed Version Co-authored-by: Arif Lakhani <ariflakhani@microsoft.com> Co-authored-by: Nikko Miu <nikkomiu@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Being on core v2 makes this test significantly simpler as we can just use a pipeline policy to grab the user-agent string. So I am going to wait until KV is on core v2 before updating the rest of them...
The text was updated successfully, but these errors were encountered: