Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Event Hubs] Use logger instead of debug package in test files #9209

Closed
ramya-rao-a opened this issue Jun 1, 2020 · 3 comments
Closed

[Event Hubs] Use logger instead of debug package in test files #9209

ramya-rao-a opened this issue Jun 1, 2020 · 3 comments
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs

Comments

@ramya-rao-a
Copy link
Contributor

The debug package was used for logging in older versions of the Event Hubs library. In the latest version, we moved to using the common @azure/logger package. Looks like we missed to do the same in the test files which continue to use the debug package.

This issue is to track the work needed to update the test files to use @azure/logger instead of debug for logging.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 1, 2020
@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. Event Hubs labels Jun 1, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jun 1, 2020
@ramya-rao-a ramya-rao-a added this to the Backlog milestone Jun 1, 2020
@richardpark-msft
Copy link
Member

I'll take a look and see if we even want to keep these.

@richardpark-msft
Copy link
Member

Did a little spot check of these - considering that occasionally errors lead to the tests hanging these seem like useful things to be able to selectively activate. So porting them to maybe use a single "test" logger should be enough and not horribly difficult.

And for the most part all of these should probably just go to the .verbose() stream since it's in the live tests only.

Copy link

Hi @ramya-rao-a, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 22, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2024
@xirzec xirzec removed this from the Backlog milestone May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Projects
Status: Done
Development

No branches or pull requests

3 participants