Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core-amqp] [event-hubs] Move "debug" to dev dependency #9249

Merged
merged 1 commit into from
Jun 3, 2020
Merged

[core-amqp] [event-hubs] Move "debug" to dev dependency #9249

merged 1 commit into from
Jun 3, 2020

Conversation

mikeharder
Copy link
Member

@mikeharder
Move "debug" to dev dependency
96f5ff0 
- Packages were previously changed to use "@azure/logger" at runtime
@mikeharder
Copy link
Member Author

/azp run js - eventhubs-processor - tests

@mikeharder
Copy link
Member Author

/azp run js - eventhubs-client - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mikeharder
Copy link
Member Author

/azp run js - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mikeharder mikeharder marked this pull request as ready for review June 3, 2020 01:54
@mikeharder
Copy link
Member Author

@ramya-rao-a: Can you please review this runtime dependency update? I will wait until all live tests pass before merging.

@ramya-rao-a
Copy link
Contributor

fyi, you don't need to run the tests for eventhubs-processor as part of this PR, it does not use core-amqp or the version of event-hubs that is in the master branch

@mikeharder mikeharder closed this Jun 3, 2020
@mikeharder mikeharder reopened this Jun 3, 2020
@mikeharder mikeharder merged commit a6e4ba4 into Azure:master Jun 3, 2020
@mikeharder mikeharder deleted the debug-dev-dependency branch June 3, 2020 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramya-rao-a ramya-rao-a ramya-rao-a approved these changes

@chradek chradek Awaiting requested review from chradek

@richardpark-msft richardpark-msft Awaiting requested review from richardpark-msft

Assignees

@ramya-rao-a ramya-rao-a

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeharder @ramya-rao-a