[service-bus] Fix issue with live tests failing on session-based tests #10325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sessionId and partitionKey is now considered a failure.
richardpark-msft
requested review from
chradek,
HarshaNalluru and
ramya-rao-a
as code owners
ghost
added
the
2 tasks
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ramya-rao-a
approved these changes
Jul 29, 2020
|
Looks like there are still some failures. |
…live test run on my BatchingReceiverLite PR * Moved the receiverInit.spec.ts into 'internal' since it is purely a unit test.
|
/azp run js - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Yeah, there were a few more spots that were toggling the sessionId without also updating the partitionKey. I also have a test failure that I introduced when I accidentally merged the BatchingReceiverLite changes without re-running the live tests (facepalm). I believe I got them all now, just rerunning. |
HarshaNalluru
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A service-side change made it so setting the partition id and session id to different values an error in some cases where, before, it would have been incorrect but harmless.
This fixes our test data so we don't run afoul of that rule. I've filed an issue (#10326) to deal with two problems that came out as a result of this.