Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service Bus] Values for props on correlation filters only supports some types #10490

Conversation

HarshaNalluru
Copy link
Member

@HarshaNalluru HarshaNalluru commented Aug 7, 2020

"string", "boolean" and "number" are the only supported types in the values in the correlation rule properties at the moment.
Proper validation logic is already present, this PR is just to improve the docs/type info on the interface.

Waiting for this to support more types #9850

Copy link
Member

@richardpark-msft richardpark-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, now I get what you were discussing earlier. My mind kept subconsciously stripping out the quotes for the types.

@HarshaNalluru HarshaNalluru merged commit 177a055 into Azure:master Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants