Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Key Vault Admin] Convenience layer - KeyVaultBackupClient #11009

Merged
merged 13 commits into from
Sep 9, 2020
Merged

[Key Vault Admin] Convenience layer - KeyVaultBackupClient #11009

merged 13 commits into from
Sep 9, 2020

Commits on Sep 3, 2020

  1. [Key Vault Admin] The Backup client source code

    @sadasant
    sadasant committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    5497e96 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2020

  1. Updates based on feedback, specially docs

    @sadasant
    sadasant committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    63be7cf View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Christopher Scott <chriscott@hotmail.com>
    @sadasant @christothes
    sadasant and christothes authored Sep 4, 2020
    Configuration menu
    Copy the full SHA
    cd9bec8 View commit details
    Browse the repository at this point in the history

  3. Param feedback and comments

    @sadasant
    sadasant committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    7e393c2 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'Azure/master' into keyvault-admin/backu… 

    …pClient
    @sadasant
    sadasant committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    f3a134b View commit details
    Browse the repository at this point in the history

  5. api review update

    @sadasant
    sadasant committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    896edaa View commit details
    Browse the repository at this point in the history

  6. small update I did on lro/backup/operation, now on lro/restore/operation

    @sadasant
    sadasant committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    b8385cc View commit details
    Browse the repository at this point in the history

  7. Comment improvement, I think

    @sadasant
    sadasant committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    bfda811 View commit details
    Browse the repository at this point in the history

  8. comment fix

    @sadasant
    sadasant committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    b3360d1 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2020

  1. moving the internal properties to an options bag

    @sadasant
    sadasant committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    d3400eb View commit details
    Browse the repository at this point in the history

  2. no need for requestParameters

    @sadasant
    sadasant committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    18f4e43 View commit details
    Browse the repository at this point in the history

  3. no need for requestParameters, and some cleanup on the pollers

    @sadasant
    sadasant committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    fd05a52 View commit details
    Browse the repository at this point in the history

  4. Addressed Azure#11009 (comment)

    @sadasant
    sadasant committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    be8b915 View commit details
    Browse the repository at this point in the history