-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Service Bus] ATOM API: Supporting "Date" in the correlation-rule-filter props #11117
Merged
HarshaNalluru
merged 10 commits into
Azure:master
from
HarshaNalluru:harshan/sb/issue/9850-part-6
Sep 29, 2020
Merged
[Service Bus] ATOM API: Supporting "Date" in the correlation-rule-filter props #11117
HarshaNalluru
merged 10 commits into
Azure:master
from
HarshaNalluru:harshan/sb/issue/9850-part-6
Sep 29, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarshaNalluru
requested review from
bterlson,
chradek,
qiaozha,
ramya-rao-a,
richardpark-msft and
xirzec
as code owners
September 8, 2020 21:06
ghost
added
the
Service Bus
label
Sep 8, 2020
14 tasks
HarshaNalluru
changed the title
[Service Bus] ATOM API: Supporting "Date" in the correlation-rule-filter
[Service Bus] ATOM API: Supporting "Date" in the correlation-rule-filter props
Sep 9, 2020
…to harshan/sb/issue/9850-part-6
richardpark-msft
approved these changes
Sep 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a sensible change. More types, the better :)
Co-authored-by: Richard Park <51494936+richardpark-msft@users.noreply.github.com>
…shaNalluru/azure-sdk-for-js into harshan/sb/issue/9850-part-6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #9850 (Part 6)
Adding support for the Date type in the corrrelation-rule-filter w.r.t serialization and deserialization as expected by the Service Bus Service.