Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logger] Cleaning up and fixing linting #11466

Merged
merged 2 commits into from
Sep 25, 2020

Conversation

deyaaeldeen
Copy link
Member

@deyaaeldeen deyaaeldeen commented Sep 24, 2020

Switching the eslint configuration file used for logging to use the newer one in the root of the repository and fixing all the linting problems. Furthermore, enforce the absence of linting errors in CI.

Copy link
Member

@xirzec xirzec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for standardizing the main module name!

sdk/core/logger/src/debug.ts Outdated Show resolved Hide resolved
@deyaaeldeen deyaaeldeen merged commit 97f4b7a into Azure:master Sep 25, 2020
@deyaaeldeen deyaaeldeen deleted the logger-linting branch September 25, 2020 16:10
deyaaeldeen added a commit to deyaaeldeen/azure-sdk-for-js that referenced this pull request Sep 25, 2020
* [Logger] Cleaning up and fixing linting

* disable no-invalid-this in entire file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants