Added post deployment step to create SAS with additional permission #11509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
praveenkuttappan
added
the
Central-EngSys
|
/azp run js - storage - tests |
|
No pipelines are associated with this pull request. |
praveenkuttappan
requested review from
HarshaNalluru,
jeremymeng,
jiacfan,
ljian3377,
vinjiang and
XiaoningLiu
as code owners
|
Verified SAS creation using permissions: rwdxftlacup |
weshaggard
reviewed
Sep 25, 2020
|
|
||
|
|
||
| # Try to detect the shell based on the parent process name (e.g. launch via shebang). |
There was a problem hiding this comment.
As we talked I'm Ok with this approach for now but I do think it is worth filing an issue in the tools repo about adding support for such scenarios because I'd hate to see this code duplicated a lot of times.
There was a problem hiding this comment.
File issue Azure/azure-sdk-tools#1044 to track and add support in common place rather than in individual service script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated post deployment pwsh script to create SAS with new permissions that are not supported by SRP deployment now.