Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[storage][stg74] address PR comments #11520

Merged
merged 9 commits into from
Oct 9, 2020
Merged

[storage][stg74] address PR comments #11520

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
024a1e7
wip
ljian3377 Sep 25, 2020
415fbe3
overload SASQueryParameters constructor
ljian3377 Sep 27, 2020
6330ad4
api extract
ljian3377 Sep 27, 2020
9b3154a
Rename leaseTime -> leaseTimeInSeconds
ljian3377 Sep 27, 2020
62466e1
share lease tests
ljian3377 Sep 27, 2020
72be4cd
container restore test wip
ljian3377 Sep 27, 2020
c5b94ba
restore container test fixed
ljian3377 Sep 28, 2020
69b0106
fix CI
ljian3377 Sep 28, 2020
ef30f6e
make options optional and add comments
ljian3377 Oct 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sdk/storage/storage-blob/karma.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,9 @@ module.exports = function(config) {
"ENCRYPTION_SCOPE_1",
"ENCRYPTION_SCOPE_2",
"ORS_DEST_ACCOUNT_NAME",
"ORS_DEST_ACCOUNT_SAS"
"ORS_DEST_ACCOUNT_SAS",
"CONTAINER_SOFT_DELETE_ACCOUNT_NAME",
"CONTAINER_SOFT_DELETE_ACCOUNT_SAS"
],

// test results reporter to use
Expand Down
88 changes: 88 additions & 0 deletions ...orage/storage-blob/recordings/browsers/blobserviceclient/recording_restore_container.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading