remove lint:terminal script across our packages #11530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deyaaeldeen
requested review from
bterlson,
chradek,
daviwil,
HarshaNalluru,
jeremymeng,
sophiajt,
sadasant and
xirzec
as code owners
ghost
added
ramya-rao-a
approved these changes
Sep 28, 2020
|
Please update the PR description with the motivation for this change so that anyone passing by has a clearer understanding of why we do what we do :) |
|
Also, there are merge conflicts |
|
@ramya-rao-a fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of npm scripts should be standardized and one of the scripts that is not in every package is
lint:terminal. This PR removes it across our packages.