Increment version for communication releases #11538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominikMe
requested review from
RezaJooyandeh,
weshaggard and
0rland0Wats0n
weshaggard
reviewed
Sep 28, 2020
| @@ -65,7 +65,7 @@ | |||
| "prettier": "@azure/eslint-plugin-azure-sdk/prettier.json", | |||
| "dependencies": { | |||
| "@azure/abort-controller": "^1.0.0", | |||
| "@azure/communication-common": "1.0.0-beta.1", | |||
| "@azure/communication-common": "1.0.0-beta.2", | |||
There was a problem hiding this comment.
Was this the only reason you needed to replace the auto-generated PR?
There was a problem hiding this comment.
Yes, restoring packages failed in CI because of this.
The autorest package-version change is just sugar to fix the user-agent that's being sent.
ramya-rao-a
approved these changes
Sep 29, 2020
|
/azp run js - communication - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces auto-generated #11387
In addition to the generated version bump, this PR increments package-version for autorest and fixes the dependencies.