[EventGrid] Distributed Tracing for EventGrid #11562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellismg
commented
Sep 30, 2020
| @@ -0,0 +1,75 @@ | |||
| // Copyright (c) Microsoft Corporation. | |||
There was a problem hiding this comment.
Would love you feedback on this approach, Jeff. We want the values we put in the event to be the same as what we put in the HTTP headers, and this seemed like the best way to do this.
xirzec
reviewed
Sep 30, 2020
sdk/eventgrid/eventgrid/src/cloudEventDistrubtedTracingEnricherPolicy.ts
Outdated
Show resolved
Hide resolved
sdk/eventgrid/eventgrid/src/cloudEventDistrubtedTracingEnricherPolicy.ts
Outdated
Show resolved
Hide resolved
sdk/eventgrid/eventgrid/src/cloudEventDistrubtedTracingEnricherPolicy.ts
Outdated
Show resolved
Hide resolved
sdk/eventgrid/eventgrid/src/cloudEventDistrubtedTracingEnricherPolicy.ts
Outdated
Show resolved
Hide resolved
ellismg
force-pushed
the
ellismg/enrich-cloud-events-with-distributed-tracing
branch
from
db220b8
to
f413273
Compare
|
@xirzec Sorry for the delay in responding to your feedback. Could you please take another look? |
- Create spans for each of the send operations on `EventGridPublisherClient` - When sending events in the Cloud Events schema, if we have a traceparent or tracestate and an event we are sending does not have any distributed tracing metadata (per the Cloud Events distributed tracing spec) we add this metadata associating the events with the span representing the HTTP operation that sends the event to the Azure Event Grid Service. Fixes: Azure#11056
ellismg
force-pushed
the
ellismg/enrich-cloud-events-with-distributed-tracing
branch
from
f413273
to
1ffd3aa
Compare
Belatedly this also looks good to me! Good job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create spans for each of the send operations on
EventGridPublisherClientWhen sending events in the Cloud Events schema, if we have a
traceparent or tracestate and an event we are sending does not have
any distributed tracing metadata (per the Cloud Events distributed
tracing spec) we add this metadata associating the events with the
span representing the HTTP operation that sends the event to the Azure
Event Grid Service.
Fixes: #11056