-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Service Bus] Fix test failure in the canary region #11588
Merged
1 commit merged into
Azure:master
from
HarshaNalluru:harshan/sb/issue/fix-canary-test-failures
Oct 1, 2020
Merged
[Service Bus] Fix test failure in the canary region #11588
1 commit merged into
Azure:master
from
HarshaNalluru:harshan/sb/issue/fix-canary-test-failures
Oct 1, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarshaNalluru
requested review from
chradek,
ramya-rao-a and
richardpark-msft
as code owners
October 1, 2020 20:48
ghost
added
the
Service Bus
label
Oct 1, 2020
richardpark-msft
approved these changes
Oct 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good - nice find!
Hello @HarshaNalluru! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
pushed a commit
that referenced
this pull request
Oct 2, 2020
From #11576 ![image](https://user-images.githubusercontent.com/10452642/94872905-b18a2b00-0402-11eb-8339-8818586a594a.png) ### Background We realized the max message size on the link has been increased with #11588. ### Cause The new test failures were caused since the messages that can be held/sent are have been increased through the new limit, more many messages being sent would mean that we'd receive all of them and verify per the test which would take more time and hence the timeouts. ### Fix in the test Increase the message size and also create messages based on the maxMessageSize. This brings down the test time and would also be mindful of the potential size increase in the future.
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Nov 11, 2020
Dev containerservice microsoft.container service 2020 11 01 (Azure#11588) * Adds base for updating Microsoft.ContainerService from version stable/2020-09-01 to version 2020-11-01 * Updates readme * Updates API version in new specs and examples * add autoupgradeprofile to 2020-11-01 (Azure#11363) * add autoupgradeprofile * add autoupgrader profile to mc * format change Co-authored-by: Xiahe Liu <Xiahe.Liu@microsoft.com> * add pod subnet id on agentpool (Azure#11310) * aks: add pod identity profile spec (Azure#11366) * add private dns zone property in 2020-11-01 (Azure#11311) Co-authored-by: Li Ma <lima2@microsoft.com> * Remove invalid pattern and adjust description (Azure#11312) * aks: fix pod identity profile field names (Azure#11484) * aks: add missing `podIdentityProfile.enabled` field * aks: typo * add non upgrade channel (Azure#11492) Co-authored-by: Xiahe Liu <Xiahe.Liu@microsoft.com> * Make identityProfile mutable (Azure#11458) * Add KubeletConfig and LinuxOSConfig specs (Azure#11490) * aks: update readme tag for 1101 (Azure#11472) * aks: update readme tag * aks: add `2020-11-01-only` * resovle merge conlicts to master, adding recent master change to dev branch (Azure#11604) Co-authored-by: Xiahe Liu <Xiahe.Liu@microsoft.com> Co-authored-by: Xiahe Liu <Xiahe.Liu@microsoft.com> Co-authored-by: Paul Miller <pmiller@microsoft.com> Co-authored-by: hbc <me@hbc.rocks> Co-authored-by: Super <mali_no2@hotmail.com> Co-authored-by: Li Ma <lima2@microsoft.com> Co-authored-by: Qingchuan Hao <haoqingchuan@hotmail.com> Co-authored-by: Tongyao Si <tosi@microsoft.com> Co-authored-by: Bo Wang <61758179+bowang-666@users.noreply.github.com> Co-authored-by: Phoenix He <tih@microsoft.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #11576