Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Key Vault Keys] Fixed wrong method in a readme sample #11601

Merged
merged 1 commit into from
Oct 2, 2020
Merged

[Key Vault Keys] Fixed wrong method in a readme sample #11601

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk/keyvault/keyvault-keys/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -641,7 +641,7 @@ async function main() {
let digest = hash.update(signatureValue).digest();
console.log("digest: ", digest);

const signResult = await cryptographyClient.signData("RS256", digest);
const signResult = await cryptographyClient.sign("RS256", digest);
Copy link
Contributor Author

@sadasant sadasant Oct 2, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this section is indeed in the "Sign" section: https://github.com/Azure/azure-sdk-for-js/pull/11601/files#diff-1c2d798c10ee336ec71c67fc29c2222cR617-R619

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also note that these methods accept the same parameters. Here's a test: https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/keyvault/keyvault-keys/test/public/crypto.spec.ts#L110

console.log("sign result: ", signResult.result);
}

Expand Down